GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Async Functions for ES6 by rbuckton · Pull Request #3078 · microsoft/TypeScript

Conversation

@rbuckton

@rbuckton Ron Buckton (rbuckton) commented May 8, 2015

Copy link
Copy Markdown
Contributor

Adds support for async functions when targeting ES6 only.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ron Buckton (rbuckton) added 4 commits May 5, 2015 17:57
@rbuckton
Added types, scan, parse, and check for async functions
d19a200
@rbuckton
Added emit for async functions in ES6
e82e841
@rbuckton
Bug fixes and baselines
80edb2d
@rbuckton
Merge branch 'master' into asyncFunctions
1718ff2
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label May 8, 2015
@rbuckton
Updated baselines
bca21ec
CyrusNajmabadi
CyrusNajmabadi reviewed May 8, 2015
View reviewed changes
Comment thread src/compiler/parser.ts Outdated

@CyrusNajmabadi Cyrus Najmabadi (CyrusNajmabadi) May 8, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'setContextFlags' is not a great name (esp as we have a function call setContextFlag). Maybe 'newContextFlags'?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rbuckton Ron Buckton (rbuckton) May 8, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setContextFlags -> contextFlagsToClear
unsetContextFlags -> contextFlagsToSet

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@CyrusNajmabadi Cyrus Najmabadi (CyrusNajmabadi) May 8, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhegazy
mhegazy reviewed Jun 16, 2015
View reviewed changes
Comment thread src/compiler/parser.ts Outdated

@mhegazy Mohamed Hegazy (mhegazy) Jun 16, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ron Buckton (rbuckton) added 10 commits June 17, 2015 16:05
@rbuckton
Removed unused getContainingParameter function
b25d855
@rbuckton
Inlined checks for NodeFlags.Async in parser
82eae19
@rbuckton
Moved getContainingFunction call in checkIdentifier
c74bb84
@rbuckton
Removed unneeded capture for lexical this
b00a957
@rbuckton
Changed createPromiseType to return emptyObjectType
02f6622
@rbuckton
Cleaned up diagnostics
7443ecc
@rbuckton
Cleaned up async return type check
2891a1d
@rbuckton
Add support for awaiting union types with mixed promise and non-promi…
c4876d5 
…se constituents.
@rbuckton
Minor function rename
379d74a
@rbuckton
Added shortcut in checkAwaitedType for isolatedModules
eb03ae8
@mhegazy Mohamed Hegazy (mhegazy) mentioned this pull request Jun 19, 2015
Async Functions #1781
Closed
Ron Buckton (rbuckton) added 3 commits June 19, 2015 16:01
@rbuckton
Fix async function emit for lexical arguments
5b32903
@rbuckton
Moved async functions for ES6 behind experimental flag
76c0d32
@rbuckton
Merge branch 'master' into asyncFunctions
4b4a96b
Ron Buckton (rbuckton) added a commit that referenced this pull request Jul 1, 2015
@rbuckton
Merge pull request #3078 from Microsoft/asyncFunctions
b2a871d 
Async Functions for ES6
@rbuckton
Ron Buckton (rbuckton) merged commit b2a871d into master Jul 1, 2015
@rbuckton
Ron Buckton (rbuckton) deleted the asyncFunctions branch July 1, 2015 16:51
@rbuckton Ron Buckton (rbuckton) mentioned this pull request Jul 2, 2015
Down-level lexical 'arguments' binding for arrow functions #3716
Closed
@saschanaz Kagami Sascha Rosylight (saschanaz) mentioned this pull request Jul 19, 2015
Proposal: Async Functions #1664
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@rbuckton @JsonFreeman @yuit @DanielRosenwasser @ahejlsberg @CyrusNajmabadi @mhegazy @msftclas @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.