GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add all-settled in promise by Kingwl · Pull Request #31085 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Apr 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #31083

It's toooooooooo hard to write ten overload

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
saschanaz and asaarnak reacted with laugh emoji JReinhold and kondei reacted with heart emoji hasparus reacted with eyes emoji
All reactions
  • 😄 2 reactions
  • ❤️ 2 reactions
  • 👀 1 reaction
@Kingwl
add all-settled in promise
5c0cea7
ajafff
Klaus Meinhardt (ajafff) reviewed Apr 24, 2019
View reviewed changes
Comment thread src/lib/esnext.promise.d.ts Outdated
@@ -0,0 +1,74 @@
/** @internal */

@ajafff Klaus Meinhardt (ajafff) Apr 24, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this internal? if it was stripped by stripInternal (I don't think it is), it would create an invalid declaration file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Wenlu Wang (Kingwl) added 4 commits April 25, 2019 10:21
@Kingwl
remove unnecessary internal
bc4c5e0
@Kingwl
Merge branch 'master' into all-settled
e06d34f
@Kingwl
update merge failed
1f96506
@Kingwl
update line feed
6def309
@Kingwl

Wenlu Wang (Kingwl) commented May 7, 2019

Copy link
Copy Markdown
Contributor Author

seems ci is broken
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RyanCavanaugh
Merge branch 'master' into all-settled
1e08cc2
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) assigned Ron Buckton (rbuckton) Aug 15, 2019
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Aug 15, 2019

Copy link
Copy Markdown
Member

Fixed merge conflicts, let's see how CI goes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RyanCavanaugh
Fix line endings
ff13c45
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Aug 15, 2019

Copy link
Copy Markdown
Member

♥ line ending problems
Kingwl reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented Aug 27, 2019

Copy link
Copy Markdown
Contributor Author

Anything else needs me to update?🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented Sep 16, 2019

Copy link
Copy Markdown
Contributor Author

🙋🏻‍♂️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl Wenlu Wang (Kingwl) mentioned this pull request Oct 7, 2019
add promise.any #33844
Merged
@ExE-Boss ExE Boss (ExE-Boss) mentioned this pull request Oct 12, 2019
feat(lib/es2020): Add Promise.allSettled(…) #34065
Merged
@Kingwl Wenlu Wang (Kingwl) closed this Oct 28, 2019
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ajafff Klaus Meinhardt (ajafff) ajafff left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rbuckton Ron Buckton (rbuckton)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

proposal-promise-allSettled

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Kingwl @RyanCavanaugh @ajafff @rbuckton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.