GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add promise.any by Kingwl · Pull Request #33844 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Oct 7, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #33843

BTW: #31085

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mt-yannick and alii reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Kingwl
Wenlu Wang (Kingwl) force-pushed the promise-prototype-any branch from 7ee1d7f to 708449f Compare October 7, 2019 09:35
@Kingwl
add promise.prototype.any
d5160d1
@Kingwl
Wenlu Wang (Kingwl) force-pushed the promise-prototype-any branch from 708449f to d5160d1 Compare October 7, 2019 09:56
@Kingwl
add AggregateError
0f8f9f0
@Kingwl
Wenlu Wang (Kingwl) force-pushed the promise-prototype-any branch from 20c3784 to 0f8f9f0 Compare October 16, 2019 09:08
@Kingwl Wenlu Wang (Kingwl) changed the title add promise.prototype.any add promise.any Oct 28, 2019
chicoxyzzy
Sergey Rubanov (chicoxyzzy) suggested changes Nov 3, 2019
View reviewed changes
Comment thread src/lib/esnext.promise.d.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sandersn Nathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020
sandersn
Nathan Shively-Sanders (sandersn) requested changes Mar 4, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenlu Wang (@Kingwl) This looks good; I'll merge it as soon as you update the jsdoc. (I'm not sure my suggestion is the best -- it might be possible to condense the wording overall.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/lib/esnext.promise.d.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Wenlu Wang (Kingwl) and others added 4 commits March 11, 2020 15:59
@Kingwl @sandersn
Update src/lib/esnext.promise.d.ts
9fe87af
Co-Authored-By: Nathan Shively-Sanders <[email protected]>
@Kingwl
Merge branch 'master' into promise-prototype-any
d351d27
@Kingwl
Merge branch 'master' into promise-prototype-any
3e10c75
@sandersn
update baseline again
82a44f5
@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 11, 2020

Copy link
Copy Markdown
Member

A baseline needed to be updated after the merge from master. I'll merge this after CI finishes running.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sandersn
Nathan Shively-Sanders (sandersn) approved these changes Mar 11, 2020
View reviewed changes
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 20625a9 into microsoft:master Mar 11, 2020
@mt-yannick

Chiasson Yannick (mt-yannick) commented Jun 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hi, I am able to compile successfully but at runtime, I receive a Promise.any is undefined error. I am using typescript 3.9.5 in my project. This is my tsconfig:

{
  "compilerOptions": {
    "target": "ES6",
    "module": "commonjs",
    "strict": true,
    "esModuleInterop": true,
    "outDir": "dist",
    "lib": [
      "dom",
      "esnext",
      "esnext.promise"
    ],
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "forceConsistentCasingInFileNames": true,
    "inlineSourceMap": true,
  }
}

Any feedback would be much appreciated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alt1o

zuomeng wang (alt1o) commented Aug 10, 2020

Copy link
Copy Markdown

Hi, I am able to compile successfully but at runtime, I receive a Promise.any is undefined error. I am using typescript 3.9.5 in my project. This is my tsconfig:

{
  "compilerOptions": {
    "target": "ES6",
    "module": "commonjs",
    "strict": true,
    "esModuleInterop": true,
    "outDir": "dist",
    "lib": [
      "dom",
      "esnext",
      "esnext.promise"
    ],
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "forceConsistentCasingInFileNames": true,
    "inlineSourceMap": true,
  }
}

Any feedback would be much appreciated.

same with me. typescript 3.9.7

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sandersn

Nathan Shively-Sanders (sandersn) commented Aug 10, 2020

Copy link
Copy Markdown
Member

Chiasson Yannick (@mt-yannick) @alongite what VM are you using? I looked at https://caniuse.com/#search=Promise.any and it's only on recent versions of Chrome and Firefox as far as I can tell. It's not in Node 14 yet.

mt-yannick reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mt-yannick

Chiasson Yannick (mt-yannick) commented Oct 6, 2020

Copy link
Copy Markdown

Nathan Shively-Sanders (@sandersn) Oh! Thank you for clarifying!! So if I understand correctly, this PR implements the types for Promise.any, and specifying "esnext.promise" in compilerOptions.libs will make the compiler aware that Promise.any exists, but we are still responsible for assuring that an implementation exists!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Oct 7, 2020
@sandersn
Fix missed tasks to add esnext.weakref
9befc78
Follow up to #38232, based on #33844
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Oct 7, 2020
Fix missed tasks to add esnext.weakref #40981
Merged
Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Oct 7, 2020
@sandersn
Fix missed tasks to add esnext.weakref (#40981)
fc783a9
Follow up to #38232, based on #33844
@sandersn

Nathan Shively-Sanders (sandersn) commented Oct 7, 2020

Copy link
Copy Markdown
Member

Chiasson Yannick (@mt-yannick) yes, that's exactly right. Stuff in "esnext" is going to be very new, so you may need to provide your own polyfill.

mt-yannick reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
+1 more reviewer
@chicoxyzzy Sergey Rubanov (chicoxyzzy) chicoxyzzy requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

proposal-promise-any

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Kingwl @sandersn @mt-yannick @alt1o @chicoxyzzy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.