GeezerVison is showing github.com — add promise.any by Kingwl · Pull Request #33844 · microsoft/TypeScript
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mt-yannick and alii reacted with thumbs up emoji
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wenlu Wang (@Kingwl) This looks good; I'll merge it as soon as you update the jsdoc. (I'm not sure my suggestion is the best -- it might be possible to condense the wording overall.)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
A baseline needed to be updated after the merge from master. I'll merge this after CI finishes running.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hi, I am able to compile successfully but at runtime, I receive a Promise.any is undefined error. I am using typescript 3.9.5 in my project. This is my tsconfig:
{
"compilerOptions": {
"target": "ES6",
"module": "commonjs",
"strict": true,
"esModuleInterop": true,
"outDir": "dist",
"lib": [
"dom",
"esnext",
"esnext.promise"
],
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"forceConsistentCasingInFileNames": true,
"inlineSourceMap": true,
}
}
Any feedback would be much appreciated.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Hi, I am able to compile successfully but at runtime, I receive a Promise.any is undefined error. I am using typescript 3.9.5 in my project. This is my tsconfig:
{
"compilerOptions": {
"target": "ES6",
"module": "commonjs",
"strict": true,
"esModuleInterop": true,
"outDir": "dist",
"lib": [
"dom",
"esnext",
"esnext.promise"
],
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"forceConsistentCasingInFileNames": true,
"inlineSourceMap": true,
}
}
Any feedback would be much appreciated.
same with me. typescript 3.9.7
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mt-yannick reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Nathan Shively-Sanders (@sandersn) Oh! Thank you for clarifying!! So if I understand correctly, this PR implements the types for Promise.any, and specifying "esnext.promise" in compilerOptions.libs will make the compiler aware that Promise.any exists, but we are still responsible for assuring that an implementation exists!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mt-yannick reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
proposal-promise-any
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|