GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve newlines from original source when printing nodes from TextChanges by andrewbranch · Pull Request #36688 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Feb 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #27294

I feel like some of this logic looks kind of ugly, but the perf impact for normal compiler runs is down to nothing, so I’m ready to get some fresh eyes on this.

Note that this is still dependent on the emitter actually checking for source newlines between tokens, which it was already pretty good about, but there may still be some cases where newlines get removed. Additionally, the formatter runs after TextChanges, and so any formatter rules that add or remove newlines will take priority. But, this more than addresses the example given in #27294, which was just about newlines between full statements/declarations. Generally, preserving newlines in anything that’s a list works quite well, and I think that’s likely to be what people care most about (followed by chained property access and nested binary expressions, which are also tested here).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markusjohnsson, alexrock, RyanCavanaugh, DanielRosenwasser, and PKief reacted with heart emoji
All reactions
  • ❤️ 5 reactions
Andrew Branch (andrewbranch) added 5 commits February 6, 2020 09:06
@andrewbranch
Allow emitter to write multiple newlines in node lists
2b9e4aa
@andrewbranch
Progress
c689617
@andrewbranch
Progress
6e272f3
@andrewbranch
Fix recomputeIndentation
839fb8e
@andrewbranch
Add tests, fix leading line terminator count
0ea8d79
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) Feb 7, 2020
@typescript-bot TypeScript Bot (typescript-bot) added the Author: Team label Feb 7, 2020
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 7, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 0ea8d79. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 356,865k (± 0.03%) 358,557k (± 0.01%) +1,692k (+ 0.47%) 358,473k 358,637k
Parse Time 1.61s (± 0.64%) 1.62s (± 0.54%) +0.01s (+ 0.68%) 1.61s 1.65s
Bind Time 0.89s (± 0.50%) 0.88s (± 0.74%) -0.01s (- 1.13%) 0.87s 0.89s
Check Time 4.69s (± 0.53%) 4.68s (± 0.52%) -0.01s (- 0.30%) 4.64s 4.73s
Emit Time 5.23s (± 0.80%) 5.39s (± 0.96%) +0.17s (+ 3.18%) 5.29s 5.55s
Total Time 12.42s (± 0.47%) 12.57s (± 0.55%) +0.15s (+ 1.18%) 12.45s 12.72s
Monaco - node (v10.16.3, x64)
Memory used 364,650k (± 0.02%) 364,721k (± 0.02%) +71k (+ 0.02%) 364,608k 364,870k
Parse Time 1.25s (± 0.58%) 1.26s (± 0.99%) +0.01s (+ 0.40%) 1.24s 1.29s
Bind Time 0.78s (± 0.75%) 0.78s (± 0.64%) -0.00s (- 0.26%) 0.76s 0.78s
Check Time 4.69s (± 0.42%) 4.69s (± 0.40%) -0.00s (- 0.06%) 4.64s 4.73s
Emit Time 2.90s (± 0.81%) 3.12s (± 0.80%) +0.22s (+ 7.65%) 3.07s 3.18s
Total Time 9.62s (± 0.36%) 9.84s (± 0.53%) +0.22s (+ 2.28%) 9.74s 9.94s
TFS - node (v10.16.3, x64)
Memory used 324,088k (± 0.01%) 324,220k (± 0.02%) +132k (+ 0.04%) 324,097k 324,357k
Parse Time 0.95s (± 0.52%) 0.95s (± 0.89%) -0.01s (- 0.52%) 0.93s 0.97s
Bind Time 0.75s (± 1.26%) 0.74s (± 1.76%) -0.01s (- 1.47%) 0.71s 0.76s
Check Time 4.25s (± 0.58%) 4.24s (± 0.45%) -0.01s (- 0.24%) 4.20s 4.30s
Emit Time 3.03s (± 0.86%) 3.34s (± 0.59%) +0.31s (+10.34%) 3.30s 3.37s
Total Time 8.98s (± 0.60%) 9.27s (± 0.19%) +0.29s (+ 3.21%) 9.24s 9.31s
Angular - node (v12.1.0, x64)
Memory used 332,704k (± 0.03%) 334,333k (± 0.02%) +1,629k (+ 0.49%) 334,227k 334,439k
Parse Time 1.57s (± 0.60%) 1.58s (± 0.65%) +0.01s (+ 0.77%) 1.56s 1.61s
Bind Time 0.87s (± 0.75%) 0.88s (± 0.80%) +0.01s (+ 1.50%) 0.87s 0.90s
Check Time 4.58s (± 0.61%) 4.60s (± 0.29%) +0.02s (+ 0.35%) 4.57s 4.63s
Emit Time 5.41s (± 0.59%) 5.64s (± 0.63%) +0.23s (+ 4.31%) 5.56s 5.73s
Total Time 12.43s (± 0.43%) 12.70s (± 0.42%) +0.28s (+ 2.23%) 12.57s 12.84s
Monaco - node (v12.1.0, x64)
Memory used 344,537k (± 0.02%) 344,549k (± 0.02%) +13k (+ 0.00%) 344,368k 344,739k
Parse Time 1.21s (± 0.87%) 1.22s (± 0.37%) +0.00s (+ 0.33%) 1.21s 1.23s
Bind Time 0.75s (± 0.78%) 0.75s (± 0.82%) +0.00s (+ 0.54%) 0.74s 0.76s
Check Time 4.54s (± 0.44%) 4.56s (± 0.22%) +0.02s (+ 0.37%) 4.53s 4.58s
Emit Time 2.96s (± 0.61%) 3.24s (± 0.85%) +0.28s (+ 9.48%) 3.18s 3.30s
Total Time 9.45s (± 0.40%) 9.76s (± 0.41%) +0.31s (+ 3.28%) 9.65s 9.85s
TFS - node (v12.1.0, x64)
Memory used 306,435k (± 0.02%) 306,540k (± 0.02%) +105k (+ 0.03%) 306,420k 306,675k
Parse Time 0.94s (± 0.80%) 0.95s (± 0.55%) +0.00s (+ 0.53%) 0.94s 0.96s
Bind Time 0.71s (± 0.94%) 0.70s (± 1.17%) -0.01s (- 0.85%) 0.69s 0.73s
Check Time 4.17s (± 0.46%) 4.16s (± 0.56%) -0.01s (- 0.31%) 4.10s 4.23s
Emit Time 3.08s (± 0.48%) 3.46s (± 0.62%) +0.37s (+12.06%) 3.40s 3.51s
Total Time 8.91s (± 0.21%) 9.27s (± 0.41%) +0.36s (+ 4.05%) 9.18s 9.37s
Angular - node (v8.9.0, x64)
Memory used 351,858k (± 0.01%) 353,531k (± 0.02%) +1,673k (+ 0.48%) 353,436k 353,672k
Parse Time 2.09s (± 0.42%) 2.12s (± 0.32%) +0.02s (+ 1.10%) 2.10s 2.13s
Bind Time 0.93s (± 1.09%) 0.94s (± 0.71%) +0.02s (+ 1.84%) 0.93s 0.96s
Check Time 5.45s (± 0.42%) 5.47s (± 0.61%) +0.02s (+ 0.28%) 5.42s 5.56s
Emit Time 6.20s (± 0.45%) 6.38s (± 0.67%) +0.19s (+ 3.05%) 6.26s 6.50s
Total Time 14.67s (± 0.33%) 14.91s (± 0.30%) +0.24s (+ 1.66%) 14.85s 15.06s
Monaco - node (v8.9.0, x64)
Memory used 362,969k (± 0.01%) 363,038k (± 0.01%) +70k (+ 0.02%) 362,930k 363,122k
Parse Time 1.56s (± 0.43%) 1.57s (± 0.43%) +0.01s (+ 0.64%) 1.56s 1.59s
Bind Time 0.95s (± 0.61%) 0.96s (± 0.85%) +0.01s (+ 1.06%) 0.94s 0.97s
Check Time 5.43s (± 1.60%) 5.40s (± 1.50%) -0.04s (- 0.66%) 5.25s 5.63s
Emit Time 3.26s (± 4.78%) 3.54s (± 3.11%) +0.28s (+ 8.63%) 3.25s 3.67s
Total Time 11.19s (± 0.69%) 11.46s (± 0.40%) +0.27s (+ 2.41%) 11.33s 11.56s
TFS - node (v8.9.0, x64)
Memory used 323,469k (± 0.01%) 323,540k (± 0.01%) +71k (+ 0.02%) 323,455k 323,661k
Parse Time 1.26s (± 0.24%) 1.26s (± 0.39%) +0.00s (+ 0.24%) 1.26s 1.28s
Bind Time 0.76s (± 0.63%) 0.76s (± 0.79%) -0.00s (- 0.13%) 0.75s 0.77s
Check Time 4.84s (± 0.51%) 4.83s (± 0.56%) -0.01s (- 0.27%) 4.77s 4.88s
Emit Time 3.20s (± 0.77%) 3.55s (± 0.99%) +0.35s (+10.90%) 3.49s 3.66s
Total Time 10.06s (± 0.38%) 10.40s (± 0.55%) +0.34s (+ 3.40%) 10.29s 10.56s
Angular - node (v8.9.0, x86)
Memory used 200,066k (± 0.04%) 200,964k (± 0.02%) +897k (+ 0.45%) 200,884k 201,082k
Parse Time 2.04s (± 0.98%) 2.06s (± 0.37%) +0.02s (+ 0.83%) 2.04s 2.07s
Bind Time 1.05s (± 0.90%) 1.05s (± 0.56%) +0.01s (+ 0.67%) 1.04s 1.07s
Check Time 4.97s (± 0.59%) 4.95s (± 0.50%) -0.02s (- 0.44%) 4.88s 5.01s
Emit Time 6.13s (± 2.06%) 6.39s (± 1.84%) +0.26s (+ 4.29%) 6.15s 6.57s
Total Time 14.18s (± 1.01%) 14.45s (± 0.80%) +0.26s (+ 1.86%) 14.17s 14.64s
Monaco - node (v8.9.0, x86)
Memory used 203,771k (± 0.02%) 203,797k (± 0.02%) +26k (+ 0.01%) 203,731k 203,874k
Parse Time 1.60s (± 0.67%) 1.60s (± 0.71%) +0.00s (+ 0.06%) 1.59s 1.64s
Bind Time 0.77s (± 1.09%) 0.77s (± 0.72%) +0.00s (+ 0.13%) 0.76s 0.78s
Check Time 5.17s (± 1.67%) 5.20s (± 1.80%) +0.03s (+ 0.52%) 5.09s 5.48s
Emit Time 3.12s (± 2.63%) 3.35s (± 2.40%) +0.22s (+ 7.14%) 3.10s 3.45s
Total Time 10.67s (± 0.36%) 10.92s (± 0.40%) +0.25s (+ 2.36%) 10.85s 11.04s
TFS - node (v8.9.0, x86)
Memory used 182,630k (± 0.02%) 182,671k (± 0.02%) +41k (+ 0.02%) 182,564k 182,741k
Parse Time 1.30s (± 0.98%) 1.30s (± 1.11%) -0.00s (- 0.15%) 1.28s 1.35s
Bind Time 0.71s (± 1.51%) 0.71s (± 0.84%) +0.00s (+ 0.56%) 0.70s 0.73s
Check Time 4.60s (± 0.56%) 4.60s (± 0.50%) 0.00s ( 0.00%) 4.56s 4.67s
Emit Time 2.95s (± 1.07%) 3.27s (± 0.68%) +0.31s (+10.66%) 3.20s 3.30s
Total Time 9.57s (± 0.53%) 9.88s (± 0.33%) +0.31s (+ 3.28%) 9.79s 9.95s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory4 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 7, 2020

Copy link
Copy Markdown
Member Author

Ouch
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Do a bit less work when preserveNewlines is off
6ff9c2b
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this please and thank you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 6ff9c2b. You can monitor the build here. It should now contribute to this PR's status checks.
andrewbranch reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 6ff9c2b. You can monitor the build here. It should now contribute to this PR's status checks.
andrewbranch reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this or else
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 6ff9c2b. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 359,154k (± 0.02%) 358,557k (± 0.02%) -597k (- 0.17%) 358,392k 358,742k
Parse Time 1.63s (± 0.43%) 1.63s (± 0.42%) +0.00s (+ 0.18%) 1.61s 1.64s
Bind Time 0.88s (± 0.88%) 0.89s (± 1.14%) +0.01s (+ 0.57%) 0.87s 0.91s
Check Time 4.65s (± 0.35%) 4.67s (± 0.61%) +0.02s (+ 0.39%) 4.59s 4.72s
Emit Time 5.22s (± 0.74%) 5.29s (± 0.83%) +0.06s (+ 1.17%) 5.21s 5.36s
Total Time 12.39s (± 0.40%) 12.47s (± 0.38%) +0.08s (+ 0.66%) 12.35s 12.57s
Monaco - node (v10.16.3, x64)
Memory used 364,684k (± 0.01%) 364,715k (± 0.01%) +31k (+ 0.01%) 364,591k 364,818k
Parse Time 1.27s (± 0.74%) 1.26s (± 0.65%) -0.00s (- 0.32%) 1.25s 1.28s
Bind Time 0.78s (± 0.61%) 0.78s (± 0.29%) +0.00s (+ 0.26%) 0.77s 0.78s
Check Time 4.68s (± 0.36%) 4.70s (± 0.37%) +0.02s (+ 0.43%) 4.67s 4.74s
Emit Time 2.92s (± 0.41%) 2.99s (± 0.43%) +0.08s (+ 2.71%) 2.96s 3.02s
Total Time 9.64s (± 0.32%) 9.74s (± 0.31%) +0.10s (+ 1.01%) 9.68s 9.79s
TFS - node (v10.16.3, x64)
Memory used 324,130k (± 0.02%) 324,184k (± 0.02%) +54k (+ 0.02%) 324,051k 324,368k
Parse Time 0.95s (± 0.62%) 0.95s (± 0.61%) -0.00s (- 0.10%) 0.94s 0.96s
Bind Time 0.75s (± 1.06%) 0.74s (± 1.85%) -0.01s (- 1.20%) 0.71s 0.77s
Check Time 4.22s (± 0.64%) 4.24s (± 0.40%) +0.02s (+ 0.50%) 4.20s 4.27s
Emit Time 3.02s (± 0.68%) 3.15s (± 0.68%) +0.13s (+ 4.13%) 3.10s 3.19s
Total Time 8.95s (± 0.45%) 9.09s (± 0.35%) +0.14s (+ 1.54%) 9.04s 9.18s
Angular - node (v12.1.0, x64)
Memory used 334,793k (± 0.07%) 334,255k (± 0.06%) -539k (- 0.16%) 333,477k 334,492k
Parse Time 1.58s (± 0.37%) 1.58s (± 0.52%) +0.01s (+ 0.44%) 1.56s 1.60s
Bind Time 0.87s (± 0.92%) 0.88s (± 0.78%) +0.00s (+ 0.34%) 0.86s 0.89s
Check Time 4.59s (± 0.57%) 4.62s (± 1.00%) +0.02s (+ 0.54%) 4.52s 4.76s
Emit Time 5.42s (± 0.78%) 5.50s (± 0.89%) +0.08s (+ 1.57%) 5.43s 5.66s
Total Time 12.46s (± 0.52%) 12.58s (± 0.73%) +0.12s (+ 0.94%) 12.40s 12.89s
Monaco - node (v12.1.0, x64)
Memory used 344,541k (± 0.02%) 344,558k (± 0.02%) +17k (+ 0.01%) 344,437k 344,723k
Parse Time 1.22s (± 0.65%) 1.23s (± 0.76%) +0.01s (+ 0.65%) 1.21s 1.25s
Bind Time 0.75s (± 0.82%) 0.75s (± 0.94%) -0.00s (- 0.27%) 0.74s 0.77s
Check Time 4.54s (± 0.45%) 4.56s (± 0.44%) +0.03s (+ 0.57%) 4.53s 4.61s
Emit Time 2.96s (± 0.91%) 3.08s (± 0.96%) +0.13s (+ 4.26%) 3.03s 3.17s
Total Time 9.47s (± 0.30%) 9.63s (± 0.48%) +0.16s (+ 1.66%) 9.53s 9.76s
TFS - node (v12.1.0, x64)
Memory used 306,462k (± 0.02%) 306,440k (± 0.02%) -23k (- 0.01%) 306,329k 306,530k
Parse Time 0.94s (± 0.83%) 0.95s (± 0.50%) +0.01s (+ 0.85%) 0.94s 0.96s
Bind Time 0.71s (± 0.81%) 0.70s (± 0.52%) -0.01s (- 0.85%) 0.70s 0.71s
Check Time 4.17s (± 0.63%) 4.20s (± 0.45%) +0.02s (+ 0.60%) 4.16s 4.23s
Emit Time 3.09s (± 0.92%) 3.23s (± 0.91%) +0.14s (+ 4.40%) 3.17s 3.30s
Total Time 8.92s (± 0.48%) 9.08s (± 0.43%) +0.16s (+ 1.83%) 9.00s 9.20s
Angular - node (v8.9.0, x64)
Memory used 354,002k (± 0.01%) 353,559k (± 0.02%) -443k (- 0.13%) 353,449k 353,678k
Parse Time 2.13s (± 0.41%) 2.12s (± 0.67%) -0.01s (- 0.42%) 2.10s 2.16s
Bind Time 0.93s (± 0.82%) 0.94s (± 0.61%) +0.01s (+ 1.62%) 0.93s 0.95s
Check Time 5.43s (± 0.45%) 5.49s (± 0.52%) +0.06s (+ 1.07%) 5.44s 5.55s
Emit Time 6.21s (± 0.52%) 6.33s (± 0.58%) +0.12s (+ 1.93%) 6.25s 6.43s
Total Time 14.69s (± 0.23%) 14.87s (± 0.41%) +0.18s (+ 1.23%) 14.76s 15.07s
Monaco - node (v8.9.0, x64)
Memory used 362,948k (± 0.01%) 363,003k (± 0.02%) +56k (+ 0.02%) 362,897k 363,148k
Parse Time 1.57s (± 0.33%) 1.57s (± 0.68%) -0.00s (- 0.13%) 1.55s 1.60s
Bind Time 0.96s (± 0.93%) 0.95s (± 0.50%) -0.00s (- 0.31%) 0.94s 0.96s
Check Time 5.37s (± 1.33%) 5.47s (± 1.51%) +0.10s (+ 1.79%) 5.26s 5.65s
Emit Time 3.33s (± 3.73%) 3.25s (± 4.39%) -0.08s (- 2.52%) 3.06s 3.54s
Total Time 11.23s (± 0.65%) 11.24s (± 0.80%) +0.01s (+ 0.05%) 11.08s 11.41s
TFS - node (v8.9.0, x64)
Memory used 323,462k (± 0.02%) 323,555k (± 0.01%) +93k (+ 0.03%) 323,474k 323,634k
Parse Time 1.27s (± 0.38%) 1.27s (± 0.44%) +0.00s (+ 0.08%) 1.26s 1.28s
Bind Time 0.76s (± 0.45%) 0.76s (± 0.85%) +0.00s (+ 0.13%) 0.74s 0.77s
Check Time 4.83s (± 0.69%) 4.83s (± 0.65%) -0.00s (- 0.06%) 4.77s 4.92s
Emit Time 3.20s (± 0.71%) 3.28s (± 0.60%) +0.09s (+ 2.78%) 3.22s 3.32s
Total Time 10.05s (± 0.36%) 10.14s (± 0.48%) +0.09s (+ 0.86%) 10.03s 10.24s
Angular - node (v8.9.0, x86)
Memory used 201,227k (± 0.02%) 200,980k (± 0.03%) -247k (- 0.12%) 200,897k 201,164k
Parse Time 2.05s (± 0.63%) 2.06s (± 0.83%) +0.02s (+ 0.73%) 2.02s 2.10s
Bind Time 1.05s (± 0.35%) 1.06s (± 0.54%) +0.01s (+ 0.57%) 1.05s 1.07s
Check Time 4.97s (± 0.37%) 4.95s (± 0.48%) -0.02s (- 0.36%) 4.90s 5.01s
Emit Time 6.17s (± 1.93%) 6.24s (± 2.31%) +0.07s (+ 1.07%) 6.02s 6.48s
Total Time 14.24s (± 0.92%) 14.31s (± 1.00%) +0.07s (+ 0.46%) 14.10s 14.63s
Monaco - node (v8.9.0, x86)
Memory used 203,795k (± 0.01%) 203,813k (± 0.02%) +18k (+ 0.01%) 203,730k 203,905k
Parse Time 1.61s (± 0.74%) 1.61s (± 0.65%) 0.00s ( 0.00%) 1.59s 1.64s
Bind Time 0.78s (± 1.30%) 0.77s (± 0.52%) -0.01s (- 0.64%) 0.76s 0.78s
Check Time 5.15s (± 1.08%) 5.13s (± 0.56%) -0.01s (- 0.27%) 5.07s 5.19s
Emit Time 3.21s (± 1.62%) 3.28s (± 0.43%) +0.08s (+ 2.37%) 3.26s 3.32s
Total Time 10.74s (± 0.43%) 10.80s (± 0.37%) +0.06s (+ 0.57%) 10.73s 10.90s
TFS - node (v8.9.0, x86)
Memory used 182,639k (± 0.02%) 182,667k (± 0.01%) +29k (+ 0.02%) 182,620k 182,725k
Parse Time 1.31s (± 0.89%) 1.31s (± 0.69%) 0.00s ( 0.00%) 1.29s 1.32s
Bind Time 0.71s (± 0.94%) 0.72s (± 1.11%) +0.01s (+ 0.70%) 0.70s 0.74s
Check Time 4.60s (± 0.50%) 4.60s (± 0.75%) +0.01s (+ 0.13%) 4.50s 4.66s
Emit Time 2.98s (± 0.56%) 3.10s (± 1.36%) +0.12s (+ 3.96%) 3.04s 3.24s
Total Time 9.60s (± 0.34%) 9.72s (± 0.51%) +0.12s (+ 1.25%) 9.63s 9.87s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Fix accidental find/replace rename
c91efd4
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ron Buckton (@rbuckton) this is still in-progress, but would you mind taking a look and seeing if anything jumps out at you perf-wise? For a tsc run, the emitter should be doing almost exactly the same work as before, because preserveNewlines will always be false. The only computational differences should be trivial equality/truthiness checks and arithmetic, so I’m wondering if something I changed is triggering a deopt. The latest results show emit time up 1–4%.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Restore some monomorphism
e3ef427
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 19, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this again please
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at e3ef427. You can monitor the build here. It should now contribute to this PR's status checks.
andrewbranch reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Fix single line writer
e535e27
@andrewbranch

Andrew Branch (andrewbranch) commented Feb 19, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at e535e27. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Fix other writers
21b0cb8
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 334,099k (± 0.02%) 333,427k (± 0.04%) -673k (- 0.20%) 332,974k 333,606k
Parse Time 1.63s (± 0.62%) 1.61s (± 0.68%) -0.02s (- 1.11%) 1.59s 1.63s
Bind Time 0.89s (± 1.17%) 0.88s (± 0.56%) -0.00s (- 0.45%) 0.87s 0.89s
Check Time 4.69s (± 0.50%) 4.66s (± 0.49%) -0.02s (- 0.53%) 4.61s 4.71s
Emit Time 5.23s (± 0.71%) 5.26s (± 0.68%) +0.03s (+ 0.61%) 5.18s 5.34s
Total Time 12.43s (± 0.35%) 12.42s (± 0.33%) -0.02s (- 0.14%) 12.32s 12.50s
Monaco - node (v10.16.3, x64)
Memory used 335,194k (± 0.02%) 335,180k (± 0.02%) -14k (- 0.00%) 335,010k 335,313k
Parse Time 1.25s (± 0.42%) 1.25s (± 0.61%) -0.01s (- 0.48%) 1.23s 1.27s
Bind Time 0.77s (± 0.52%) 0.77s (± 0.58%) +0.00s (+ 0.13%) 0.76s 0.78s
Check Time 4.67s (± 0.30%) 4.67s (± 0.39%) +0.00s (+ 0.02%) 4.64s 4.72s
Emit Time 2.91s (± 0.90%) 2.99s (± 0.76%) +0.08s (+ 2.64%) 2.94s 3.06s
Total Time 9.60s (± 0.42%) 9.68s (± 0.39%) +0.07s (+ 0.76%) 9.59s 9.77s
TFS - node (v10.16.3, x64)
Memory used 299,331k (± 0.02%) 299,314k (± 0.01%) -18k (- 0.01%) 299,258k 299,398k
Parse Time 0.94s (± 0.80%) 0.93s (± 0.60%) -0.01s (- 1.27%) 0.92s 0.94s
Bind Time 0.74s (± 0.46%) 0.74s (± 0.80%) +0.00s (+ 0.13%) 0.73s 0.75s
Check Time 4.25s (± 0.44%) 4.25s (± 0.56%) -0.00s (- 0.09%) 4.21s 4.30s
Emit Time 3.02s (± 0.85%) 3.13s (± 0.39%) +0.11s (+ 3.74%) 3.10s 3.16s
Total Time 8.96s (± 0.35%) 9.06s (± 0.32%) +0.09s (+ 1.05%) 9.00s 9.13s
Angular - node (v12.1.0, x64)
Memory used 309,747k (± 0.03%) 309,250k (± 0.02%) -497k (- 0.16%) 309,126k 309,396k
Parse Time 1.58s (± 0.51%) 1.56s (± 0.36%) -0.02s (- 1.39%) 1.55s 1.57s
Bind Time 0.87s (± 1.25%) 0.87s (± 0.87%) -0.01s (- 0.69%) 0.85s 0.89s
Check Time 4.61s (± 0.61%) 4.58s (± 0.51%) -0.03s (- 0.74%) 4.53s 4.64s
Emit Time 5.40s (± 0.97%) 5.42s (± 0.38%) +0.03s (+ 0.52%) 5.39s 5.49s
Total Time 12.46s (± 0.59%) 12.42s (± 0.32%) -0.04s (- 0.29%) 12.35s 12.52s
Monaco - node (v12.1.0, x64)
Memory used 315,016k (± 0.02%) 315,061k (± 0.01%) +45k (+ 0.01%) 314,914k 315,150k
Parse Time 1.20s (± 0.65%) 1.20s (± 0.65%) 0.00s ( 0.00%) 1.19s 1.22s
Bind Time 0.74s (± 0.83%) 0.74s (± 1.19%) -0.00s (- 0.13%) 0.73s 0.77s
Check Time 4.53s (± 0.35%) 4.52s (± 0.43%) -0.01s (- 0.15%) 4.48s 4.57s
Emit Time 2.93s (± 0.72%) 3.05s (± 0.79%) +0.11s (+ 3.89%) 3.01s 3.12s
Total Time 9.40s (± 0.37%) 9.51s (± 0.45%) +0.11s (+ 1.12%) 9.44s 9.63s
TFS - node (v12.1.0, x64)
Memory used 281,619k (± 0.01%) 281,675k (± 0.02%) +56k (+ 0.02%) 281,543k 281,779k
Parse Time 0.93s (± 0.87%) 0.92s (± 0.90%) -0.01s (- 0.65%) 0.90s 0.94s
Bind Time 0.71s (± 0.87%) 0.71s (± 0.91%) -0.00s (- 0.42%) 0.70s 0.73s
Check Time 4.20s (± 0.37%) 4.18s (± 0.40%) -0.01s (- 0.33%) 4.14s 4.22s
Emit Time 3.04s (± 0.96%) 3.21s (± 0.40%) +0.17s (+ 5.42%) 3.19s 3.24s
Total Time 8.88s (± 0.37%) 9.02s (± 0.29%) +0.14s (+ 1.62%) 8.97s 9.07s
Angular - node (v8.9.0, x64)
Memory used 328,903k (± 0.01%) 328,483k (± 0.02%) -420k (- 0.13%) 328,317k 328,602k
Parse Time 2.10s (± 0.73%) 2.10s (± 0.44%) -0.00s (- 0.14%) 2.08s 2.12s
Bind Time 0.91s (± 0.52%) 0.92s (± 1.13%) +0.00s (+ 0.55%) 0.90s 0.94s
Check Time 5.46s (± 0.51%) 5.46s (± 0.39%) -0.00s (- 0.02%) 5.42s 5.51s
Emit Time 6.19s (± 0.47%) 6.29s (± 0.55%) +0.10s (+ 1.65%) 6.20s 6.38s
Total Time 14.65s (± 0.33%) 14.76s (± 0.33%) +0.10s (+ 0.71%) 14.66s 14.88s
Monaco - node (v8.9.0, x64)
Memory used 333,387k (± 0.01%) 333,450k (± 0.02%) +63k (+ 0.02%) 333,324k 333,713k
Parse Time 1.53s (± 0.31%) 1.53s (± 0.22%) -0.00s (- 0.20%) 1.52s 1.54s
Bind Time 0.90s (± 0.58%) 0.89s (± 0.55%) -0.01s (- 0.56%) 0.88s 0.90s
Check Time 5.38s (± 0.53%) 5.37s (± 0.62%) -0.01s (- 0.24%) 5.32s 5.49s
Emit Time 3.52s (± 0.54%) 3.61s (± 0.45%) +0.09s (+ 2.44%) 3.57s 3.64s
Total Time 11.34s (± 0.34%) 11.40s (± 0.35%) +0.06s (+ 0.53%) 11.35s 11.55s
TFS - node (v8.9.0, x64)
Memory used 298,669k (± 0.01%) 298,706k (± 0.02%) +37k (+ 0.01%) 298,568k 298,817k
Parse Time 1.25s (± 0.30%) 1.25s (± 0.24%) +0.01s (+ 0.56%) 1.25s 1.26s
Bind Time 0.75s (± 0.79%) 0.75s (± 0.82%) -0.01s (- 0.79%) 0.74s 0.76s
Check Time 4.81s (± 0.51%) 4.79s (± 0.70%) -0.02s (- 0.40%) 4.73s 4.87s
Emit Time 3.38s (± 0.51%) 3.45s (± 1.87%) +0.07s (+ 2.10%) 3.23s 3.56s
Total Time 10.19s (± 0.29%) 10.24s (± 0.87%) +0.06s (+ 0.55%) 10.00s 10.43s
Angular - node (v8.9.0, x86)
Memory used 188,687k (± 0.02%) 188,458k (± 0.03%) -229k (- 0.12%) 188,374k 188,627k
Parse Time 2.06s (± 0.84%) 2.04s (± 0.56%) -0.01s (- 0.68%) 2.02s 2.07s
Bind Time 1.07s (± 0.61%) 1.07s (± 0.65%) +0.00s (+ 0.28%) 1.05s 1.08s
Check Time 4.99s (± 0.73%) 4.98s (± 0.49%) -0.00s (- 0.08%) 4.93s 5.04s
Emit Time 6.10s (± 0.73%) 6.16s (± 0.55%) +0.06s (+ 0.95%) 6.10s 6.23s
Total Time 14.22s (± 0.49%) 14.26s (± 0.45%) +0.04s (+ 0.27%) 14.13s 14.39s
Monaco - node (v8.9.0, x86)
Memory used 189,038k (± 0.02%) 189,105k (± 0.02%) +68k (+ 0.04%) 189,035k 189,151k
Parse Time 1.58s (± 0.37%) 1.57s (± 0.57%) -0.00s (- 0.13%) 1.56s 1.59s
Bind Time 0.77s (± 0.78%) 0.76s (± 0.49%) -0.00s (- 0.13%) 0.76s 0.77s
Check Time 5.35s (± 1.51%) 5.26s (± 1.43%) -0.09s (- 1.70%) 5.13s 5.37s
Emit Time 2.96s (± 3.74%) 3.13s (± 3.64%) +0.17s (+ 5.81%) 2.94s 3.35s
Total Time 10.66s (± 0.57%) 10.73s (± 0.59%) +0.07s (+ 0.69%) 10.64s 10.94s
TFS - node (v8.9.0, x86)
Memory used 170,254k (± 0.03%) 170,291k (± 0.01%) +37k (+ 0.02%) 170,240k 170,358k
Parse Time 1.28s (± 0.66%) 1.28s (± 0.99%) -0.00s (- 0.16%) 1.26s 1.31s
Bind Time 0.71s (± 0.52%) 0.71s (± 1.12%) -0.00s (- 0.42%) 0.70s 0.74s
Check Time 4.58s (± 0.58%) 4.59s (± 0.55%) +0.01s (+ 0.17%) 4.52s 4.63s
Emit Time 2.97s (± 0.79%) 3.07s (± 0.94%) +0.10s (+ 3.47%) 3.02s 3.15s
Total Time 9.54s (± 0.39%) 9.65s (± 0.39%) +0.10s (+ 1.08%) 9.59s 9.75s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Merge branch 'master' into bug/27294
b6cf73d
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Mar 2, 2020
fix(36102): fix extra new line in Organize Imports #36911
Merged
@sandersn Nathan Shively-Sanders (sandersn) unassigned Ron Buckton (rbuckton) Mar 11, 2020
Andrew Branch (andrewbranch) added 3 commits March 13, 2020 15:23
@andrewbranch
Fix trailing line terminator count bug for function parameters
563d223
@andrewbranch
Preserve newlines around parenthesized expressions
8b61d66
@andrewbranch
Merge branch 'master' into bug/27294
e7c2b28
@andrewbranch

Andrew Branch (andrewbranch) commented Mar 14, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at e7c2b28. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 327,656k (± 0.03%) 327,140k (± 0.03%) -517k (- 0.16%) 326,801k 327,283k
Parse Time 1.63s (± 0.48%) 1.62s (± 0.66%) -0.01s (- 0.74%) 1.60s 1.64s
Bind Time 0.90s (± 0.58%) 0.89s (± 0.84%) -0.01s (- 0.67%) 0.88s 0.91s
Check Time 4.74s (± 0.29%) 4.72s (± 0.48%) -0.02s (- 0.49%) 4.67s 4.76s
Emit Time 5.30s (± 0.57%) 5.33s (± 0.39%) +0.03s (+ 0.51%) 5.28s 5.37s
Total Time 12.57s (± 0.36%) 12.56s (± 0.31%) -0.01s (- 0.12%) 12.47s 12.66s
Monaco - node (v10.16.3, x64)
Memory used 327,011k (± 0.01%) 327,061k (± 0.03%) +51k (+ 0.02%) 326,826k 327,192k
Parse Time 1.25s (± 0.42%) 1.26s (± 0.48%) +0.00s (+ 0.32%) 1.24s 1.27s
Bind Time 0.77s (± 0.48%) 0.78s (± 0.47%) +0.00s (+ 0.13%) 0.77s 0.78s
Check Time 4.74s (± 0.52%) 4.75s (± 0.41%) +0.01s (+ 0.23%) 4.72s 4.82s
Emit Time 2.90s (± 0.70%) 2.95s (± 0.84%) +0.05s (+ 1.90%) 2.91s 3.02s
Total Time 9.66s (± 0.29%) 9.73s (± 0.34%) +0.07s (+ 0.72%) 9.67s 9.82s
TFS - node (v10.16.3, x64)
Memory used 291,882k (± 0.02%) 291,956k (± 0.02%) +74k (+ 0.03%) 291,856k 292,075k
Parse Time 0.94s (± 0.39%) 0.95s (± 0.76%) +0.01s (+ 0.74%) 0.94s 0.97s
Bind Time 0.75s (± 0.49%) 0.75s (± 0.74%) +0.00s (+ 0.27%) 0.74s 0.76s
Check Time 4.28s (± 0.61%) 4.29s (± 0.67%) +0.01s (+ 0.19%) 4.24s 4.38s
Emit Time 3.06s (± 0.81%) 3.08s (± 0.59%) +0.03s (+ 0.92%) 3.06s 3.14s
Total Time 9.03s (± 0.44%) 9.07s (± 0.56%) +0.04s (+ 0.49%) 9.01s 9.25s
material-ui - node (v10.16.3, x64)
Memory used 453,300k (± 0.01%) 453,025k (± 0.01%) -275k (- 0.06%) 452,943k 453,107k
Parse Time 1.78s (± 0.45%) 1.77s (± 0.52%) -0.01s (- 0.56%) 1.75s 1.79s
Bind Time 0.68s (± 1.00%) 0.68s (± 1.30%) -0.01s (- 1.02%) 0.66s 0.70s
Check Time 13.63s (± 0.82%) 13.65s (± 1.06%) +0.02s (+ 0.12%) 13.44s 13.99s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.10s (± 0.68%) 16.10s (± 0.97%) 0.00s ( 0.00%) 15.87s 16.47s
Angular - node (v12.1.0, x64)
Memory used 303,378k (± 0.02%) 302,937k (± 0.04%) -441k (- 0.15%) 302,640k 303,307k
Parse Time 1.58s (± 0.74%) 1.58s (± 0.56%) -0.00s (- 0.13%) 1.55s 1.59s
Bind Time 0.88s (± 0.68%) 0.87s (± 0.77%) -0.00s (- 0.23%) 0.86s 0.89s
Check Time 4.63s (± 0.42%) 4.63s (± 0.56%) -0.00s (- 0.06%) 4.57s 4.70s
Emit Time 5.46s (± 0.69%) 5.49s (± 0.42%) +0.02s (+ 0.37%) 5.42s 5.52s
Total Time 12.55s (± 0.45%) 12.56s (± 0.34%) +0.01s (+ 0.10%) 12.47s 12.66s
Monaco - node (v12.1.0, x64)
Memory used 307,034k (± 0.03%) 307,019k (± 0.02%) -15k (- 0.01%) 306,911k 307,137k
Parse Time 1.21s (± 0.43%) 1.21s (± 0.64%) +0.00s (+ 0.00%) 1.20s 1.23s
Bind Time 0.75s (± 0.66%) 0.74s (± 1.00%) -0.00s (- 0.40%) 0.73s 0.77s
Check Time 4.55s (± 0.34%) 4.58s (± 0.46%) +0.02s (+ 0.48%) 4.52s 4.62s
Emit Time 2.94s (± 0.55%) 3.00s (± 0.97%) +0.07s (+ 2.32%) 2.94s 3.06s
Total Time 9.44s (± 0.22%) 9.53s (± 0.34%) +0.09s (+ 0.92%) 9.47s 9.61s
TFS - node (v12.1.0, x64)
Memory used 274,183k (± 0.02%) 274,187k (± 0.02%) +4k (+ 0.00%) 274,087k 274,343k
Parse Time 0.93s (± 0.60%) 0.94s (± 0.92%) +0.01s (+ 1.51%) 0.93s 0.96s
Bind Time 0.70s (± 1.16%) 0.70s (± 0.83%) -0.00s (- 0.00%) 0.69s 0.72s
Check Time 4.18s (± 0.46%) 4.20s (± 0.50%) +0.02s (+ 0.53%) 4.17s 4.24s
Emit Time 3.08s (± 0.70%) 3.14s (± 0.92%) +0.06s (+ 1.95%) 3.09s 3.22s
Total Time 8.89s (± 0.32%) 8.99s (± 0.34%) +0.09s (+ 1.05%) 8.92s 9.04s
material-ui - node (v12.1.0, x64)
Memory used 430,526k (± 0.05%) 430,225k (± 0.07%) -301k (- 0.07%) 429,308k 430,530k
Parse Time 1.75s (± 0.48%) 1.77s (± 0.53%) +0.02s (+ 1.03%) 1.74s 1.78s
Bind Time 0.63s (± 0.95%) 0.64s (± 0.78%) +0.01s (+ 1.44%) 0.63s 0.65s
Check Time 12.13s (± 0.75%) 12.19s (± 0.99%) +0.05s (+ 0.44%) 12.02s 12.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.51s (± 0.58%) 14.59s (± 0.81%) +0.08s (+ 0.58%) 14.42s 14.92s
Angular - node (v8.9.0, x64)
Memory used 322,622k (± 0.01%) 322,233k (± 0.02%) -389k (- 0.12%) 322,131k 322,445k
Parse Time 2.12s (± 0.39%) 2.11s (± 0.31%) -0.01s (- 0.43%) 2.09s 2.12s
Bind Time 0.92s (± 0.72%) 0.92s (± 0.44%) -0.00s (- 0.11%) 0.91s 0.93s
Check Time 5.40s (± 1.50%) 5.46s (± 0.56%) +0.06s (+ 1.19%) 5.41s 5.54s
Emit Time 6.18s (± 1.80%) 6.31s (± 0.86%) +0.13s (+ 2.15%) 6.19s 6.43s
Total Time 14.62s (± 0.44%) 14.80s (± 0.44%) +0.18s (+ 1.27%) 14.68s 14.91s
Monaco - node (v8.9.0, x64)
Memory used 325,342k (± 0.01%) 325,408k (± 0.01%) +66k (+ 0.02%) 325,322k 325,456k
Parse Time 1.54s (± 0.36%) 1.54s (± 0.70%) +0.00s (+ 0.07%) 1.52s 1.57s
Bind Time 0.89s (± 0.85%) 0.90s (± 0.92%) +0.00s (+ 0.22%) 0.88s 0.92s
Check Time 5.37s (± 0.52%) 5.40s (± 0.70%) +0.02s (+ 0.41%) 5.31s 5.47s
Emit Time 3.47s (± 0.51%) 3.58s (± 0.48%) +0.10s (+ 2.97%) 3.53s 3.60s
Total Time 11.28s (± 0.36%) 11.41s (± 0.29%) +0.13s (+ 1.15%) 11.31s 11.46s
TFS - node (v8.9.0, x64)
Memory used 291,244k (± 0.01%) 291,316k (± 0.01%) +72k (+ 0.02%) 291,244k 291,365k
Parse Time 1.25s (± 0.46%) 1.25s (± 0.56%) +0.00s (+ 0.08%) 1.24s 1.27s
Bind Time 0.75s (± 0.89%) 0.75s (± 1.13%) +0.00s (+ 0.27%) 0.73s 0.76s
Check Time 4.90s (± 1.38%) 4.90s (± 1.45%) -0.00s (- 0.04%) 4.78s 5.07s
Emit Time 3.26s (± 2.17%) 3.36s (± 1.90%) +0.10s (+ 3.06%) 3.19s 3.48s
Total Time 10.17s (± 0.52%) 10.26s (± 0.41%) +0.10s (+ 0.96%) 10.19s 10.38s
material-ui - node (v8.9.0, x64)
Memory used 455,724k (± 0.01%) 455,532k (± 0.02%) -191k (- 0.04%) 455,351k 455,719k
Parse Time 2.11s (± 0.70%) 2.10s (± 0.57%) -0.00s (- 0.14%) 2.08s 2.13s
Bind Time 0.82s (± 0.84%) 0.81s (± 0.99%) -0.01s (- 0.86%) 0.79s 0.83s
Check Time 17.62s (± 0.59%) 17.67s (± 1.08%) +0.05s (+ 0.31%) 17.24s 18.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.54s (± 0.49%) 20.58s (± 0.92%) +0.04s (+ 0.20%) 20.17s 21.05s
Angular - node (v8.9.0, x86)
Memory used 185,548k (± 0.02%) 185,389k (± 0.03%) -159k (- 0.09%) 185,235k 185,544k
Parse Time 2.05s (± 0.71%) 2.05s (± 0.52%) -0.00s (- 0.10%) 2.02s 2.07s
Bind Time 1.07s (± 0.56%) 1.07s (± 0.58%) +0.00s (+ 0.38%) 1.06s 1.09s
Check Time 4.98s (± 0.44%) 4.99s (± 0.30%) +0.01s (+ 0.12%) 4.96s 5.03s
Emit Time 6.01s (± 0.66%) 6.12s (± 0.99%) +0.11s (+ 1.85%) 6.01s 6.31s
Total Time 14.11s (± 0.41%) 14.23s (± 0.50%) +0.12s (+ 0.87%) 14.08s 14.41s
Monaco - node (v8.9.0, x86)
Memory used 185,127k (± 0.02%) 185,192k (± 0.01%) +65k (+ 0.04%) 185,144k 185,231k
Parse Time 1.58s (± 0.64%) 1.59s (± 0.78%) +0.01s (+ 0.38%) 1.57s 1.63s
Bind Time 0.77s (± 0.89%) 0.77s (± 0.97%) +0.01s (+ 0.91%) 0.76s 0.79s
Check Time 5.41s (± 0.65%) 5.42s (± 0.52%) +0.01s (+ 0.13%) 5.35s 5.47s
Emit Time 2.87s (± 0.75%) 2.94s (± 0.58%) +0.07s (+ 2.61%) 2.90s 2.99s
Total Time 10.63s (± 0.54%) 10.73s (± 0.35%) +0.09s (+ 0.86%) 10.62s 10.81s
TFS - node (v8.9.0, x86)
Memory used 166,639k (± 0.03%) 166,699k (± 0.02%) +60k (+ 0.04%) 166,639k 166,812k
Parse Time 1.29s (± 0.87%) 1.29s (± 0.83%) +0.00s (+ 0.16%) 1.28s 1.33s
Bind Time 0.72s (± 1.52%) 0.72s (± 1.22%) +0.00s (+ 0.28%) 0.71s 0.74s
Check Time 4.62s (± 0.72%) 4.65s (± 0.71%) +0.03s (+ 0.61%) 4.59s 4.72s
Emit Time 2.98s (± 2.23%) 3.04s (± 1.08%) +0.06s (+ 1.88%) 2.95s 3.11s
Total Time 9.61s (± 0.76%) 9.70s (± 0.69%) +0.09s (+ 0.92%) 9.56s 9.85s
material-ui - node (v8.9.0, x86)
Memory used 257,782k (± 0.01%) 257,669k (± 0.02%) -113k (- 0.04%) 257,597k 257,764k
Parse Time 2.18s (± 0.89%) 2.18s (± 0.91%) +0.00s (+ 0.09%) 2.15s 2.24s
Bind Time 0.68s (± 1.09%) 0.68s (± 0.95%) -0.00s (- 0.73%) 0.67s 0.70s
Check Time 16.18s (± 0.41%) 16.13s (± 0.46%) -0.06s (- 0.34%) 15.94s 16.33s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.04s (± 0.34%) 18.98s (± 0.43%) -0.06s (- 0.30%) 18.81s 19.25s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Back to speculative microoptimizations, yay
e99d833
@andrewbranch

Andrew Branch (andrewbranch) commented Mar 16, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at e99d833. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 327,734k (± 0.03%) 327,188k (± 0.03%) -546k (- 0.17%) 326,833k 327,383k
Parse Time 1.63s (± 0.66%) 1.62s (± 0.43%) -0.01s (- 0.49%) 1.61s 1.64s
Bind Time 0.89s (± 0.95%) 0.89s (± 0.93%) +0.01s (+ 0.56%) 0.88s 0.92s
Check Time 4.75s (± 0.41%) 4.75s (± 0.58%) -0.00s (- 0.04%) 4.71s 4.84s
Emit Time 5.30s (± 0.40%) 5.31s (± 0.54%) +0.01s (+ 0.17%) 5.26s 5.39s
Total Time 12.57s (± 0.34%) 12.57s (± 0.37%) 0.00s ( 0.00%) 12.49s 12.73s
Monaco - node (v10.16.3, x64)
Memory used 327,012k (± 0.02%) 327,092k (± 0.02%) +80k (+ 0.02%) 326,930k 327,262k
Parse Time 1.25s (± 0.38%) 1.25s (± 0.53%) +0.00s (+ 0.00%) 1.24s 1.27s
Bind Time 0.77s (± 0.44%) 0.77s (± 0.62%) 0.00s ( 0.00%) 0.76s 0.78s
Check Time 4.75s (± 0.63%) 4.75s (± 0.59%) +0.01s (+ 0.17%) 4.71s 4.82s
Emit Time 2.90s (± 0.63%) 2.95s (± 0.80%) +0.05s (+ 1.65%) 2.90s 3.01s
Total Time 9.68s (± 0.38%) 9.73s (± 0.46%) +0.05s (+ 0.57%) 9.64s 9.84s
TFS - node (v10.16.3, x64)
Memory used 291,889k (± 0.01%) 292,027k (± 0.02%) +138k (+ 0.05%) 291,956k 292,135k
Parse Time 0.95s (± 0.65%) 0.95s (± 0.38%) -0.00s (- 0.32%) 0.94s 0.95s
Bind Time 0.75s (± 1.02%) 0.75s (± 0.74%) +0.00s (+ 0.27%) 0.74s 0.76s
Check Time 4.28s (± 0.33%) 4.27s (± 0.53%) -0.00s (- 0.09%) 4.22s 4.33s
Emit Time 3.03s (± 1.00%) 3.08s (± 1.12%) +0.05s (+ 1.72%) 2.99s 3.17s
Total Time 9.00s (± 0.47%) 9.05s (± 0.51%) +0.05s (+ 0.52%) 8.98s 9.20s
material-ui - node (v10.16.3, x64)
Memory used 453,852k (± 0.01%) 453,620k (± 0.01%) -231k (- 0.05%) 453,551k 453,707k
Parse Time 1.77s (± 0.33%) 1.78s (± 0.57%) +0.01s (+ 0.51%) 1.76s 1.81s
Bind Time 0.68s (± 0.44%) 0.68s (± 0.85%) -0.00s (- 0.29%) 0.67s 0.69s
Check Time 13.62s (± 0.80%) 13.73s (± 0.67%) +0.11s (+ 0.82%) 13.53s 13.91s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.07s (± 0.68%) 16.19s (± 0.58%) +0.12s (+ 0.75%) 15.96s 16.37s
Angular - node (v12.1.0, x64)
Memory used 303,415k (± 0.03%) 302,965k (± 0.02%) -450k (- 0.15%) 302,881k 303,073k
Parse Time 1.57s (± 0.51%) 1.58s (± 0.43%) +0.01s (+ 0.51%) 1.56s 1.59s
Bind Time 0.87s (± 1.15%) 0.87s (± 0.94%) -0.00s (- 0.11%) 0.86s 0.90s
Check Time 4.66s (± 0.42%) 4.64s (± 0.58%) -0.02s (- 0.47%) 4.58s 4.69s
Emit Time 5.42s (± 0.61%) 5.48s (± 0.51%) +0.05s (+ 0.98%) 5.43s 5.56s
Total Time 12.53s (± 0.39%) 12.56s (± 0.27%) +0.04s (+ 0.29%) 12.49s 12.66s
Monaco - node (v12.1.0, x64)
Memory used 307,014k (± 0.02%) 307,002k (± 0.02%) -12k (- 0.00%) 306,881k 307,118k
Parse Time 1.22s (± 0.77%) 1.21s (± 0.63%) -0.01s (- 0.90%) 1.19s 1.22s
Bind Time 0.74s (± 1.02%) 0.75s (± 0.60%) +0.00s (+ 0.40%) 0.74s 0.76s
Check Time 4.57s (± 0.30%) 4.56s (± 0.42%) -0.01s (- 0.20%) 4.53s 4.61s
Emit Time 2.95s (± 0.98%) 2.97s (± 0.60%) +0.02s (+ 0.85%) 2.95s 3.04s
Total Time 9.48s (± 0.32%) 9.48s (± 0.38%) +0.01s (+ 0.05%) 9.43s 9.61s
TFS - node (v12.1.0, x64)
Memory used 274,171k (± 0.03%) 274,218k (± 0.02%) +46k (+ 0.02%) 274,130k 274,304k
Parse Time 0.93s (± 0.66%) 0.93s (± 0.51%) -0.00s (- 0.43%) 0.92s 0.94s
Bind Time 0.70s (± 0.71%) 0.70s (± 0.52%) -0.00s (- 0.14%) 0.70s 0.71s
Check Time 4.19s (± 0.53%) 4.18s (± 0.45%) -0.01s (- 0.26%) 4.14s 4.22s
Emit Time 3.08s (± 1.01%) 3.13s (± 0.64%) +0.05s (+ 1.69%) 3.10s 3.18s
Total Time 8.90s (± 0.42%) 8.94s (± 0.29%) +0.04s (+ 0.46%) 8.90s 9.01s
material-ui - node (v12.1.0, x64)
Memory used 431,102k (± 0.05%) 430,766k (± 0.08%) -337k (- 0.08%) 429,831k 431,056k
Parse Time 1.75s (± 0.46%) 1.75s (± 0.80%) +0.00s (+ 0.23%) 1.73s 1.79s
Bind Time 0.63s (± 0.83%) 0.63s (± 0.78%) +0.00s (+ 0.79%) 0.62s 0.64s
Check Time 12.05s (± 0.76%) 12.14s (± 0.88%) +0.09s (+ 0.77%) 11.94s 12.44s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.42s (± 0.69%) 14.53s (± 0.78%) +0.10s (+ 0.72%) 14.33s 14.82s
Angular - node (v8.9.0, x64)
Memory used 322,671k (± 0.02%) 322,213k (± 0.02%) -458k (- 0.14%) 322,068k 322,371k
Parse Time 2.11s (± 0.64%) 2.10s (± 0.53%) -0.01s (- 0.52%) 2.08s 2.13s
Bind Time 0.92s (± 0.36%) 0.91s (± 0.40%) -0.01s (- 0.65%) 0.91s 0.92s
Check Time 5.47s (± 1.00%) 5.47s (± 0.60%) -0.00s (- 0.02%) 5.41s 5.54s
Emit Time 6.19s (± 0.53%) 6.28s (± 0.82%) +0.10s (+ 1.55%) 6.15s 6.42s
Total Time 14.68s (± 0.26%) 14.76s (± 0.39%) +0.08s (+ 0.53%) 14.62s 14.88s
Monaco - node (v8.9.0, x64)
Memory used 325,309k (± 0.02%) 325,351k (± 0.01%) +43k (+ 0.01%) 325,215k 325,434k
Parse Time 1.54s (± 0.49%) 1.54s (± 0.60%) +0.00s (+ 0.07%) 1.52s 1.56s
Bind Time 0.90s (± 1.29%) 0.90s (± 1.07%) -0.00s (- 0.11%) 0.88s 0.93s
Check Time 5.38s (± 0.50%) 5.38s (± 0.36%) -0.01s (- 0.11%) 5.35s 5.43s
Emit Time 3.48s (± 0.53%) 3.60s (± 0.44%) +0.12s (+ 3.36%) 3.56s 3.64s
Total Time 11.29s (± 0.31%) 11.40s (± 0.22%) +0.11s (+ 0.97%) 11.37s 11.48s
TFS - node (v8.9.0, x64)
Memory used 291,247k (± 0.01%) 291,335k (± 0.02%) +88k (+ 0.03%) 291,275k 291,462k
Parse Time 1.25s (± 0.42%) 1.26s (± 0.59%) +0.01s (+ 0.64%) 1.24s 1.27s
Bind Time 0.74s (± 0.66%) 0.74s (± 0.50%) +0.00s (+ 0.13%) 0.74s 0.75s
Check Time 4.85s (± 1.02%) 4.89s (± 1.63%) +0.04s (+ 0.87%) 4.78s 5.10s
Emit Time 3.29s (± 1.00%) 3.37s (± 2.17%) +0.07s (+ 2.25%) 3.19s 3.49s
Total Time 10.14s (± 0.35%) 10.26s (± 0.39%) +0.12s (+ 1.20%) 10.18s 10.32s
material-ui - node (v8.9.0, x64)
Memory used 456,437k (± 0.02%) 456,138k (± 0.01%) -299k (- 0.07%) 456,042k 456,302k
Parse Time 2.11s (± 0.45%) 2.11s (± 0.93%) +0.01s (+ 0.28%) 2.08s 2.16s
Bind Time 0.81s (± 1.04%) 0.81s (± 1.78%) +0.00s (+ 0.49%) 0.79s 0.84s
Check Time 17.67s (± 0.81%) 17.70s (± 0.66%) +0.03s (+ 0.19%) 17.28s 17.89s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.59s (± 0.73%) 20.63s (± 0.59%) +0.04s (+ 0.20%) 20.19s 20.86s
Angular - node (v8.9.0, x86)
Memory used 185,645k (± 0.02%) 185,422k (± 0.02%) -222k (- 0.12%) 185,368k 185,522k
Parse Time 2.04s (± 0.45%) 2.05s (± 0.43%) +0.00s (+ 0.24%) 2.03s 2.07s
Bind Time 1.07s (± 0.34%) 1.08s (± 1.24%) +0.00s (+ 0.19%) 1.05s 1.12s
Check Time 5.02s (± 0.63%) 5.01s (± 0.72%) -0.01s (- 0.24%) 4.94s 5.10s
Emit Time 6.00s (± 0.69%) 6.12s (± 0.96%) +0.11s (+ 1.85%) 5.99s 6.26s
Total Time 14.14s (± 0.41%) 14.25s (± 0.54%) +0.10s (+ 0.74%) 14.07s 14.42s
Monaco - node (v8.9.0, x86)
Memory used 185,156k (± 0.02%) 185,182k (± 0.01%) +25k (+ 0.01%) 185,141k 185,234k
Parse Time 1.59s (± 0.87%) 1.58s (± 0.60%) -0.00s (- 0.19%) 1.57s 1.61s
Bind Time 0.76s (± 0.64%) 0.77s (± 0.87%) +0.00s (+ 0.39%) 0.75s 0.78s
Check Time 5.39s (± 0.43%) 5.42s (± 0.64%) +0.03s (+ 0.63%) 5.35s 5.49s
Emit Time 2.86s (± 0.79%) 2.94s (± 0.85%) +0.07s (+ 2.51%) 2.87s 2.99s
Total Time 10.60s (± 0.34%) 10.70s (± 0.33%) +0.10s (+ 0.93%) 10.64s 10.78s
TFS - node (v8.9.0, x86)
Memory used 166,680k (± 0.02%) 166,718k (± 0.02%) +38k (+ 0.02%) 166,648k 166,806k
Parse Time 1.30s (± 1.54%) 1.28s (± 0.83%) -0.01s (- 0.85%) 1.27s 1.31s
Bind Time 0.71s (± 0.66%) 0.71s (± 0.94%) +0.00s (+ 0.42%) 0.70s 0.73s
Check Time 4.63s (± 0.52%) 4.65s (± 0.45%) +0.02s (+ 0.50%) 4.61s 4.72s
Emit Time 2.98s (± 2.08%) 3.05s (± 0.76%) +0.07s (+ 2.28%) 3.01s 3.12s
Total Time 9.62s (± 0.77%) 9.70s (± 0.30%) +0.08s (+ 0.81%) 9.64s 9.79s
material-ui - node (v8.9.0, x86)
Memory used 258,084k (± 0.01%) 257,967k (± 0.01%) -117k (- 0.05%) 257,884k 258,028k
Parse Time 2.18s (± 0.57%) 2.17s (± 0.55%) -0.01s (- 0.28%) 2.15s 2.20s
Bind Time 0.69s (± 2.07%) 0.68s (± 1.50%) -0.01s (- 0.73%) 0.66s 0.71s
Check Time 16.15s (± 0.45%) 16.18s (± 0.46%) +0.03s (+ 0.19%) 16.02s 16.34s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.01s (± 0.37%) 19.03s (± 0.45%) +0.02s (+ 0.11%) 18.84s 19.23s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andrew Branch (andrewbranch) added 2 commits March 16, 2020 11:51
@andrewbranch
Don’t call getEffectiveLines during tsc emit at all
ac768d0
@andrewbranch
Merge branch 'master' into bug/27294
6daa27e
@andrewbranch

Andrew Branch (andrewbranch) commented Mar 16, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this again please
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 6daa27e. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36688

Metric master 36688 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 327,773k (± 0.03%) 327,109k (± 0.05%) -664k (- 0.20%) 326,644k 327,438k
Parse Time 1.62s (± 0.46%) 1.64s (± 0.57%) +0.02s (+ 0.92%) 1.61s 1.65s
Bind Time 0.89s (± 0.85%) 0.90s (± 0.52%) +0.01s (+ 1.58%) 0.89s 0.91s
Check Time 4.75s (± 0.34%) 4.78s (± 0.82%) +0.03s (+ 0.63%) 4.70s 4.86s
Emit Time 5.30s (± 0.97%) 5.36s (± 1.11%) +0.06s (+ 1.06%) 5.19s 5.45s
Total Time 12.57s (± 0.43%) 12.68s (± 0.68%) +0.11s (+ 0.89%) 12.41s 12.83s
Monaco - node (v10.16.3, x64)
Memory used 326,995k (± 0.02%) 327,061k (± 0.01%) +66k (+ 0.02%) 326,977k 327,168k
Parse Time 1.26s (± 0.61%) 1.27s (± 0.39%) +0.01s (+ 0.88%) 1.26s 1.28s
Bind Time 0.77s (± 0.44%) 0.78s (± 0.67%) +0.01s (+ 0.78%) 0.77s 0.79s
Check Time 4.74s (± 0.24%) 4.77s (± 0.31%) +0.03s (+ 0.74%) 4.74s 4.80s
Emit Time 2.90s (± 1.02%) 2.95s (± 0.74%) +0.05s (+ 1.59%) 2.89s 2.98s
Total Time 9.66s (± 0.32%) 9.76s (± 0.27%) +0.10s (+ 1.05%) 9.70s 9.83s
TFS - node (v10.16.3, x64)
Memory used 291,913k (± 0.02%) 291,925k (± 0.01%) +12k (+ 0.00%) 291,844k 291,990k
Parse Time 0.95s (± 0.55%) 0.95s (± 0.79%) +0.01s (+ 0.53%) 0.93s 0.97s
Bind Time 0.75s (± 0.80%) 0.75s (± 0.93%) +0.00s (+ 0.67%) 0.74s 0.77s
Check Time 4.28s (± 0.38%) 4.32s (± 0.36%) +0.04s (+ 0.93%) 4.29s 4.36s
Emit Time 3.03s (± 1.09%) 3.06s (± 0.74%) +0.02s (+ 0.82%) 3.01s 3.11s
Total Time 9.01s (± 0.50%) 9.08s (± 0.38%) +0.08s (+ 0.84%) 9.01s 9.16s
material-ui - node (v10.16.3, x64)
Memory used 453,844k (± 0.01%) 453,554k (± 0.01%) -290k (- 0.06%) 453,402k 453,652k
Parse Time 1.77s (± 0.35%) 1.78s (± 0.37%) +0.01s (+ 0.51%) 1.76s 1.79s
Bind Time 0.68s (± 0.00%) 0.69s (± 0.84%) +0.01s (+ 1.03%) 0.68s 0.70s
Check Time 13.58s (± 0.53%) 13.75s (± 1.00%) +0.17s (+ 1.25%) 13.52s 13.98s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.04s (± 0.47%) 16.22s (± 0.89%) +0.19s (+ 1.16%) 15.97s 16.45s
Angular - node (v12.1.0, x64)
Memory used 303,519k (± 0.03%) 302,861k (± 0.07%) -658k (- 0.22%) 302,091k 303,078k
Parse Time 1.58s (± 0.67%) 1.58s (± 0.60%) +0.01s (+ 0.51%) 1.56s 1.60s
Bind Time 0.87s (± 0.74%) 0.88s (± 0.66%) +0.01s (+ 0.57%) 0.86s 0.89s
Check Time 4.65s (± 0.44%) 4.69s (± 0.81%) +0.04s (+ 0.82%) 4.64s 4.81s
Emit Time 5.45s (± 0.69%) 5.50s (± 0.82%) +0.05s (+ 0.95%) 5.40s 5.60s
Total Time 12.54s (± 0.30%) 12.65s (± 0.65%) +0.11s (+ 0.85%) 12.48s 12.89s
Monaco - node (v12.1.0, x64)
Memory used 306,981k (± 0.01%) 306,997k (± 0.02%) +16k (+ 0.01%) 306,844k 307,125k
Parse Time 1.21s (± 0.74%) 1.22s (± 0.69%) +0.01s (+ 1.16%) 1.20s 1.24s
Bind Time 0.74s (± 0.98%) 0.74s (± 0.50%) +0.00s (+ 0.40%) 0.74s 0.75s
Check Time 4.56s (± 0.39%) 4.57s (± 0.51%) +0.01s (+ 0.26%) 4.53s 4.63s
Emit Time 2.93s (± 0.34%) 2.98s (± 0.52%) +0.06s (+ 1.91%) 2.94s 3.01s
Total Time 9.44s (± 0.29%) 9.52s (± 0.39%) +0.08s (+ 0.87%) 9.44s 9.62s
TFS - node (v12.1.0, x64)
Memory used 274,148k (± 0.02%) 274,201k (± 0.02%) +53k (+ 0.02%) 274,054k 274,368k
Parse Time 0.93s (± 0.40%) 0.94s (± 0.94%) +0.01s (+ 0.86%) 0.92s 0.96s
Bind Time 0.70s (± 0.83%) 0.71s (± 0.94%) +0.01s (+ 1.00%) 0.70s 0.72s
Check Time 4.17s (± 0.43%) 4.20s (± 0.54%) +0.02s (+ 0.58%) 4.13s 4.25s
Emit Time 3.08s (± 1.09%) 3.13s (± 0.62%) +0.05s (+ 1.66%) 3.08s 3.17s
Total Time 8.89s (± 0.46%) 8.98s (± 0.42%) +0.09s (+ 0.99%) 8.90s 9.05s
material-ui - node (v12.1.0, x64)
Memory used 431,047k (± 0.04%) 430,820k (± 0.05%) -228k (- 0.05%) 429,990k 431,078k
Parse Time 1.75s (± 0.60%) 1.76s (± 0.80%) +0.01s (+ 0.57%) 1.74s 1.81s
Bind Time 0.63s (± 1.29%) 0.64s (± 1.20%) +0.00s (+ 0.79%) 0.62s 0.66s
Check Time 12.14s (± 0.88%) 12.25s (± 0.71%) +0.12s (+ 0.96%) 12.06s 12.45s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.52s (± 0.76%) 14.65s (± 0.59%) +0.13s (+ 0.91%) 14.52s 14.85s
Angular - node (v8.9.0, x64)
Memory used 322,722k (± 0.02%) 322,253k (± 0.01%) -469k (- 0.15%) 322,177k 322,321k
Parse Time 2.10s (± 0.36%) 2.12s (± 0.48%) +0.01s (+ 0.48%) 2.09s 2.14s
Bind Time 0.92s (± 0.72%) 0.92s (± 0.64%) +0.00s (+ 0.43%) 0.91s 0.94s
Check Time 5.40s (± 1.74%) 5.46s (± 1.25%) +0.06s (+ 1.13%) 5.21s 5.55s
Emit Time 6.25s (± 1.42%) 6.21s (± 0.63%) -0.04s (- 0.58%) 6.14s 6.29s
Total Time 14.68s (± 0.35%) 14.72s (± 0.44%) +0.04s (+ 0.27%) 14.56s 14.85s
Monaco - node (v8.9.0, x64)
Memory used 325,338k (± 0.01%) 325,414k (± 0.01%) +76k (+ 0.02%) 325,356k 325,474k
Parse Time 1.54s (± 0.22%) 1.54s (± 0.60%) +0.00s (+ 0.13%) 1.53s 1.57s
Bind Time 0.89s (± 0.45%) 0.90s (± 1.01%) +0.01s (+ 1.35%) 0.89s 0.92s
Check Time 5.41s (± 0.52%) 5.42s (± 0.82%) +0.01s (+ 0.24%) 5.34s 5.53s
Emit Time 3.49s (± 0.45%) 3.53s (± 0.35%) +0.04s (+ 1.23%) 3.51s 3.57s
Total Time 11.32s (± 0.29%) 11.40s (± 0.45%) +0.07s (+ 0.65%) 11.31s 11.53s
TFS - node (v8.9.0, x64)
Memory used 291,275k (± 0.01%) 291,254k (± 0.01%) -21k (- 0.01%) 291,137k 291,327k
Parse Time 1.25s (± 0.42%) 1.25s (± 0.32%) 0.00s ( 0.00%) 1.24s 1.26s
Bind Time 0.75s (± 0.50%) 0.75s (± 0.49%) +0.00s (+ 0.13%) 0.74s 0.75s
Check Time 4.83s (± 0.94%) 4.86s (± 0.78%) +0.03s (+ 0.60%) 4.76s 4.94s
Emit Time 3.32s (± 1.61%) 3.36s (± 1.10%) +0.04s (+ 1.36%) 3.25s 3.47s
Total Time 10.15s (± 0.44%) 10.23s (± 0.48%) +0.08s (+ 0.78%) 10.11s 10.35s
material-ui - node (v8.9.0, x64)
Memory used 456,352k (± 0.01%) 456,169k (± 0.01%) -183k (- 0.04%) 456,080k 456,307k
Parse Time 2.10s (± 0.57%) 2.12s (± 0.51%) +0.02s (+ 0.71%) 2.10s 2.14s
Bind Time 0.81s (± 0.73%) 0.82s (± 1.22%) +0.01s (+ 0.74%) 0.79s 0.84s
Check Time 17.66s (± 0.74%) 17.86s (± 1.02%) +0.21s (+ 1.16%) 17.43s 18.18s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.58s (± 0.67%) 20.80s (± 0.91%) +0.23s (+ 1.10%) 20.36s 21.14s
Angular - node (v8.9.0, x86)
Memory used 185,610k (± 0.03%) 185,446k (± 0.02%) -164k (- 0.09%) 185,353k 185,536k
Parse Time 2.05s (± 0.54%) 2.06s (± 0.76%) +0.01s (+ 0.54%) 2.03s 2.10s
Bind Time 1.07s (± 0.63%) 1.07s (± 0.52%) +0.01s (+ 0.47%) 1.06s 1.08s
Check Time 5.00s (± 0.62%) 5.02s (± 0.33%) +0.01s (+ 0.28%) 4.98s 5.04s
Emit Time 5.95s (± 0.74%) 6.07s (± 1.00%) +0.12s (+ 2.02%) 5.94s 6.27s
Total Time 14.07s (± 0.51%) 14.22s (± 0.43%) +0.15s (+ 1.07%) 14.09s 14.41s
Monaco - node (v8.9.0, x86)
Memory used 185,169k (± 0.03%) 185,190k (± 0.02%) +21k (+ 0.01%) 185,134k 185,282k
Parse Time 1.59s (± 0.49%) 1.59s (± 0.58%) +0.00s (+ 0.06%) 1.57s 1.61s
Bind Time 0.77s (± 0.64%) 0.78s (± 1.05%) +0.01s (+ 1.44%) 0.76s 0.80s
Check Time 5.36s (± 1.11%) 5.45s (± 0.53%) +0.08s (+ 1.57%) 5.38s 5.50s
Emit Time 2.90s (± 3.35%) 2.89s (± 0.89%) -0.01s (- 0.38%) 2.83s 2.95s
Total Time 10.62s (± 0.54%) 10.69s (± 0.47%) +0.08s (+ 0.73%) 10.54s 10.79s
TFS - node (v8.9.0, x86)
Memory used 166,693k (± 0.02%) 166,675k (± 0.02%) -18k (- 0.01%) 166,627k 166,758k
Parse Time 1.29s (± 1.35%) 1.29s (± 0.65%) +0.01s (+ 0.39%) 1.28s 1.31s
Bind Time 0.71s (± 1.06%) 0.72s (± 1.37%) +0.00s (+ 0.56%) 0.70s 0.75s
Check Time 4.63s (± 0.48%) 4.64s (± 0.68%) +0.01s (+ 0.32%) 4.58s 4.72s
Emit Time 2.92s (± 1.36%) 3.01s (± 0.94%) +0.08s (+ 2.84%) 2.96s 3.10s
Total Time 9.55s (± 0.54%) 9.66s (± 0.62%) +0.11s (+ 1.13%) 9.55s 9.79s
material-ui - node (v8.9.0, x86)
Memory used 258,080k (± 0.02%) 257,996k (± 0.02%) -84k (- 0.03%) 257,897k 258,067k
Parse Time 2.19s (± 0.99%) 2.19s (± 0.46%) -0.00s (- 0.14%) 2.17s 2.22s
Bind Time 0.68s (± 1.29%) 0.69s (± 1.53%) +0.01s (+ 1.03%) 0.67s 0.71s
Check Time 16.22s (± 0.59%) 16.24s (± 0.65%) +0.03s (+ 0.17%) 16.02s 16.60s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.09s (± 0.54%) 19.12s (± 0.57%) +0.03s (+ 0.15%) 18.93s 19.50s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36688 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Mar 16, 2020

Copy link
Copy Markdown
Member Author

Results are a little scattered but seem to be plausibly within ~1% difference
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn Nathan Shively-Sanders (sandersn) assigned Ron Buckton (rbuckton) and unassigned Andrew Branch (andrewbranch) Mar 17, 2020
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Mar 18, 2020
Convert to async function: handle type arguments to then/catch #37463
Merged
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Mar 18, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems more straightforward than the last time I read this. The changes to the existing tests look good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andrewbranch reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@andrewbranch
Andrew Branch (andrewbranch) merged commit 237ea52 into microsoft:master Mar 19, 2020
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/27294 branch March 19, 2020 16:46
@AbdelrahmanHafez Hafez (AbdelrahmanHafez) mentioned this pull request Apr 27, 2020
[Bug] Refactor breaks some statements into 2 lines #38204
Closed
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Oct 2, 2020
Organize Import creates whitespace that needs to be deleted manually #40736
Closed
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Feb 3, 2021
Fix preserveSourceNewlines sibling node comparison (fixes extra newlines in organize imports) #42630
Merged
@wbt wbt mentioned this pull request Feb 16, 2022
Emit does not preserve empty lines #843
Closed
@github-actions github-actions Bot mentioned this pull request Aug 14, 2022
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham
@rbuckton Ron Buckton (rbuckton) Awaiting requested review from rbuckton

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rbuckton Ron Buckton (rbuckton)

Labels

Author: Team

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor removes whitespace

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andrewbranch @typescript-bot @sandersn @rbuckton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.