GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add deprecated related feature by Kingwl · Pull Request #38523 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented May 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #390
Fixes #33092
Fixes #33093

After read the codebase, I found below things need todo:

  • completions with symbol tag

  • workspace symbol with symbol tag

  • document symbol with symbol tag

  • call hierarchy with symbol tag

  • DiagnosticTags

current state:
222

TIM截图20200514183407
TIM截图20200514183420
TIM截图20200514184807
TIM截图20200518150229

image

Others need to do:

  • protocol
  • reports deprecated diag
  • confirm where's the line
  • confirm the place where report suggestion is correct
  • tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xiaoxiangmoe, justbilt, LookRain, alexnault, feichao93, Cristy94, ph1p, EliazTray, cpyle0819, Moncef12, and 2 more reacted with thumbs up emoji fbartho, JustinBeckwith, styfle, KagamiChan, nsmaciej, hoodie, saschanaz, and pythlang reacted with hooray emoji niklashigi, itsMapleLeaf, Den-dp, alexrock, rashdeva, JustinBeckwith, G-Rath, nostalic, styfle, kachkaev, and 11 more reacted with heart emoji brussee, millsp, pythlang, and Leland reacted with rocket emoji glen-84, lgarczyn, and pythlang reacted with eyes emoji
All reactions
  • 👍 12 reactions
  • 🎉 8 reactions
  • ❤️ 21 reactions
  • 🚀 4 reactions
  • 👀 3 reactions
@typescript-bot

TypeScript Bot (typescript-bot) commented May 13, 2020

Copy link
Copy Markdown
Contributor

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 9185734. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl Wenlu Wang (Kingwl) changed the title Add deprecated related feature [Expirement] [WIP] Add deprecated related feature May 13, 2020
@Kingwl Wenlu Wang (Kingwl) mentioned this pull request May 13, 2020
Build error #38525
Merged
@Kingwl

Wenlu Wang (Kingwl) commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 726b933. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73795/artifacts?artifactName=tgz&fileId=744B1D71C0DD25EAC199979B809F997229EB4AB80010D5B25D42E3374ABD21EE02&fileName=/typescript-4.0.0-insiders.20200513.tgz"
    }
}

and then running npm install.

There is also a playground for this build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl Wenlu Wang (Kingwl) mentioned this pull request May 13, 2020
Add ts/js deprecated support microsoft/vscode#97742
Merged
@Kingwl

Wenlu Wang (Kingwl) commented May 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Ping, need some help. Please take a look
Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks), Daniel Rosenwasser (@DanielRosenwasser)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented May 14, 2020

Copy link
Copy Markdown
Contributor Author

Another problem is, where's the line:

a.b.c.d // c is deprecated

What is the expected behavior?

  1. [a.b.c].d
  2. a.b.[c].d
  3. a.b.[c.d]

And if:

a.b.c.d // c and d is deprecated

What is the expected behavior

  1. [a.b.c.d]
  2. a.b.[c].[d]
  3. a.b.[c.d]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amcasey

Andrew Casey (amcasey) commented May 14, 2020

Copy link
Copy Markdown
Member

Wenlu Wang (@Kingwl), sorry, I'm not sure I understand your question. Are you asking about the design of the features? If so, you probably want Nathan Shively-Sanders (@sandersn).
Kingwl reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn Nathan Shively-Sanders (sandersn) self-assigned this May 14, 2020
@Kingwl

Wenlu Wang (Kingwl) commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

Does the protocol looks good？I'm not sure🤷‍♂️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 15, 2020
View reviewed changes
Comment thread src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 15, 2020
View reviewed changes
Comment thread src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 15, 2020
View reviewed changes
Comment thread src/services/completions.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 15, 2020
View reviewed changes
Comment thread src/compiler/types.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@spahnke

Sebastian Pahnke (spahnke) commented May 17, 2020

Copy link
Copy Markdown

I believe this would also fix #33093
Kingwl reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented May 18, 2020

Copy link
Copy Markdown
Contributor Author

Finally, It passed tests. I'll add more tests soon.
TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at ceeaead. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/74212/artifacts?artifactName=tgz&fileId=2056AC579024F64F4D733979778E0700E6D317EE140EA5F9D238E4B88C38090F02&fileName=/typescript-4.0.0-insiders.20200518.tgz"
    }
}

and then running npm install.

There is also a playground for this build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 18, 2020
View reviewed changes
Comment thread src/compiler/binder.ts Outdated
}
}

symbol.isDeprecated = symbol.isDeprecated || isDeprecated;

@sheetalkamat Sheetal Nandi (sheetalkamat) May 18, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHould this be SymbolFlags instead?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) Jun 11, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree -- if there's space there. I think the limit is 29 so there's 1 left.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) Jun 12, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, making this a ModifierFlag would go well with public/Alex Stapleton (@public) et al. It would also go better with getNodeModifiers in services.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Wenlu Wang (Kingwl) added 7 commits May 20, 2020 10:06
@Kingwl
Add deprecated related feature
bb09d38
@Kingwl
Add more support
5a8da16
@Kingwl
fix navtree
2deadaa
@Kingwl
Add identifier check
9847ffb
@Kingwl
Add more deprecated
06c8d22
@Kingwl
fix crash
03d1ffe
@Kingwl
fix more crash
30cea12
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..38523

Metric master 38523 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 340,211k (± 0.02%) 339,838k (± 0.02%) -373k (- 0.11%) 339,673k 339,959k
Parse Time 1.98s (± 0.59%) 1.98s (± 0.70%) +0.00s (+ 0.00%) 1.94s 2.01s
Bind Time 0.81s (± 1.32%) 0.80s (± 0.59%) -0.00s (- 0.37%) 0.79s 0.81s
Check Time 4.68s (± 0.56%) 4.71s (± 0.57%) +0.02s (+ 0.51%) 4.65s 4.79s
Emit Time 5.21s (± 0.79%) 5.18s (± 0.41%) -0.03s (- 0.52%) 5.13s 5.22s
Total Time 12.67s (± 0.48%) 12.66s (± 0.38%) -0.01s (- 0.05%) 12.57s 12.79s
Monaco - node (v10.16.3, x64)
Memory used 338,724k (± 0.01%) 338,774k (± 0.02%) +50k (+ 0.01%) 338,667k 338,949k
Parse Time 1.55s (± 0.69%) 1.55s (± 0.62%) -0.00s (- 0.19%) 1.52s 1.57s
Bind Time 0.69s (± 0.58%) 0.69s (± 0.69%) -0.00s (- 0.29%) 0.68s 0.70s
Check Time 4.85s (± 0.56%) 4.84s (± 0.49%) -0.01s (- 0.12%) 4.78s 4.88s
Emit Time 2.75s (± 0.49%) 2.73s (± 0.55%) -0.01s (- 0.55%) 2.70s 2.76s
Total Time 9.83s (± 0.38%) 9.80s (± 0.23%) -0.03s (- 0.25%) 9.73s 9.85s
TFS - node (v10.16.3, x64)
Memory used 301,536k (± 0.02%) 301,848k (± 0.03%) +312k (+ 0.10%) 301,663k 302,032k
Parse Time 1.21s (± 1.09%) 1.21s (± 0.91%) -0.00s (- 0.08%) 1.18s 1.22s
Bind Time 0.64s (± 1.47%) 0.65s (± 1.39%) +0.01s (+ 0.78%) 0.62s 0.66s
Check Time 4.35s (± 0.66%) 4.35s (± 0.44%) +0.00s (+ 0.07%) 4.32s 4.40s
Emit Time 2.85s (± 0.97%) 2.87s (± 1.34%) +0.02s (+ 0.56%) 2.77s 2.94s
Total Time 9.04s (± 0.58%) 9.07s (± 0.53%) +0.03s (+ 0.29%) 8.95s 9.21s
material-ui - node (v10.16.3, x64)
Memory used 459,155k (± 0.02%) 459,128k (± 0.01%) -26k (- 0.01%) 459,009k 459,276k
Parse Time 2.02s (± 0.52%) 2.03s (± 0.52%) +0.00s (+ 0.15%) 2.01s 2.05s
Bind Time 0.64s (± 1.32%) 0.65s (± 1.35%) +0.01s (+ 2.19%) 0.64s 0.67s
Check Time 12.80s (± 0.71%) 12.85s (± 0.57%) +0.05s (+ 0.43%) 12.69s 13.00s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.46s (± 0.63%) 15.53s (± 0.54%) +0.07s (+ 0.47%) 15.38s 15.72s
Angular - node (v12.1.0, x64)
Memory used 317,588k (± 0.03%) 317,116k (± 0.09%) -472k (- 0.15%) 316,034k 317,351k
Parse Time 1.95s (± 0.39%) 1.93s (± 0.75%) -0.02s (- 1.28%) 1.90s 1.96s
Bind Time 0.78s (± 0.57%) 0.78s (± 0.67%) -0.00s (- 0.13%) 0.77s 0.79s
Check Time 4.57s (± 0.58%) 4.59s (± 0.63%) +0.02s (+ 0.35%) 4.53s 4.65s
Emit Time 5.32s (± 0.53%) 5.31s (± 1.00%) -0.01s (- 0.23%) 5.21s 5.46s
Total Time 12.63s (± 0.37%) 12.61s (± 0.68%) -0.03s (- 0.20%) 12.45s 12.84s
Monaco - node (v12.1.0, x64)
Memory used 321,236k (± 0.02%) 321,314k (± 0.02%) +79k (+ 0.02%) 321,184k 321,497k
Parse Time 1.52s (± 0.60%) 1.51s (± 1.00%) -0.01s (- 0.66%) 1.48s 1.54s
Bind Time 0.67s (± 0.60%) 0.68s (± 1.01%) +0.00s (+ 0.60%) 0.66s 0.69s
Check Time 4.65s (± 0.44%) 4.63s (± 0.37%) -0.02s (- 0.37%) 4.60s 4.66s
Emit Time 2.81s (± 0.44%) 2.80s (± 0.58%) -0.02s (- 0.53%) 2.76s 2.83s
Total Time 9.65s (± 0.28%) 9.61s (± 0.18%) -0.04s (- 0.38%) 9.57s 9.65s
TFS - node (v12.1.0, x64)
Memory used 285,983k (± 0.02%) 286,294k (± 0.02%) +311k (+ 0.11%) 286,197k 286,394k
Parse Time 1.22s (± 0.79%) 1.23s (± 1.02%) +0.00s (+ 0.33%) 1.20s 1.26s
Bind Time 0.61s (± 0.97%) 0.62s (± 1.33%) +0.01s (+ 1.63%) 0.60s 0.64s
Check Time 4.25s (± 0.54%) 4.25s (± 0.39%) +0.00s (+ 0.12%) 4.22s 4.30s
Emit Time 2.90s (± 0.69%) 2.91s (± 1.02%) +0.00s (+ 0.07%) 2.83s 2.97s
Total Time 8.99s (± 0.43%) 9.00s (± 0.44%) +0.02s (+ 0.20%) 8.90s 9.09s
material-ui - node (v12.1.0, x64)
Memory used 437,736k (± 0.02%) 437,626k (± 0.01%) -110k (- 0.03%) 437,520k 437,782k
Parse Time 1.99s (± 0.58%) 2.01s (± 0.76%) +0.02s (+ 0.95%) 1.99s 2.05s
Bind Time 0.63s (± 0.98%) 0.63s (± 1.05%) -0.00s (- 0.16%) 0.61s 0.64s
Check Time 11.45s (± 0.52%) 11.45s (± 0.56%) +0.00s (+ 0.04%) 11.34s 11.66s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.07s (± 0.41%) 14.09s (± 0.42%) +0.02s (+ 0.16%) 14.01s 14.28s
Angular - node (v8.9.0, x64)
Memory used 336,631k (± 0.02%) 336,369k (± 0.02%) -262k (- 0.08%) 336,259k 336,489k
Parse Time 2.49s (± 0.57%) 2.49s (± 0.73%) +0.00s (+ 0.12%) 2.46s 2.54s
Bind Time 0.83s (± 0.60%) 0.83s (± 0.70%) +0.01s (+ 0.97%) 0.82s 0.84s
Check Time 5.31s (± 0.50%) 5.36s (± 0.60%) +0.05s (+ 0.88%) 5.27s 5.44s
Emit Time 5.90s (± 1.04%) 5.97s (± 1.06%) +0.07s (+ 1.20%) 5.83s 6.10s
Total Time 14.53s (± 0.46%) 14.65s (± 0.62%) +0.13s (+ 0.87%) 14.49s 14.85s
Monaco - node (v8.9.0, x64)
Memory used 340,066k (± 0.01%) 340,145k (± 0.01%) +79k (+ 0.02%) 340,063k 340,233k
Parse Time 1.85s (± 0.57%) 1.85s (± 0.48%) +0.00s (+ 0.22%) 1.84s 1.88s
Bind Time 0.86s (± 0.46%) 0.86s (± 0.52%) +0.00s (+ 0.12%) 0.85s 0.87s
Check Time 5.33s (± 0.38%) 5.33s (± 0.53%) +0.00s (+ 0.08%) 5.29s 5.39s
Emit Time 3.21s (± 0.53%) 3.20s (± 0.54%) -0.01s (- 0.19%) 3.17s 3.24s
Total Time 11.25s (± 0.24%) 11.25s (± 0.42%) +0.00s (+ 0.03%) 11.15s 11.36s
TFS - node (v8.9.0, x64)
Memory used 303,226k (± 0.01%) 303,498k (± 0.01%) +272k (+ 0.09%) 303,431k 303,576k
Parse Time 1.54s (± 0.26%) 1.54s (± 0.50%) +0.00s (+ 0.00%) 1.53s 1.56s
Bind Time 0.65s (± 0.76%) 0.65s (± 0.53%) +0.00s (+ 0.15%) 0.64s 0.65s
Check Time 4.96s (± 1.74%) 4.93s (± 1.80%) -0.03s (- 0.54%) 4.81s 5.13s
Emit Time 3.05s (± 3.38%) 3.06s (± 3.18%) +0.01s (+ 0.46%) 2.81s 3.24s
Total Time 10.19s (± 0.61%) 10.19s (± 0.53%) -0.01s (- 0.06%) 10.09s 10.33s
material-ui - node (v8.9.0, x64)
Memory used 463,424k (± 0.01%) 463,232k (± 0.01%) -191k (- 0.04%) 463,123k 463,335k
Parse Time 2.35s (± 0.51%) 2.37s (± 0.49%) +0.01s (+ 0.55%) 2.34s 2.39s
Bind Time 0.76s (± 0.81%) 0.77s (± 0.87%) +0.01s (+ 0.79%) 0.76s 0.78s
Check Time 16.97s (± 0.50%) 16.94s (± 0.88%) -0.03s (- 0.17%) 16.61s 17.28s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.08s (± 0.42%) 20.07s (± 0.71%) -0.01s (- 0.05%) 19.77s 20.40s
Angular - node (v8.9.0, x86)
Memory used 193,160k (± 0.01%) 193,040k (± 0.02%) -120k (- 0.06%) 192,942k 193,128k
Parse Time 2.42s (± 0.70%) 2.41s (± 0.65%) -0.01s (- 0.37%) 2.38s 2.45s
Bind Time 0.97s (± 0.57%) 0.97s (± 0.85%) +0.00s (+ 0.21%) 0.95s 0.99s
Check Time 4.78s (± 0.54%) 4.78s (± 0.55%) +0.00s (+ 0.02%) 4.73s 4.84s
Emit Time 5.98s (± 1.03%) 5.88s (± 1.07%) -0.10s (- 1.70%) 5.71s 5.98s
Total Time 14.15s (± 0.57%) 14.04s (± 0.43%) -0.11s (- 0.76%) 13.85s 14.17s
Monaco - node (v8.9.0, x86)
Memory used 193,139k (± 0.02%) 193,179k (± 0.01%) +40k (+ 0.02%) 193,126k 193,241k
Parse Time 1.89s (± 1.30%) 1.89s (± 0.68%) -0.01s (- 0.37%) 1.85s 1.91s
Bind Time 0.68s (± 0.59%) 0.68s (± 0.70%) -0.00s (- 0.29%) 0.67s 0.69s
Check Time 5.40s (± 1.97%) 5.45s (± 0.37%) +0.05s (+ 0.96%) 5.41s 5.50s
Emit Time 2.76s (± 3.52%) 2.67s (± 0.82%) 🟩-0.09s (- 3.23%) 2.62s 2.73s
Total Time 10.72s (± 0.53%) 10.68s (± 0.24%) -0.04s (- 0.40%) 10.63s 10.73s
TFS - node (v8.9.0, x86)
Memory used 173,321k (± 0.02%) 173,512k (± 0.02%) +191k (+ 0.11%) 173,448k 173,642k
Parse Time 1.58s (± 1.03%) 1.58s (± 0.73%) -0.01s (- 0.38%) 1.55s 1.60s
Bind Time 0.62s (± 1.08%) 0.61s (± 0.73%) -0.00s (- 0.81%) 0.60s 0.62s
Check Time 4.61s (± 0.44%) 4.61s (± 0.68%) 0.00s ( 0.00%) 4.56s 4.70s
Emit Time 2.78s (± 1.33%) 2.78s (± 1.18%) +0.00s (+ 0.14%) 2.70s 2.88s
Total Time 9.59s (± 0.43%) 9.59s (± 0.54%) -0.01s (- 0.08%) 9.49s 9.70s
material-ui - node (v8.9.0, x86)
Memory used 262,246k (± 0.02%) 262,174k (± 0.02%) -72k (- 0.03%) 262,061k 262,249k
Parse Time 2.42s (± 0.62%) 2.43s (± 0.52%) +0.00s (+ 0.21%) 2.39s 2.45s
Bind Time 0.66s (± 1.34%) 0.66s (± 0.89%) +0.01s (+ 1.07%) 0.65s 0.68s
Check Time 15.48s (± 0.68%) 15.46s (± 0.91%) -0.02s (- 0.13%) 15.22s 15.95s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.56s (± 0.64%) 18.56s (± 0.74%) -0.01s (- 0.03%) 18.32s 19.02s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 38523 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Nathan Shively-Sanders (sandersn) added 2 commits June 18, 2020 16:48
@sandersn
Merge branch 'master' into deprecated_support
7714dbf
@sandersn
set @octokit/rest back to latest
6b30216
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Jun 18, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to recap: we now have NodeFlags.Deprecated, SymbolFlags.Deprecated and ModifierFlags.Deprecated.

I would say we are well-positioned to deprecate things now. =)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
styfle, mickdekkers, Den-dp, ExE-Boss, riceyrice, and voxpelli reacted with rocket emoji
All reactions
  • 🚀 6 reactions
@sandersn
fix trailing spacel int
6434447
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 59ad375 into microsoft:master Jun 19, 2020
@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 19, 2020

Copy link
Copy Markdown
Member

It's in! Thanks so much for your persistence Wenlu Wang (@Kingwl)!
Kingwl, crutchcorn, nostalic, G-Rath, styfle, mickdekkers, Den-dp, macchiitaka, matijagrcic, and voxpelli reacted with heart emoji
All reactions
  • ❤️ 10 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@G-Rath

Gareth Jones (G-Rath) commented Jun 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

I've not followed this feature much, so while I've done a quick read over the discussions, linked tickets & searched the issue tracker I still could have missed something or misunderstood entirely, but just in case:

Has anyone raised the behaviour of removeComments in regards to this feature? I know a few libraries that use that flag, and so this feature is a bit moot if it removes @deprecated comments.

Happy to open a new issue for discussion.

Just found #14619, which would resolve this problem.
nealeu and ExE-Boss reacted with thumbs up emoji Kingwl and sandersn reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl
Wenlu Wang (Kingwl) deleted the deprecated_support branch June 19, 2020 02:57
@Kingwl

Wenlu Wang (Kingwl) commented Jun 19, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 6434447. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pooya Parsa (pi0) referenced this pull request in nuxt/nuxt Jun 23, 2020
@kevinmarrec
fix(types): fix Configuration interface
dac1e39
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jun 24, 2020
@deprecated appears for any element access that might access a deprecated member #39246
Closed
@rbuckton Ron Buckton (rbuckton) mentioned this pull request Jul 7, 2020
values are marked deprecated when only type has @deprecated #39474
Closed
@fbartho Frederic Barthelemy (fbartho) mentioned this pull request Aug 9, 2020
maxContentSizeMultiplier prop not working on Text microsoft/reactxp#1052
Open
@lijuenc Li Juen Chang (lijuenc) mentioned this pull request Aug 19, 2020
Handling deprecation in Kaizen cultureamp/kaizen-design-system#701
Closed
@maapteh Mаартен - Maarten (maapteh) mentioned this pull request Aug 26, 2020
have deprecated also work in generated hooks dotansimha/graphql-code-generator#4642
Closed
@barthap Bartłomiej Klocek (barthap) mentioned this pull request Aug 27, 2020
[packages] Add @deprecated annotations to deprecated APIs expo/expo#9959
Merged
@brabenetz

Harald Brabenetz (brabenetz) commented Aug 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Does it works with a comment which explain why something is deprecated?
I saw not a singe example with a comment!?
Like:

/** @deprecated replaced by new method .... */
public myOldMethod() {
...

VSCode should than show that message.
And tslint should enforce a comment.
HolgerJeromin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Łukasz Kosmaty (lukmccall) pushed a commit to expo/expo that referenced this pull request Sep 1, 2020
@barthap
[packages] Add @deprecated annotations to deprecated APIs (#9959)
65428d5 
# Why

_This follows the TS 4.0 update PR: #9960_

Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~.

See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523

# How

- Added appropriate annotations to every possible deprecated Expo API that I found.
- Updated existing comments to play nice with VS Code messages

Also, added note about dead code in Notifications, which is related to #9563 (I forgot to add it then)

> Not sure what to do with changelogs ❓ 

# Test Plan

Tested messages in VS Code with _TS 4.0.2_ enabled.
@Kingwl

Wenlu Wang (Kingwl) commented Sep 1, 2020

Copy link
Copy Markdown
Contributor Author

image

Seems work for me
Den-dp reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fregante fregante mentioned this pull request Oct 1, 2020
Rule proposal: avoid using deprecated code typescript-eslint/typescript-eslint#2620
Closed
@ajafff Klaus Meinhardt (ajafff) mentioned this pull request Jan 3, 2021
getSyntacticModifierFlags return value affected by getEffectiveModifierFlags #42189
Closed
James Edwards-Jones (Jamedjo) pushed a commit to Jamedjo/expo that referenced this pull request Feb 4, 2021
@barthap
[packages] Add @deprecated annotations to deprecated APIs (expo#9959)
8216412 
# Why

_This follows the TS 4.0 update PR: #9960_

Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~.

See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523

# How

- Added appropriate annotations to every possible deprecated Expo API that I found.
- Updated existing comments to play nice with VS Code messages

Also, added note about dead code in Notifications, which is related to expo#9563 (I forgot to add it then)

> Not sure what to do with changelogs ❓ 

# Test Plan

Tested messages in VS Code with _TS 4.0.2_ enabled.
@predragnikolic Предраг Николић (predragnikolic) mentioned this pull request Jul 5, 2021
Mark completion items as deprecated if JSDoc says so typescript-language-server/typescript-language-server#227
Merged
@github-actions github-actions Bot mentioned this pull request Oct 4, 2022
[Korean] Fix weird expressions like '_제네릭_' microsoft/TypeScript-Website-Localizations#171
Merged
@paulyoung

Paul Young (paulyoung) commented Sep 6, 2023

Copy link
Copy Markdown

Is there a way to suppress this warning using // eslint-disable-next-line or similar?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eric Tyrrell (Eric-Tyrrell22) pushed a commit to Eric-Tyrrell22/expo that referenced this pull request Aug 14, 2025
@barthap
[packages] Add @deprecated annotations to deprecated APIs (expo#9959)
859e791 
# Why

_This follows the TS 4.0 update PR: #9960_

Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~.

See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523

# How

- Added appropriate annotations to every possible deprecated Expo API that I found.
- Updated existing comments to play nice with VS Code messages

Also, added note about dead code in Notifications, which is related to expo#9563 (I forgot to add it then)

> Not sure what to do with changelogs ❓ 

# Test Plan

Tested messages in VS Code with _TS 4.0.2_ enabled.
Jakub Kosmydel (kosmydel) pushed a commit to kosmydel/expo-quest that referenced this pull request Sep 15, 2025
@barthap
[packages] Add @deprecated annotations to deprecated APIs (#9959)
7fdcbd9 
# Why

_This follows the TS 4.0 update PR: #9960_

Typescript 4.0 comes with support for `@deprecated` annotations, which gives nice VS Code (and probably other IDE) messages informing users about API deprecation. It also marks deprecated methods/properties with ~~Strikethrough~~.

See [this](https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#deprecated-support) and microsoft/TypeScript#38523

# How

- Added appropriate annotations to every possible deprecated Expo API that I found.
- Updated existing comments to play nice with VS Code messages

Also, added note about dead code in Notifications, which is related to #9563 (I forgot to add it then)

> Not sure what to do with changelogs ❓ 

# Test Plan

Tested messages in VS Code with _TS 4.0.2_ enabled.
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser left review comments
@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat left review comments
@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

Experiment A fork with an experimental idea which might not make it into master For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Render uses of deprecated symbols Mark deprecated suggestion @‌deprecated JSDoc tag

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@Kingwl @typescript-bot @amcasey @spahnke @sandersn @RyanCavanaugh @G-Rath @brabenetz @paulyoung @DanielRosenwasser @sheetalkamat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.