GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix export * as default syntax by Kingwl · Pull Request #39803 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Jul 29, 2020 •
edited by rbuckton
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #39769
Fixes #39803

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Jack-Works reacted with hooray emoji HughCrail, mkubilayk, and itea-dev reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 3 reactions
@Kingwl
fix export * as default syntax
afd54f8
@typescript-bot TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn) Jul 29, 2020
@typescript-bot TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 29, 2020
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jul 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

[[Do not merge before Friday]]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested review from Ron Buckton (rbuckton) and Nathan Shively-Sanders (sandersn) July 29, 2020 21:30
sandersn
Nathan Shively-Sanders (sandersn) requested changes Jul 29, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

The implementation looks reasonable to me, but Ron Buckton (@rbuckton) should definitely sign off on the emitted code before this goes in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/compiler/parser.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/transformers/module/module.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
rbuckton
Ron Buckton (rbuckton) approved these changes Jul 29, 2020
View reviewed changes

@rbuckton Ron Buckton (rbuckton) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emit seems fine to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Kingwl
update comments
bdd6e12
@Kingwl

Wenlu Wang (Kingwl) commented Jul 30, 2020

Copy link
Copy Markdown
Contributor Author

[[Do not merge before Friday]]

Maybe you need a label Don't merge now :XD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit a80f60c into microsoft:master Aug 10, 2020
@Kingwl
Wenlu Wang (Kingwl) deleted the export_star_as_default branch August 19, 2020 03:02
@rbuckton Ron Buckton (rbuckton) mentioned this pull request Dec 17, 2020
Cannot export self module as default #38387
Closed
@johnnaegle John Naegle (johnnaegle) mentioned this pull request Aug 9, 2022
Question: Is it intended that the dependencies of the root index.ts are not rendered? pahen/madge#258
Closed
@tomekzaw Tomasz Zawadzki (tomekzaw) mentioned this pull request Aug 11, 2022
node_modules/react-native-reanimated/src/index.ts (7,13): Identifier expected. 'default' is a reserved word that cannot be used here software-mansion/react-native-reanimated#3460
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser left review comments
@sandersn Nathan Shively-Sanders (sandersn) sandersn requested changes
+1 more reviewer
@rbuckton Ron Buckton (rbuckton) rbuckton approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

export * as default from "module" syntax should work as per ECMA-262

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Kingwl @DanielRosenwasser @sandersn @rbuckton @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.