GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(31046): more accurate error message when derived class has different constructor signature by a-tarasyuk · Pull Request #40073 · microsoft/TypeScript

Conversation

Oleksandr Tarasiuk (a-tarasyuk) commented Aug 16, 2020

Copy link

Copy Markdown

Contributor

Fixes #31046
Fixes #21253

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label

Aug 16, 2020

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the bug/31046 branch from 9ad640f to 886079b Compare

August 16, 2020 12:18

Daniel Rosenwasser (DanielRosenwasser) requested changes

Aug 19, 2020

View reviewed changes

Comment thread

...baselines/reference/assignmentCompatWithConstructSignaturesWithOptionalParameters.errors.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the bug/31046 branch from 886079b to 22d94fd Compare

August 19, 2020 07:37

Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser)

August 19, 2020 07:41

Daniel Rosenwasser (DanielRosenwasser) reviewed

Aug 21, 2020

View reviewed changes

Comment thread

src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the bug/31046 branch from 22d94fd to 23fe54a Compare

August 21, 2020 07:51

Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser)

August 21, 2020 08:33

Daniel Rosenwasser (DanielRosenwasser) reviewed

Aug 21, 2020

View reviewed changes

Comment thread

tests/baselines/reference/assignmentCompatability44.errors.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix(31046): add new diagnostic message for incompatible constructor s…

d709265

…ignature

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the bug/31046 branch from 23fe54a to d709265 Compare

August 22, 2020 05:12

Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser)

August 22, 2020 05:15

Daniel Rosenwasser (DanielRosenwasser) commented Aug 22, 2020

Copy link

Copy Markdown

Member

Definitely looks like an improvement to me!

a-tarasyuk reacted with thumbs up emoji

a-tarasyuk reacted with hooray emoji

All reactions

👍 1 reaction
🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Daniel Rosenwasser (DanielRosenwasser) merged commit 2dd7a4b into microsoft:master

Aug 22, 2020

TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label

Aug 22, 2020

Wenlu Wang (Kingwl) pushed a commit to Kingwl/TypeScript that referenced this pull request

Aug 24, 2020


          fix(31046): add new diagnostic message for incompatible constructor s…

e6dabbe

…ignature (microsoft#40073)

Wenlu Wang (Kingwl) pushed a commit to Kingwl/TypeScript that referenced this pull request

Aug 24, 2020


          fix(31046): add new diagnostic message for incompatible constructor s…

1f5b1cc

…ignature (microsoft#40073)

Nathan Shively-Sanders (sandersn) pushed a commit that referenced this pull request

Sep 9, 2020


          Add see tag support (#39760)

ee5f51b

* Add see tag parser

* add baseline

* fix symbol resolve

* add more case

* fix unittests

* improve tests and parser

* accept baseline

* Adopt package-lock.json and npm ci

* Add a workflow to update package-lock.json daily

* Git ignore package-lock.json and forcibly update in workflow

* Update bot email address

* Delete extra npm update

* Update package-lock.json

* Add compactDisplay and signDisplay to NumberFormatOptions (#40039)

* Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176)

* fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684)

* fix(25770): add diagnostic message for the possible mapped type used as an index (#39973)

* fix(31046): add new diagnostic message for incompatible constructor signature (#40073)

* Update package-lock.json

* Update package-lock.json

* Add rename support

* Accpet baseline

* wip

* fix anders

* Revert "fix anders"

This reverts commit b3178d4.

* Fix call hierarchy item serialization and server tests (#40348)

* Avoid error

* accept baseline

* Add more tests

* Add signature name resolve

Co-authored-by: Andrew Casey <[email protected]>
Co-authored-by: TypeScript Bot <[email protected]>
Co-authored-by: Neil Kistner <[email protected]>
Co-authored-by: cherryblossom000 <[email protected]>
Co-authored-by: Alexander T <[email protected]>
Co-authored-by: Erich Gamma <[email protected]>
Co-authored-by: Andrew Branch <[email protected]>

Microsoft (microsoft) locked as resolved and limited conversation to collaborators

Oct 21, 2025

Reviewers

Daniel Rosenwasser (DanielRosenwasser)

Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Backlog Bug

PRs that fix a backlog bug

For Milestone Bug

PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

more accurate error message when derived class has different constructor signature Need better error message about incompatible constructor signature

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.