GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(26217): Add missing member fix should work for missing function by a-tarasyuk · Pull Request #41215 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Fixes #26217

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Oct 23, 2020
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review October 25, 2020 13:31
@a-tarasyuk
feat(26217): Add missing function declaration QF
dc448f9
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/26217 branch from a1d9f1f to dc448f9 Compare November 5, 2020 18:57
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested review from Daniel Rosenwasser (DanielRosenwasser), Jesse Trinity (jessetrinity) and Nathan Shively-Sanders (sandersn) November 18, 2020 12:55
@sandersn Nathan Shively-Sanders (sandersn) self-assigned this Nov 18, 2020
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Nov 19, 2020
TypeScript 4.2 Iteration Plan #41601
Closed
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Dec 2, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at dc448f9. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/90205/artifacts?artifactName=tgz&fileId=C92047E7D012B4C56A628CDC8A2082B9C79E19DE6093DAD2FAFB6036C022EA4902&fileName=/typescript-4.2.0-insiders.20201202.tgz"
    }
}

and then running npm install.

There is also a playground for this build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Dec 19, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of early comments -- I've looked at the tests, and they look good, but haven't looked at the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/cases/fourslash/importNameCodeFixNewImportNodeModules5.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/helpers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Oleksandr Tarasiuk (a-tarasyuk) added 2 commits December 19, 2020 12:38
@a-tarasyuk
use codeFixAvailable instead of codeFix
f3be16e
@a-tarasyuk
add diagnostics messages 'Method not implemented.' and 'Function not …
f322ed6 
…implemented.'
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/26217 branch from 127e16e to f322ed6 Compare December 19, 2020 10:38
@a-tarasyuk
use codeFixAvailable instead of codeFix
570493f
@OliverJAsh Oliver Joseph Ash (OliverJAsh) mentioned this pull request Dec 29, 2020
Suggestion: extract to function expression #31860
Open
5 tasks done
@a-tarasyuk
Merge branch 'master' of https://github.com/microsoft/TypeScript into…
fa994b7 
… feat/26217
jessetrinity
Jesse Trinity (jessetrinity) reviewed Jan 5, 2021
View reviewed changes

@jessetrinity Jesse Trinity (jessetrinity) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of questions but otherwise looks great 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/services/codefixes/fixAddMissingMember.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/helpers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/helpers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
fix signature types
3aec1be
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Jesse Trinity (jessetrinity) January 8, 2021 18:59
jessetrinity
Jesse Trinity (jessetrinity) approved these changes Jan 9, 2021
View reviewed changes
@jessetrinity
Jesse Trinity (jessetrinity) merged commit 0c58ede into microsoft:master Jan 9, 2021
Zzzen (Zzzen) pushed a commit to Zzzen/TypeScript that referenced this pull request Jan 16, 2021
@a-tarasyuk @Zzzen
feat(26217): Add missing member fix should work for missing function (m…
dfd7d97 
…icrosoft#41215)

* feat(26217): Add missing function declaration QF

* use codeFixAvailable instead of codeFix

* add diagnostics messages 'Method not implemented.' and 'Function not implemented.'

* use codeFixAvailable instead of codeFix

* fix signature types
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
+1 more reviewer
@jessetrinity Jesse Trinity (jessetrinity) jessetrinity approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing member fix should work for missing function

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@a-tarasyuk @DanielRosenwasser @typescript-bot @sandersn @jessetrinity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.