GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — If there are no open files, do not schedule ensureProjectForOpenFiles by sheetalkamat · Pull Request #41537 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Nov 14, 2020

Copy link
Copy Markdown
Member

Found while working on #39656

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) Nov 14, 2020
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 14, 2020
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Ryan Cavanaugh (RyanCavanaugh) and Andrew Casey (amcasey) November 14, 2020 00:57
amcasey
Andrew Casey (amcasey) reviewed Nov 16, 2020
View reviewed changes
Comment thread src/server/editorServices.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sheetalkamat
If there are no open files, do not schedule ensureProjectForOpenFiles
784bd0f
@sheetalkamat
Sheetal Nandi (sheetalkamat) force-pushed the ensureOpenProjects branch from 832f130 to 784bd0f Compare November 18, 2020 23:41
amcasey
Andrew Casey (amcasey) approved these changes Nov 18, 2020
View reviewed changes

@amcasey Andrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkTimeoutQueueLengthAndRun change looks unrelated. Otherwise, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

The checkTimeoutQueueLengthAndRun change looks unrelated.

This shows that we are not scheduling ensuring project for open files when there are no open files. In all those test cases there are no open files. Just external projects
amcasey reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit 2cc67ec into master Nov 19, 2020
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the ensureOpenProjects branch November 19, 2020 00:10
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh
1 more reviewer
@amcasey Andrew Casey (amcasey) amcasey approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @amcasey @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.