GeezerVison

Ryan Cavanaugh (@RyanCavanaugh) Let's sync tomorrow on the next steps for this work. I've done work on the VS Code side to pull in my forked typescript version (microsoft/vscode#102990) for web builds. This unblocks us but is only a short term workaround

My proposal is that during the start of TS 4.1 development, we collaborate on getting this PR merged into master. In order to keep package sizes down, I think we probably want to ship web support in tsserver.js instead of introducing a new tsserver.web.js. Once the PR is merged, VS Code could then pull the web server from master using nightly builds

Here's how to test these changes in a web build of VS Code:

• To build VS code's extensions for the web, simply run yarn watch-web in the VS Code codebase

• Start the web version of VS code with yarn web.

  Chrome or modern Edge works best for testing

• VS Code picks up the web version of tsserver from extensions/typescript-language-features/dist/browser/typescript-web

  By default, VS Code pulls in a prebuilt version of TypeScript using an npm install for git://github.com/mjbvz/ts-server-web-build

• To use your local build instead, build your local copy of TypeScript and then replace the tsserver.web.js file under dist/browser/typescript-web with your built one.

  You can also use a symbolic link so you can iterate more quickly on the TypeScript changes. On MacOS, the command to create this link this would be something like:

  ln -s ~/projects/typescript/built/local/tsserver.js \
      extensions/typescript-language-features/dist/browser/typescript-web/tsserver.web.js

• To make sure your linked TS version does not get replaced automatically on rebuild, comment out the two CopyPlugin parts of this webpack config

Sheetal Nandi (@sheetalkamat)

Looked at the changes and have updated them:
The things that we need to consider is how to find newLine, useCaseSensitive, readFile (will be needed for lib files in patial semantic mode.. I have gone through rest of the sys methods and have updated them/added comment accordingly. Have set things to some default for now and added TODOs
https://github.com/microsoft/TypeScript/pull/39656/files#diff-7703eaf5820d0a2af1ac3f7dde491b0aR54

newLine: "\r\n", // TODO::
            useCaseSensitiveFileNames: false, // TODO::
            readFile: returnUndefined, // TODO:: read lib Files

            write: postMessage,
            watchFile: returnNoopFileWatcher,
            watchDirectory: returnNoopFileWatcher,

            getExecutingFilePath: returnEmptyString, // TODO:: Locale, lib locations, typesmap location, plugins
            getCurrentDirectory: returnEmptyString, // For inferred project root if projectRoot path is not set, normalizing the paths

Sheetal Nandi (@sheetalkamat) Just pushed 6202c51 that enables support for loading the standard d.ts files that TypeScript ships with. I had to make some changes in editorServices.ts that I am not sure are correct.

The problem is that the standard library files have filenames such as http://localhost:8080/static/extensions/typescript-language-features/dist/browser/typescript-web/lib.dom.d.ts which were being ignored by the host. I don't know if the logic in editorServices needs to be updated or if we try changing the resolved file paths for the standard d.ts files

Sheetal Nandi (@sheetalkamat) Just pushed changes that enables TS Server logging on web. You'll also need to use the latest VS Code build from our main branch to use this

Right now the logger prints to the console. Here's what that looks like:

As you can see, not ideal for grouped messages but it gets the job done. Let me know if we should look into logging into a VS Code output window instead. For that, we'd likely want to post special logging messages back to VS Code that it can append onto the output

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Also, does this create a new output file? Should it?

My understanding is that the goal is to have tsserver.js support webWorker. The delta is not huge (15K) so seems like good option:

12/01/2020  06:26 PM         9,661,335 tsserver.js     <<< Built from master branch
12/01/2020  06:24 PM         9,677,119 tsserver.web.js << Built from this fork

Will let Ryan Cavanaugh (@RyanCavanaugh) Matt Bierner (@mjbvz) Daniel Rosenwasser (@DanielRosenwasser) Mine Starks (@minestarks) chime in their thoughts.