GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Editor support for link tag by sandersn · Pull Request #41877 · microsoft/TypeScript Conversation
|
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Matt Bierner (@mjbvz) and Andrew Casey (@amcasey), you should maybe also look at this (at least the protocol part) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
TypeScript Bot (@typescript-bot) pack this Only thing I’m curious about is if there are some places where JSDoc can go, but otherwise entity names could not go, and therefore might expose a hole in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at fce33f1. You can monitor the build here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Andrew Branch (@andrewbranch) I indeed tried writing more tests and discovered a hole. I'll put up a commit that makes getSymbolAtLocation work with identifiers in links. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The most recent commit avoids breaking VS, and I'm working on tests for all 4 possible combinations of the rich/full matrix. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This is ready for review now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The behavior and interface changes generally LGTM. Some suggestions below.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
1. Add a cross-file goto-def test. 2. Switch from per-message args to UserPreference.
|
I think this PR has had enough review to be ready to use. I'll merge it and address any follow-up in subsequent PRs. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Cool! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This reverts commit ec77bff.
|
Docs can be updated now https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Editor support for @see and {@link} in JSDoc comments tags
There was an error while loading. Please reload this page.