GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Intl.DisplayNames types by TimvdLippe · Pull Request #44022 · microsoft/TypeScript

Conversation

@TimvdLippe

@TimvdLippe Tim van der Lippe (TimvdLippe) commented May 10, 2021

Copy link
Copy Markdown
Contributor

The TC39 proposal (https://github.com/tc39/proposal-intl-displaynames)
reached stage 4 in September 2020.

Fixes #41338

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pokute, mhmdjaw, gurdiga, michaelbromley, lyyjohn45, shantanuraj, BenJenkinson, and oscar-b reacted with thumbs up emoji Pokute reacted with rocket emoji cmarker0 and priscilawebdev reacted with eyes emoji
All reactions
  • 👍 8 reactions
  • 🚀 1 reaction
  • 👀 2 reactions
@TimvdLippe
Add Intl.DisplayNames types
5616d77 
The TC39 proposal (https://github.com/tc39/proposal-intl-displaynames)
reached stage 4 in September 2020.

Fixes microsoft#41338
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 10, 2021
@sandersn
Nathan Shively-Sanders (sandersn) requested review from Orta Therox (orta) and Ron Buckton (rbuckton) May 18, 2021 23:38
@sandersn Nathan Shively-Sanders (sandersn) assigned Orta Therox (orta) May 18, 2021
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Daniel Rosenwasser (DanielRosenwasser) May 18, 2021 23:54
@sandersn

Nathan Shively-Sanders (sandersn) commented May 19, 2021

Copy link
Copy Markdown
Member

Daniel Rosenwasser (@DanielRosenwasser) you previously commented on #40786 saying that Intl is not part of the main TC39 spec, so in #40709 we added a property to NumberFormatOptions to ES5 instead of ES2020. Where does Intl.DisplayNames fall? How do I tell so I can review these PRs myself?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimvdLippe Tim van der Lippe (TimvdLippe) mentioned this pull request May 29, 2021
Intl.DisplayNames missing #41338
Closed
@TimvdLippe

Tim van der Lippe (TimvdLippe) commented Jun 28, 2021

Copy link
Copy Markdown
Contributor Author

Daniel Rosenwasser (@DanielRosenwasser) Friendly ping for the above question 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

In the meantime, a strange request but I'd prefer it to have less jsdoc information. We ship all of these dts files to consumers on npm and web which means we need to try keep the filesize somewhat reasonable and the dts files account for the many mbs which people have to download before anything can happen.

Any chance you can drop the @param info to just oneliners?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimvdLippe

Tim van der Lippe (TimvdLippe) commented Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

Orta Therox (@orta) I would absolutely love to, as it was an absolute pain to get all the formatting correct. However, a lot of the other types do have the JSDoc there. Therefore, does it make sense to first drop all of these and then we update existing PRs to also drop the information?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimvdLippe

Tim van der Lippe (TimvdLippe) commented Aug 29, 2021

Copy link
Copy Markdown
Contributor Author

Daniel Rosenwasser (@DanielRosenwasser) We would like to remove the local patch we have in DevTools. Could you please provide a status update for what we should do with shipping these internationalization type APIs?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Orta Therox (orta) added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
@orta
Adds Intl.DisplayNames to es2020 - re: microsoft#44022
2e2f755
@orta Orta Therox (orta) mentioned this pull request Aug 30, 2021
Intl 2021 Updates #45647
Merged
Orta Therox (orta) pushed a commit that referenced this pull request Sep 8, 2021
Orta Therox @sandersn
Intl 2021 Updates (#45647)
07fd7bc 
* Import of Intl.Locale from #39664

* Handle updating es2020.intl and add es2021 for new DateTimeFormatOptions options - re: #39664

* Extends DateTimeFormatOptions for new Intl APIs - re: #45420

* Handle migrating Intl.NumberFormat.formatToParts to es2018 (keeping esnext.intl around)

* Adds Intl.DisplayNames to es2020 - re: #44022

* Remove attributes added in es2021 from es2020 - re: #42944

* Add a reference to es2021 in the command line parser

* Adds some docs about the lib files

* Baselines

* Allow undefined in Intl inputs to allow for ergonomic usage of exactOptionalPropertyTypes - see #45652

* Adds some tests covering the APIs

* Apply suggestions from code review

Co-authored-by: Nathan Shively-Sanders <[email protected]>

* Handle PR feedback

* More review improvements

Co-authored-by: Nathan Shively-Sanders <[email protected]>
@orta

Orta Therox (orta) commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR, I've merged these changes in with a big overhaul of all Intl APIs for 4.5 - #45647
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta Orta Therox (orta) closed this Sep 8, 2021
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@orta Orta Therox (orta) Awaiting requested review from orta
@rbuckton Ron Buckton (rbuckton) Awaiting requested review from rbuckton
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@orta Orta Therox (orta)

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intl.DisplayNames missing

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TimvdLippe @sandersn @orta @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.