GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Increase type instantiation depth limit by ahejlsberg · Pull Request #45025 · microsoft/TypeScript

Conversation

Anders Hejlsberg (ahejlsberg) commented Jul 14, 2021

Copy link

Copy Markdown

Member

This PR increases the type instantiation depth limit from 50 to 500. Resolution of recursive types (such as conditional types and indexed access types) can cause deeply nested invocations in the type instantiation logic of the compiler, which may ultimately cause stack overflows during compilation. For this reason we limit nested invocations of the instantiateType function, reporting a "Type instantiation is excessively deep and possibly infinite" error when the limit is reached. The current limit of 50 is generally reasonable, but in some scenarios involving tuple types and template literal types it is quickly reached. For example, the type

type GetChars<S> = S extends `${infer Char}${infer Rest}` ? Char | GetChars<Rest> : never;

extracts a union of the single characters in a literal string and reaches the instantiation depth limit after just 24 characters (each level of recursion involves two invocations of instantiateType). Likewise, utility types to manipulate tuple types often suffer from the same restrictions. It is sometimes possible to "batch process" multiple constituents at once, as in

type GetChars<S> =
    S extends `${infer C1}${infer C2}${infer C3}${infer C4}${infer Rest}` ? C1 | C2 | C3 | C4 | GetChars<Rest> :
    S extends `${infer C1}${infer Rest}` ? C1 | GetChars<Rest> : never;

but this is cumbersome and often too complex.

Since the instantiation depth limit is a reasonable approximation of call stack depth in the compiler, if we assume each recursive instantiateType call involves 5 stack frames and each stack frame consumes 100 bytes, then 500 levels of recursion roughly corresponds to 250K bytes, which is 25-50% of the default stack size in Node.js. That seems appropriate.

It's been suggested we make the depth limit configurable through a compiler option. I remain opposed to that as it is ultimately an implementation detail of the compiler that very well could change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dan-dr, SancheZz, kiprasmel, jcalz, colinhacks, alii, ven, zyhou, rearchontis, callmeberzerker, and 5 more reacted with thumbs up emoji

olivermrose, k-tten, karol-majewski, Merlin04, anthonyjoeseph, colinhacks, ven, and OliverJAsh reacted with laugh emoji

g-plane, lideming, tjjfvi, AnyhowStep, olivermrose, brage-andreas, timvandam, k-tten, SancheZz, treybrisbane, and 11 more reacted with hooray emoji

Jack-Works, septs, lideming, tjjfvi, AnyhowStep, brage-andreas, 0kku, k-tten, gogoyqj, tonivj5, and 17 more reacted with heart emoji

AnyhowStep, k-tten, tonivj5, Beraliv, Igorbek, Merlin04, c69-addepar, anthonyjoeseph, KisaragiEffective, jcalz, and 5 more reacted with rocket emoji

All reactions

👍 15 reactions
😄 8 reactions
🎉 21 reactions
❤️ 27 reactions
🚀 15 reactions

Anders Hejlsberg (ahejlsberg) added 2 commits

July 14, 2021 07:24


          Bump instantiation depth limit to 500

16fea3e


          Accept new baselines

4f79295

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg)

Jul 14, 2021

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels

Jul 14, 2021

Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser), Ryan Cavanaugh (RyanCavanaugh) and Wesley Wigham (weswigham)

July 14, 2021 14:56

Daniel Rosenwasser (DanielRosenwasser) reviewed

Jul 14, 2021

View reviewed changes

Comment thread

tests/baselines/reference/recursiveConditionalTypes.errors.txt Outdated

		@@ -85,8 +84,6 @@ tests/cases/compiler/recursiveConditionalTypes.ts(116,9): error TS2345: Argument
		type TT2 = TupleOf<number, number>;
		type TT3 = TupleOf<number, any>;
		type TT4 = TupleOf<number, 100>; // Depth error

Daniel Rosenwasser (DanielRosenwasser) Jul 14, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in tests/cases/compiler/recursiveConditionalTypes.ts will need to be amended.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Daniel Rosenwasser (DanielRosenwasser) commented Jul 14, 2021

Copy link

Copy Markdown

Member

TypeScript Bot (@typescript-bot) pack this
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 4f79295. You can monitor the build here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 4f79295. You can monitor the build here.

Update: The results are in!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at 4f79295. You can monitor the build here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at 4f79295. You can monitor the build here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at 4f79295. You can monitor the build here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AnyhowStep commented Jul 14, 2021

Copy link

Copy Markdown

Contributor

I love you

colinhacks, alii, ven, thelinuxlich, and strblr reacted with thumbs up emoji

DanielRosenwasser, 0kku, dsherret, tonivj5, Merlin04, yozohu, colinhacks, 3jins, and lidaze reacted with laugh emoji

vuaaaaaaaaaaax, 0kku, Merlin04, and colinhacks reacted with hooray emoji

yozohu, Beraliv, colinhacks, alii, mdkmridul, klesun, and jan-wilhelm reacted with heart emoji

All reactions

👍 5 reactions
😄 9 reactions
🎉 4 reactions
❤️ 7 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/106764/artifacts?artifactName=tgz&fileId=5C079C6A6740444AA1A534C55FECB56270903505B9A9A29E546161CE9AEA0C6402&fileName=/typescript-4.4.0-insiders.20210714.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) mentioned this pull request

Jul 14, 2021

🤖 User test baselines have changed for increaseInstantiationDepth typescript-bot/TypeScript#192

Open

TypeScript Bot (typescript-bot) commented Jul 14, 2021

Copy link

Copy Markdown

Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021

Copy link

Copy Markdown

Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..45025

_Metric	_main	₄₅₀₂₅	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{343,509k (± 0.03%)}	_{343,514k (± 0.02%)}	_{+5k (+ 0.00%)}	_343,366k	_343,714k
_{Parse Time}	_{1.79s (± 0.45%)}	_{1.80s (± 0.50%)}	_{+0.01s (+ 0.39%)}	_1.78s	_1.82s
_{Bind Time}	_{0.85s (± 1.11%)}	_{0.84s (± 0.66%)}	_{-0.01s (- 0.59%)}	_0.83s	_0.86s
_{Check Time}	_{5.34s (± 0.49%)}	_{5.33s (± 0.56%)}	_{-0.01s (- 0.13%)}	_5.27s	_5.39s
_{Emit Time}	_{5.85s (± 0.53%)}	_{5.81s (± 0.49%)}	_{-0.04s (- 0.70%)}	_5.74s	_5.87s
_{Total Time}	_{13.83s (± 0.36%)}	_{13.78s (± 0.37%)}	_{-0.05s (- 0.34%)}	_13.64s	_13.87s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{201,233k (± 0.02%)}	_{201,207k (± 0.04%)}	_{-26k (- 0.01%)}	_201,035k	_201,388k
_{Parse Time}	_{0.78s (± 0.90%)}	_{0.78s (± 0.60%)}	_{-0.00s (- 0.13%)}	_0.77s	_0.79s
_{Bind Time}	_{0.52s (± 1.30%)}	_{0.53s (± 1.14%)}	_{+0.00s (+ 0.19%)}	_0.51s	_0.54s
_{Check Time}	_{7.81s (± 0.61%)}	_{7.81s (± 0.65%)}	_{+0.00s (+ 0.05%)}	_7.70s	_7.93s
_{Emit Time}	_{2.45s (± 0.90%)}	_{2.44s (± 0.56%)}	_{-0.01s (- 0.49%)}	_2.41s	_2.47s
_{Total Time}	_{11.57s (± 0.56%)}	_{11.56s (± 0.49%)}	_{-0.01s (- 0.09%)}	_11.41s	_11.68s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{340,460k (± 0.02%)}	_{340,446k (± 0.02%)}	_{-14k (- 0.00%)}	_340,273k	_340,624k
_{Parse Time}	_{1.45s (± 0.60%)}	_{1.46s (± 0.68%)}	_{+0.01s (+ 0.41%)}	_1.43s	_1.48s
_{Bind Time}	_{0.75s (± 0.91%)}	_{0.75s (± 0.53%)}	_{+0.00s (+ 0.67%)}	_0.74s	_0.76s
_{Check Time}	_{5.38s (± 0.57%)}	_{5.35s (± 0.52%)}	_{-0.03s (- 0.52%)}	_5.28s	_5.42s
_{Emit Time}	_{3.15s (± 1.03%)}	_{3.16s (± 1.34%)}	_{+0.01s (+ 0.29%)}	_3.10s	_3.27s
_{Total Time}	_{10.73s (± 0.49%)}	_{10.72s (± 0.54%)}	_{-0.01s (- 0.07%)}	_10.64s	_10.86s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{303,771k (± 0.02%)}	_{303,819k (± 0.02%)}	_{+48k (+ 0.02%)}	_303,671k	_303,973k
_{Parse Time}	_{1.18s (± 0.40%)}	_{1.18s (± 0.47%)}	_{+0.00s (+ 0.17%)}	_1.17s	_1.20s
_{Bind Time}	_{0.71s (± 0.69%)}	_{0.71s (± 0.48%)}	_{-0.01s (- 0.98%)}	_0.70s	_0.71s
_{Check Time}	_{4.89s (± 0.33%)}	_{4.88s (± 0.56%)}	_{-0.01s (- 0.10%)}	_4.82s	_4.94s
_{Emit Time}	_{3.33s (± 1.00%)}	_{3.33s (± 1.22%)}	_{+0.00s (+ 0.12%)}	_3.23s	_3.40s
_{Total Time}	_{10.11s (± 0.41%)}	_{10.10s (± 0.61%)}	_{-0.01s (- 0.10%)}	_9.98s	_10.21s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{469,650k (± 0.01%)}	_{469,619k (± 0.02%)}	_{-31k (- 0.01%)}	_469,498k	_469,861k
_{Parse Time}	_{1.73s (± 0.74%)}	_{1.73s (± 0.54%)}	_{0.00s ( 0.00%)}	_1.70s	_1.74s
_{Bind Time}	_{0.67s (± 0.89%)}	_{0.67s (± 1.29%)}	_{+0.01s (+ 0.90%)}	_0.66s	_0.69s
_{Check Time}	_{14.17s (± 0.49%)}	_{14.16s (± 0.43%)}	_{-0.01s (- 0.04%)}	_14.05s	_14.34s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.57s (± 0.46%)}	_{16.56s (± 0.42%)}	_{-0.00s (- 0.02%)}	_16.43s	_16.77s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{321,697k (± 0.03%)}	_{321,646k (± 0.02%)}	_{-51k (- 0.02%)}	_321,489k	_321,826k
_{Parse Time}	_{1.78s (± 0.62%)}	_{1.78s (± 0.60%)}	_{+0.00s (+ 0.06%)}	_1.77s	_1.81s
_{Bind Time}	_{0.83s (± 1.02%)}	_{0.82s (± 0.75%)}	_{-0.01s (- 0.97%)}	_0.81s	_0.83s
_{Check Time}	_{5.18s (± 0.49%)}	_{5.18s (± 0.54%)}	_{-0.00s (- 0.10%)}	_5.12s	_5.23s
_{Emit Time}	_{6.03s (± 0.43%)}	_{6.02s (± 0.67%)}	_{-0.01s (- 0.20%)}	_5.95s	_6.12s
_{Total Time}	_{13.83s (± 0.39%)}	_{13.80s (± 0.44%)}	_{-0.02s (- 0.15%)}	_13.68s	_13.98s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{188,688k (± 0.02%)}	_{188,676k (± 0.09%)}	_{-12k (- 0.01%)}	_188,057k	_188,977k
_{Parse Time}	_{0.78s (± 0.63%)}	_{0.77s (± 0.68%)}	_{-0.01s (- 0.90%)}	_0.76s	_0.78s
_{Bind Time}	_{0.53s (± 0.92%)}	_{0.54s (± 0.92%)}	_{+0.00s (+ 0.37%)}	_0.53s	_0.55s
_{Check Time}	_{7.34s (± 0.79%)}	_{7.32s (± 0.79%)}	_{-0.02s (- 0.22%)}	_7.22s	_7.45s
_{Emit Time}	_{2.42s (± 0.97%)}	_{2.44s (± 0.76%)}	_{+0.02s (+ 0.70%)}	_2.41s	_2.49s
_{Total Time}	_{11.07s (± 0.66%)}	_{11.07s (± 0.60%)}	_{-0.00s (- 0.02%)}	_10.94s	_11.18s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{323,640k (± 0.01%)}	_{323,611k (± 0.02%)}	_{-29k (- 0.01%)}	_323,494k	_323,713k
_{Parse Time}	_{1.42s (± 0.78%)}	_{1.42s (± 0.48%)}	_{-0.01s (- 0.49%)}	_1.40s	_1.43s
_{Bind Time}	_{0.73s (± 0.65%)}	_{0.72s (± 0.80%)}	_{-0.01s (- 0.96%)}	_0.71s	_0.74s
_{Check Time}	_{5.24s (± 0.62%)}	_{5.21s (± 0.26%)}	_{-0.03s (- 0.53%)}	_5.18s	_5.25s
_{Emit Time}	_{3.16s (± 0.61%)}	_{3.17s (± 0.96%)}	_{+0.00s (+ 0.16%)}	_3.13s	_3.27s
_{Total Time}	_{10.55s (± 0.48%)}	_{10.52s (± 0.29%)}	_{-0.03s (- 0.31%)}	_10.47s	_10.63s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{288,573k (± 0.02%)}	_{288,541k (± 0.02%)}	_{-32k (- 0.01%)}	_288,395k	_288,687k
_{Parse Time}	_{1.19s (± 0.80%)}	_{1.19s (± 0.63%)}	_{-0.01s (- 0.59%)}	_1.18s	_1.21s
_{Bind Time}	_{0.69s (± 1.09%)}	_{0.70s (± 0.71%)}	_{+0.00s (+ 0.14%)}	_0.69s	_0.71s
_{Check Time}	_{4.81s (± 0.39%)}	_{4.81s (± 0.41%)}	_{-0.00s (- 0.02%)}	_4.76s	_4.86s
_{Emit Time}	_{3.33s (± 0.55%)}	_{3.36s (± 0.53%)}	_{+0.03s (+ 0.87%)}	_3.32s	_3.40s
_{Total Time}	_{10.03s (± 0.29%)}	_{10.05s (± 0.31%)}	_{+0.02s (+ 0.20%)}	_9.97s	_10.11s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{448,306k (± 0.07%)}	_{448,383k (± 0.01%)}	_{+78k (+ 0.02%)}	_448,249k	_448,451k
_{Parse Time}	_{1.72s (± 0.43%)}	_{1.72s (± 0.59%)}	_{-0.00s (- 0.06%)}	_1.70s	_1.74s
_{Bind Time}	_{0.65s (± 0.69%)}	_{0.65s (± 0.72%)}	_{+0.00s (+ 0.31%)}	_0.64s	_0.66s
_{Check Time}	_{12.77s (± 0.95%)}	_{12.75s (± 0.56%)}	_{-0.02s (- 0.15%)}	_12.59s	_12.89s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.13s (± 0.79%)}	_{15.12s (± 0.54%)}	_{-0.01s (- 0.09%)}	_14.94s	_15.27s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{320,219k (± 0.01%)}	_{320,222k (± 0.01%)}	_{+3k (+ 0.00%)}	_320,166k	_320,256k
_{Parse Time}	_{1.81s (± 0.99%)}	_{1.80s (± 0.74%)}	_{-0.01s (- 0.39%)}	_1.78s	_1.83s
_{Bind Time}	_{0.88s (± 0.57%)}	_{0.87s (± 0.68%)}	_{-0.00s (- 0.11%)}	_0.86s	_0.89s
_{Check Time}	_{5.20s (± 0.57%)}	_{5.19s (± 0.16%)}	_{-0.01s (- 0.12%)}	_5.18s	_5.22s
_{Emit Time}	_{6.16s (± 0.64%)}	_{6.11s (± 0.60%)}	_{-0.05s (- 0.80%)}	_5.98s	_6.16s
_{Total Time}	_{14.04s (± 0.48%)}	_{13.98s (± 0.36%)}	_{-0.07s (- 0.47%)}	_13.82s	_14.09s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,578k (± 0.58%)}	_{188,420k (± 0.69%)}	_{-1,158k (- 0.61%)}	_186,344k	_190,583k
_{Parse Time}	_{0.80s (± 0.61%)}	_{0.80s (± 1.18%)}	_{+0.00s (+ 0.00%)}	_0.79s	_0.84s
_{Bind Time}	_{0.56s (± 0.65%)}	_{0.56s (± 1.10%)}	_{-0.00s (- 0.53%)}	_0.55s	_0.58s
_{Check Time}	_{7.46s (± 0.57%)}	_{7.53s (± 0.48%)}	_{+0.07s (+ 0.88%)}	_7.45s	_7.59s
_{Emit Time}	_{2.42s (± 0.55%)}	_{2.46s (± 1.29%)}	_{+0.04s (+ 1.74%)}	_2.40s	_2.53s
_{Total Time}	_{11.24s (± 0.47%)}	_{11.35s (± 0.36%)}	_{+0.11s (+ 0.94%)}	_11.26s	_11.49s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{322,367k (± 0.01%)}	_{322,364k (± 0.00%)}	_{-3k (- 0.00%)}	_322,342k	_322,383k
_{Parse Time}	_{1.49s (± 0.89%)}	_{1.48s (± 0.71%)}	_{-0.01s (- 0.67%)}	_1.46s	_1.51s
_{Bind Time}	_{0.75s (± 0.69%)}	_{0.75s (± 1.00%)}	_{+0.00s (+ 0.40%)}	_0.74s	_0.77s
_{Check Time}	_{5.20s (± 0.57%)}	_{5.20s (± 0.50%)}	_{-0.01s (- 0.15%)}	_5.15s	_5.26s
_{Emit Time}	_{3.20s (± 0.59%)}	_{3.21s (± 0.70%)}	_{+0.01s (+ 0.31%)}	_3.16s	_3.28s
_{Total Time}	_{10.64s (± 0.32%)}	_{10.64s (± 0.48%)}	_{0.00s ( 0.00%)}	_10.53s	_10.77s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{287,540k (± 0.01%)}	_{287,547k (± 0.01%)}	_{+7k (+ 0.00%)}	_287,499k	_287,605k
_{Parse Time}	_{1.26s (± 1.56%)}	_{1.25s (± 0.75%)}	_{-0.01s (- 0.56%)}	_1.23s	_1.27s
_{Bind Time}	_{0.72s (± 0.80%)}	_{0.72s (± 0.51%)}	_{-0.00s (- 0.56%)}	_0.71s	_0.72s
_{Check Time}	_{4.83s (± 0.51%)}	_{4.86s (± 0.46%)}	_{+0.03s (+ 0.54%)}	_4.82s	_4.92s
_{Emit Time}	_{3.41s (± 0.76%)}	_{3.46s (± 0.90%)}	_{+0.05s (+ 1.41%)}	_3.40s	_3.54s
_{Total Time}	_{10.22s (± 0.48%)}	_{10.29s (± 0.46%)}	_{+0.06s (+ 0.62%)}	_10.21s	_10.43s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{446,768k (± 0.00%)}	_{446,769k (± 0.01%)}	_{+1k (+ 0.00%)}	_446,665k	_446,796k
_{Parse Time}	_{1.76s (± 0.64%)}	_{1.76s (± 0.56%)}	_{+0.00s (+ 0.17%)}	_1.74s	_1.78s
_{Bind Time}	_{0.69s (± 0.65%)}	_{0.69s (± 0.81%)}	_{-0.00s (- 0.00%)}	_0.68s	_0.70s
_{Check Time}	_{12.95s (± 0.70%)}	_{12.90s (± 0.33%)}	_{-0.05s (- 0.42%)}	_12.80s	_13.00s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.40s (± 0.56%)}	_{15.35s (± 0.29%)}	_{-0.05s (- 0.32%)}	_15.25s	_15.45s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-206-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₅₀₂₅	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Anders Hejlsberg (ahejlsberg) commented Jul 14, 2021

Copy link

Copy Markdown

Member Author

Tests and performance are unaffected, as expected. The only possible causes for concern with this change are (1) stack overflows could occur if each recursive invocation of instantiateType consumes more stack space than we have estimated, and (2) because we permit 10x more recursive invocations, it takes longer to report "Type instantiation is excessively deep..." errors, which may make language services less responsive.

AnyhowStep reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Anders Hejlsberg (ahejlsberg) added 2 commits

July 14, 2021 13:30


          Update tests

62efc71


          Accept new baselines

d89a9bc

Wesley Wigham (weswigham) approved these changes

Jul 14, 2021

View reviewed changes

Wesley Wigham (weswigham) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's harder to make this number smaller rather than larger, so we really should be sure that we won't stack overflow with 500 in any cases, since adjusting it down if we are is going to be way breakier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AnyhowStep and MartinJohns reacted with thumbs up emoji

All reactions

👍 2 reactions

jjangga0214 commented Jul 15, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Thanks for the attention to the issue :)

Wesley Wigham (@weswigham)

It's harder to make this number smaller rather than larger,

I believe this is one of the strengths of configurable depth limit/count. Maintainers would be able to modify the default values progressively, in more freedom without too much worry.

Anders Hejlsberg (@ahejlsberg)

It's been suggested we make the depth limit configurable through a compiler option. I remain opposed to that as it is ultimately an implementation detail of the compiler that very well could change.

I understand that change of implementation detail might require breaking change of configuration.
What about taking some time to think and fix the newly exposed configuration?
I believe, with thorough care, it can be stabilized someday.

So I suggest introducing experimental configuration and stabilizing it later.

500 levels of recursion roughly corresponds to 250K bytes, which is 25-50% of the default stack size in Node.js. That seems appropriate.

This is where configurations resolve uncertainty. When people don't use the default stack size(larger/smaller), they would also naturally want to configure tsc's recursive limit, by their own free decision.

klesun reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jjangga0214 commented Jul 15, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

MEMO: relation with #34933 and #44997

This issue(#45025) is related to #34933, but does not resolve it. This is because there can be (theoretically) already published (including famous libraries) codes which even the increased limit(500 depth) cannot cover (e.g. needs 505 depth, 570 depth).
To fully resolve this broken ecosystem, the limitations should be configurable(#44997), I believe.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request

Jul 19, 2021

Design Meeting Notes, 7/14/2021 #45104

Closed

orouz mentioned this pull request

Aug 11, 2021

Mapped Type + Recursive Type = Type instantiation is excessively deep and possibly infinite (2589) #45411

Closed

jjangga0214 mentioned this pull request

Aug 14, 2021

feat(compilerOption): add instantiationDepthLimit and instantiationCountLimit #44997

Closed

Nathan Shively-Sanders (sandersn) commented Aug 16, 2021

Copy link

Copy Markdown

Member

Wesley Wigham (@weswigham) Anders Hejlsberg (@ahejlsberg) Now that 4.5 development has started, is this ready to merge, or does the number need more experimentation?

(I'm leaning toward merging given our design meeting discussion.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Anders Hejlsberg (ahejlsberg) merged commit 79474fd into main

Aug 17, 2021

Anders Hejlsberg (ahejlsberg) deleted the increaseInstantiationDepth branch

August 17, 2021 14:00

Colin McDonnell (colinhacks) commented Aug 18, 2021

Copy link

Copy Markdown

Contributor

AnyhowStep Time to throw the party you've been planning since 2019 😝

alii, Beraliv, and tonivj5 reacted with thumbs up emoji

alii and tonivj5 reacted with laugh emoji

All reactions

👍 3 reactions
😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Markus Ylisiurunen (markusylisiurunen) mentioned this pull request

Aug 20, 2021

TypeScript throwing a "Type instantiation is excessively deep and possibly infinite" error runtypes/runtypes#212

Closed

Adam Thomas (adam-thomas-privitar) mentioned this pull request

Aug 24, 2021

Chakra does not compile with latest Typescript 4.3.x: Type instantiation is excessively deep chakra-ui/chakra-ui#4226

Closed

Anders Hejlsberg (ahejlsberg) mentioned this pull request

Sep 3, 2021

Tail recursive evaluation of conditional types #45711

Merged

Nathan Shively-Sanders (sandersn) mentioned this pull request

Oct 7, 2021

flag to customize type instantiation depth limit #46180

Closed

5 tasks done

Maik Riechert (letmaik) mentioned this pull request

Oct 19, 2021

Upgrading to 1.6.x causes "Type instantiation is excessively deep and possibly infinite" errors ThomasAribart/json-schema-to-ts#43

Closed

Cassandra Choi (BobobUnicorn) pushed a commit to BobobUnicorn/TypeScript that referenced this pull request

Oct 24, 2021


          Increase type instantiation depth limit (microsoft#45025)

5f99e87

* Bump instantiation depth limit to 500

* Accept new baselines

* Update tests

* Accept new baselines

Alisson Cavalcante Agiani (thelinuxlich) commented Dec 8, 2022

Copy link

Copy Markdown

What happened to this fix?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Alisson Cavalcante Agiani (thelinuxlich) mentioned this pull request

Dec 8, 2022

With a schema definition of 93 routes, I got "Type instantiation is excessively deep and possibly infinite" ecyrbe/zodios#256

Closed

Dragon-Hatcher commented Jun 24, 2023

Copy link

Copy Markdown

What happened to this fix?

It was reverted in #45711 and was replaced with a tail recursion strategy.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Microsoft (microsoft) locked as resolved and limited conversation to collaborators

Oct 21, 2025

Reviewers

Daniel Rosenwasser (DanielRosenwasser)

DanielRosenwasser left review comments

Wesley Wigham (weswigham)

weswigham approved these changes

Ryan Cavanaugh (RyanCavanaugh)

Awaiting requested review from RyanCavanaugh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Anders Hejlsberg (ahejlsberg)

Labels

Author: Team For Uncommitted Bug

PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Anders Hejlsberg (ahejlsberg) commented Jul 14, 2021

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Jul 14, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnyhowStep commented Jul 14, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 14, 2021

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Jul 14, 2021

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

jjangga0214 commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjangga0214 commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Aug 16, 2021

Uh oh!

Colin McDonnell (colinhacks) commented Aug 18, 2021

Uh oh!

Alisson Cavalcante Agiani (thelinuxlich) commented Dec 8, 2022

Uh oh!

Dragon-Hatcher commented Jun 24, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jul 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

jjangga0214 commented Jul 15, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

jjangga0214 commented Jul 15, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.