GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adds more Intl.ResolvedDateTimeFormatOptions, and hooks up Intl for ES2021 by orta · Pull Request #45905 · microsoft/TypeScript

Conversation

@orta

@orta Orta Therox (orta) commented Sep 16, 2021

Copy link
Copy Markdown
Contributor
  1. Looks like if you were on target: es2021 the file es2021.intl wasn't added to your globals, so some of Intl 2021 Updates #45647 wasn't applied
  2. I added the properties raised in Intl.ResolvedDateTimeFormatOptions is missing properties #45420

fixes #45420

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
IllusionMH and zombieleet reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@typescript-bot TypeScript Bot (typescript-bot) assigned Orta Therox (orta) Sep 16, 2021
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Backlog Bug PRs that fix a backlog bug labels Sep 16, 2021
@orta
Orta Therox (orta) force-pushed the 2021_intl branch 2 times, most recently from 6d680ff to c2db6bf Compare September 16, 2021 10:44
@orta

Orta Therox (orta) commented Sep 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

https://github.com/vercel/ms just got updated to typescript which is what is causing the reds - will make a separate PR for it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta Orta Therox (orta) mentioned this pull request Sep 16, 2021
Fix main by using '.default' on the new ms release #45910
Merged
Orta Therox (orta) added 2 commits September 17, 2021 12:13
@orta
Adds more ResolvedDateTimeFormatOptions to the Intl APIs
89b9879
@orta
Fix tests
8c60480
@orta
Orta Therox (orta) force-pushed the 2021_intl branch from c2db6bf to 8c60480 Compare September 17, 2021 11:14
@orta
Orta Therox (orta) requested review from Andrew Branch (andrewbranch) and Nathan Shively-Sanders (sandersn) September 17, 2021 12:40
andrewbranch
Andrew Branch (andrewbranch) approved these changes Sep 23, 2021
View reviewed changes
@orta
Orta Therox (orta) merged commit 61d2939 into microsoft:main Sep 23, 2021
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes
@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@orta Orta Therox (orta)

Labels

Author: Team For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intl.ResolvedDateTimeFormatOptions is missing properties

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@orta @andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.