GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix main by using '.default' on the new ms release by orta · Pull Request #45910 · microsoft/TypeScript

Conversation

@orta

@orta Orta Therox (orta) commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Fixes main - because we update the lockfile, we now use ms v3 which is re-written in TypeScript but has a different export style.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orta
Fix main by using '.default' on the new ms release
c20e665
@typescript-bot TypeScript Bot (typescript-bot) assigned Orta Therox (orta) Sep 16, 2021
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 16, 2021
@orta

Orta Therox (orta) commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

should unblock #45905
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Sep 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Hrm, looks like it ships ?. in JS which isn't as backwards compatible as our CI - maybe I should just lock it to v2 instead
andrewbranch reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Orta Therox (orta) added 3 commits September 16, 2021 16:56
@orta
Lock to v2
5b6f39b
@orta
Update v1 lockfile
1652936
@orta
Revert code change
aa99b97
@andrewbranch
Andrew Branch (andrewbranch) merged commit b250f0c into microsoft:main Sep 16, 2021
@andrewbranch

Andrew Branch (andrewbranch) commented Sep 16, 2021

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@orta Orta Therox (orta)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@orta @andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.