GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(27615): fixAddMissingMember should work for type literal by a-tarasyuk · Pull Request #47212 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Fixes #27615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Dec 21, 2021
@sandersn
Nathan Shively-Sanders (sandersn) requested review from Gabriela Araujo Britto (gabritto) and Nathan Shively-Sanders (sandersn) and removed request for Nathan Shively-Sanders (sandersn) February 16, 2022 00:01
@sandersn Nathan Shively-Sanders (sandersn) assigned Gabriela Araujo Britto (gabritto) Feb 16, 2022
gabritto
Gabriela Araujo Britto (gabritto) reviewed Mar 30, 2022
View reviewed changes
Comment thread src/services/textChanges.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/helpers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/fixAddMissingMember.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gabritto

Gabriela Araujo Britto (gabritto) commented Mar 30, 2022

Copy link
Copy Markdown
Member

The original issue (#27615) said "this should work with types defined in jsdoc syntax", but from looking at the code in the codefix, I'm not sure if that could go in the same PR or would be better left separate. Oleksandr Tarasiuk (@a-tarasyuk) Nathan Shively-Sanders (@sandersn) what do you think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
feat(27615): Add missing member fix should work for type literals
692bf5e
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/27615 branch from 452fe0d to 692bf5e Compare March 30, 2022 09:44
@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 30, 2022

Copy link
Copy Markdown
Contributor Author

Gabriela Araujo Britto (@gabritto) Thanks for the review. You are right, all actions in fixAddMissingMember don't support JSDoc. I would divide adding JSDoc support into new issue/PR.
sandersn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Gabriela Araujo Britto (gabritto) March 30, 2022 10:47
gabritto
Gabriela Araujo Britto (gabritto) approved these changes Mar 30, 2022
View reviewed changes

@gabritto Gabriela Araujo Britto (gabritto) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gabritto
Gabriela Araujo Britto (gabritto) merged commit c639d3a into microsoft:main Mar 30, 2022
Sidharth Vinod (sidharthv96) added a commit to sidharthv96/TypeScript that referenced this pull request Apr 1, 2022
@sidharthv96
Merge remote-tracking branch 'upstream/main' into fix/46149
e149cc3 
* upstream/main: (473 commits)
  Correct node used for isDefinition calculation (microsoft#48499)
  fix(48405): emit dummy members from a mapped type (microsoft#48481)
  CFA for dependent parameters typed by generic constraints (microsoft#48411)
  No contextual typing from return types for boolean literals (microsoft#48380)
  fix(47733): omit JSDoc comment template suggestion on node with existing JSDoc (microsoft#47748)
  Ensure that we copy empty NodeArrays during transform (microsoft#48490)
  Add a new compiler option `moduleSuffixes` to expand the node module resolver's search algorithm (microsoft#48189)
  feat(27615): Add missing member fix should work for type literals (microsoft#47212)
  Add label details to completion entry (microsoft#48429)
  Enable method signature completion for object literals (microsoft#48168)
  Fix string literal completions when a partially-typed string fixes inference to a type parameter (microsoft#48410)
  fix(48445): show errors on type-only import/export specifiers in JavaScript files (microsoft#48449)
  Fix newline inserted in empty block at end of formatting range (microsoft#48463)
  Prevent looking up symbol for as const from triggering an error (microsoft#48464)
  Revise accessor resolution logic and error reporting (microsoft#48459)
  fix(48166): skip checking module.exports in a truthiness call expression (microsoft#48337)
  LEGO: Merge pull request 48450
  LEGO: Merge pull request 48436
  fix(48031): show circularity error for self referential get accessor annotations (microsoft#48050)
  Revert "Fix contextual discrimination for omitted members (microsoft#43937)" (microsoft#48426)
  ...
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gabritto Gabriela Araujo Britto (gabritto) gabritto approved these changes
@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gabritto Gabriela Araujo Britto (gabritto)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fixAddMissingMember should work for type literal

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@a-tarasyuk @gabritto @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.