GeezerVison

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary

One case to consider as we think about how this functionality should be triggered is what ctrl-click should do.

TypeScript Bot (@typescript-bot) pack this

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at 34c6cfd. You can monitor the build here.

Latest commits

• make _./*|*/add work when _ itself can only be resolved with heuristics
• rename the command FindSourceDefinition, dropping the bound span part of the response as it’s not needed.

Could we expose findSourceDefinition for language service API to make it available for LSP?

Unfortunately not—if you look at the implementation here, Find Source Definition happens by orchestrating multiple different language services to call Go To Definition with different module resolution options. What are you hoping to integrate it into?

Andrew Branch (@andrewbranch) I hope it can use in embedded typescript language for Vue. (For example: https://github.com/johnsoncodehk/volar-starter/blob/e4f6d9808181f4533811c1aafc4b6afea1f68598/src/components/HelloWorld.vue#L26-L30)

For Go to Definition and Go to Type Definition features, I using getDefinitionAndBoundSpan and getTypeDefinitionAtPosition API of TS language service implemented.

• https://github.com/johnsoncodehk/volar/blob/90d370e82817afe011c8b8bd0a7d645464d45101/packages/typescript-language-service/src/services/definition.ts#L21
• https://github.com/johnsoncodehk/volar/blob/90d370e82817afe011c8b8bd0a7d645464d45101/packages/typescript-language-service/src/services/typeDefinition.ts#L20

I'm also expected a new getSourceDefinitionAndBoundSpan or getSourceDefinitionAtPosition API.

(btw Go to Source Definition is not specification of LSP, so I need to implement it bypass LSP.)

It’s simply not possible to put this functionality on the LanguageService object (or, it would be a significant violation of the LS’s scope of concerns). At minimum you would need to create a second language service (which creates a second Program and TypeChecker!). It would take a bit of work on our end to abstract what I put directly into TS Server into some kind of public API that could be used independently of the project system. This is an experimental API so it’s not going to happen right now, but if you want to open a new suggestion issue for doing this, we’ll keep an eye on it and could discuss some of the design challenges. Thanks!

At minimum you would need to create a second language service (which creates a second Program and TypeChecker!).

Actually this is absolutely acceptable 😅, we already have multiple language server & language service instances in order to prevent auto-complete request from being blocked by unfinished diagnostics request. (vuejs/language-tools#393 (reply in thread))

Great to see it experimentally added to the language service API, this feature will be very welcome in the Vue community, it solves some common DX issues in Vue projects (For example: vuejs/language-tools#1226). It doesn't matter if it will be removed anytime in the future, I can adapt the code quickly.

if you want to open a new suggestion issue for doing this, we’ll keep an eye on it and could discuss some of the design challenges.

Of course, thanks in advance!