GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(48487): "Unexpected PrivateIdentifier in name expression with literal-like access" being hit by a-tarasyuk · Pull Request #48496 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Fixes #48487

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn) Mar 31, 2022
@typescript-bot TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 31, 2022
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 4, 2022
View reviewed changes
Comment thread tests/cases/conformance/classes/members/privateNames/typeFromPrivatePropertyAssignment.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the fix/48487 branch from 0eb6e25 to 205d81f Compare April 5, 2022 02:55
@a-tarasyuk
fix(48487): allow using private names as the self-assignment entity name
a4c3ebe
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the fix/48487 branch from 205d81f to a4c3ebe Compare April 5, 2022 02:58
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser) April 5, 2022 02:58
@sandersn
Nathan Shively-Sanders (sandersn) self-requested a review April 8, 2022 17:44
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Apr 8, 2022
View reviewed changes
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 3b2fa50 into microsoft:main Apr 8, 2022
Jack Works (Jack-Works) pushed a commit to Jack-Works/TypeScript that referenced this pull request Apr 22, 2022
@a-tarasyuk @Jack-Works
fix(48487): allow using private names as the self-assignment entity n…
83c303e 
…ame (microsoft#48496)
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Unexpected PrivateIdentifier in name expression with literal-like access" being hit

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.