GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — More refactoring of tsc baselines to help with easier updates by sheetalkamat · Pull Request #48572 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Apr 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Removes unnecessary directories in the baselines making one baseline per test.
Also unifies two baseline functions that were doing something similar with slight change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Andrew Casey (amcasey) and Andrew Branch (andrewbranch) April 5, 2022 17:04
sheetalkamat
Sheetal Nandi (sheetalkamat) commented Apr 5, 2022
View reviewed changes
Comment thread src/testRunner/unittests/tsc/helpers.ts
const patch = fs.diff(inputFs, { includeChangedFileWithSameContent: true });
return {
file: `${isBuild(commandLineArgs) ? "tsbuild" : "tsc"}/${scenario}/${buildKind || BuildKind.Initial}/${subScenario.split(" ").join("-")}.js`,
file: `${isBuild(commandLineArgs) ? "tsbuild" : "tsc"}/${scenario}/${subScenario.split(" ").join("-")}.js`,

@sheetalkamat Sheetal Nandi (sheetalkamat) Apr 5, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one level of unnecessary directory in the baselines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Sheetal Nandi (sheetalkamat) force-pushed the baselining2 branch 2 times, most recently from e08d030 to 5632efd Compare April 5, 2022 17:41
@sheetalkamat Sheetal Nandi (sheetalkamat) mentioned this pull request Apr 5, 2022
Some refactoring for baselining for easy update #48516
Merged
@sheetalkamat
Sheetal Nandi (sheetalkamat) force-pushed the baselining2 branch from 5632efd to 1292289 Compare April 5, 2022 20:14
Base automatically changed from baselining to main April 6, 2022 19:46
Sheetal Nandi (sheetalkamat) added 2 commits April 6, 2022 12:49
@sheetalkamat
Some refactoring of baselines
531875d
@sheetalkamat
Some refactoring of baselines
f63f0af
@sheetalkamat
Sheetal Nandi (sheetalkamat) force-pushed the baselining2 branch from 1292289 to f63f0af Compare April 6, 2022 19:50
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) Apr 6, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 6, 2022
andrewbranch
Andrew Branch (andrewbranch) approved these changes Apr 6, 2022
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit 4c6f25a into main Apr 6, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the baselining2 branch April 6, 2022 21:10
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes
@amcasey Andrew Casey (amcasey) Awaiting requested review from amcasey

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.