GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't skip tests named *Fourslash.ts by jablko · Pull Request #48615 · microsoft/TypeScript

Conversation

@jablko

@jablko Jack Bates (jablko) commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

I noticed that I can't run the following tests:

tests/cases/fourslash/augmentedTypesClass3Fourslash.ts
tests/cases/fourslash/commentsEnumsFourslash.ts
tests/cases/fourslash/commentsExternalModulesFourslash.ts
tests/cases/fourslash/commentsInheritanceFourslash.ts
tests/cases/fourslash/commentsInterfaceFourslash.ts
tests/cases/fourslash/commentsModulesFourslash.ts
tests/cases/fourslash/commentsMultiModuleMultiFileFourslash.ts
tests/cases/fourslash/commentsMultiModuleSingleFileFourslash.ts
tests/cases/fourslash/commentsOverloadsFourslash.ts

fourslashRunner.ts skips tests/cases/fourslash/fourslash.ts (correctly), but the regex isn't anchored, so it also skips *Fourslash.ts. It's been like that since forever:

TypeScript/src/harness/fourslashRunner.ts

Line 30 in 214df64

if (justName && !justName.match(/fourslash\.ts$/i) && !justName.match(/\.d\.ts$/i)) {

Also, since there've never been any tests/cases/fourslash/*.d.ts files, and the .d.ts exemption is unique to this runner, I simplified the condition to just justName !== "fourslash.ts":

git log 'tests/cases/fourslash/*.d.ts'
# No output

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RyanCavanaugh reacted with eyes emoji
All reactions
  • 👀 1 reaction
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 8, 2022
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jablko
Jack Bates (jablko) force-pushed the patch-52 branch from 18d01bf to 1824fd8 Compare April 8, 2022 22:58
@jablko
Don't skip tests named *Fourslash.ts
9126d54
@jablko
Jack Bates (jablko) force-pushed the patch-52 branch from 1824fd8 to 9126d54 Compare April 8, 2022 23:12
@jablko

Jack Bates (jablko) commented Apr 9, 2022

Copy link
Copy Markdown
Contributor Author

FYI: There weren't any *Fourslash.ts tests before #44652:

git log 0f216f36ec554da78793bd73a5294116000f6b57^ 'tests/cases/fourslash/*Fourslash.ts'
# No output

I applied #46703, which landed in the meantime, to tests/cases/fourslash/commentsInterfaceFourslash.ts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes Apr 9, 2022
View reviewed changes
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit c1db699 into microsoft:main Apr 11, 2022
Jack Works (Jack-Works) pushed a commit to Jack-Works/TypeScript that referenced this pull request Apr 22, 2022
@jablko @Jack-Works
Don't skip tests named *Fourslash.ts (microsoft#48615)
fdadeb7
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jablko @typescript-bot @DanielRosenwasser @RyanCavanaugh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.