GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Respect importModuleSpecifierEnding inside node_modules packages by andrewbranch · Pull Request #48995 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented May 6, 2022

Copy link
Copy Markdown
Member

Fixes #48991

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch
Respect importModuleSpecifierEnding inside node_modules packages
736c8a1
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) May 6, 2022
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Wesley Wigham (weswigham) May 6, 2022 17:48
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 6, 2022
andrewbranch
Andrew Branch (andrewbranch) commented May 6, 2022
View reviewed changes
Comment thread src/compiler/moduleSpecifiers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Sheetal Nandi (sheetalkamat) May 6, 2022 17:52
@andrewbranch
Add tests for missing package.json
bf6b47f
sandersn
Nathan Shively-Sanders (sandersn) reviewed May 6, 2022
View reviewed changes
Comment thread tests/cases/fourslash/importNameCodeFixJsEnding.ts
// @Filename: /a.ts
//// customElement/**/

verify.importFixModuleSpecifiers("", ["lit/decorators.js"], { importModuleSpecifierEnding: "js" })

@sandersn Nathan Shively-Sanders (sandersn) May 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a test for .cjs/.mjs as well, since you mentioned that they were broken before?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) May 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, are there already tests for filename/package conflicts? I assume yes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@andrewbranch Andrew Branch (andrewbranch) May 6, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are .cjs tests. Filename/package conflicts aren’t related to this change, I think.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/compiler/moduleSpecifiers.ts
}

function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCanonicalFileName, sourceDirectory }: Info, importingSourceFile: SourceFile , host: ModuleSpecifierResolutionHost, options: CompilerOptions, packageNameOnly?: boolean, overrideMode?: ModuleKind.ESNext | ModuleKind.CommonJS): string | undefined {
function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCanonicalFileName, sourceDirectory }: Info, importingSourceFile: SourceFile , host: ModuleSpecifierResolutionHost, options: CompilerOptions, userPreferences: UserPreferences, packageNameOnly?: boolean, overrideMode?: ModuleKind.ESNext | ModuleKind.CommonJS): string | undefined {

@sandersn Nathan Shively-Sanders (sandersn) May 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is comically long

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 6, 2022
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit 2ffe686 into microsoft:main May 6, 2022
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/48991 branch May 6, 2022 19:58
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request May 9, 2022
Fix module specifier generation crash from typesVersions #49035
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn left review comments
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser left review comments
@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"importModuleSpecifierEnding" : "js" has no effect on import fixes from inside node_modules

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@andrewbranch @sandersn @DanielRosenwasser @sheetalkamat @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.