GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix module specifier generation crash from typesVersions by andrewbranch · Pull Request #49035 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented May 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes https://github.com/microsoft/tsserverfuzzer/issues/409 introduced by #48995

Also discovered #49034, but will fix that separately as it’s been the behavior at least since 4.5 (probably for years)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch
Fix module specifier generation crash from typesVersions
e8df495
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) May 9, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 9, 2022
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Daniel Rosenwasser (DanielRosenwasser) May 9, 2022 18:35
@andrewbranch

Andrew Branch (andrewbranch) commented May 9, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented May 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into release-4.7 on this PR at e8df495. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request May 9, 2022
🤖 Pick PR #49035 (Fix module specifier generation cra...) into release-4.7 #49036
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented May 9, 2022

Copy link
Copy Markdown
Contributor

Hey Andrew Branch (@andrewbranch), I've opened #49036 for you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request May 9, 2022
@andrewbranch @typescript-bot
Cherry-pick PR microsoft#49035 into release-4.7
d074a79 
Component commits:
e8df495 Fix module specifier generation crash from typesVersions
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 9, 2022
View reviewed changes
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 9, 2022
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit f3f0a3f into microsoft:main May 9, 2022
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/fuzzer-409 branch May 9, 2022 19:48
Andrew Branch (andrewbranch) added a commit that referenced this pull request May 9, 2022
TypeScript Bot @andrewbranch
Cherry-pick PR #49035 into release-4.7 (#49036)
dbee2ab 
Component commits:
e8df495 Fix module specifier generation crash from typesVersions

Co-authored-by: Andrew Branch <[email protected]>
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andrewbranch @typescript-bot @DanielRosenwasser @sheetalkamat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.