GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Port #48978 forward to the revised FAR code by amcasey · Pull Request #49267 · microsoft/TypeScript

Conversation

@amcasey

@amcasey Andrew Casey (amcasey) commented May 26, 2022

Copy link
Copy Markdown
Member

The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@amcasey
Port microsoft#48978 forward to the revised FAR code
1b3bdb2 
The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.
@amcasey
Andrew Casey (amcasey) requested review from Daniel Rosenwasser (DanielRosenwasser) and Sheetal Nandi (sheetalkamat) May 26, 2022 20:11
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Casey (amcasey) May 26, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 26, 2022
@amcasey

Andrew Casey (amcasey) commented May 26, 2022

Copy link
Copy Markdown
Member Author

Fixes https://github.com/microsoft/tsserverfuzzer/issues/415
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
amcasey
Andrew Casey (amcasey) commented May 26, 2022
View reviewed changes
Comment thread src/server/session.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@amcasey
Drop spurious non-null assertion
8ab012d
@amcasey
Andrew Casey (amcasey) force-pushed the GH48978Redux branch from 30bb76d to 8ab012d Compare May 27, 2022 16:18
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 27, 2022
View reviewed changes
@amcasey
Andrew Casey (amcasey) merged commit 757a3ac into microsoft:main May 27, 2022
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@amcasey Andrew Casey (amcasey)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@amcasey @sheetalkamat @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.