GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Harden combineProjectOutputForReferences against empty results by amcasey · Pull Request #48978 · microsoft/TypeScript

Conversation

@amcasey

@amcasey Andrew Casey (amcasey) commented May 5, 2022

Copy link
Copy Markdown
Member

Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until #48619 is merged.

Fixes #48963

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@amcasey
Harden combineProjectOutputForReferences against empty results
dd28f12 
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until microsoft#48619 is merged.

Fixes microsoft#48963
@amcasey
Andrew Casey (amcasey) requested a review from Daniel Rosenwasser (DanielRosenwasser) May 5, 2022 18:14
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Casey (amcasey) May 5, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 5, 2022
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 5, 2022
View reviewed changes
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 58114cf into microsoft:main May 5, 2022
@amcasey
Andrew Casey (amcasey) deleted the GH48963 branch May 5, 2022 21:17
Andrew Casey (amcasey) added a commit to amcasey/TypeScript that referenced this pull request May 26, 2022
@amcasey
Port microsoft#48978 forward to the revised FAR code
1b3bdb2 
The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.
Andrew Casey (amcasey) added a commit that referenced this pull request May 27, 2022
@amcasey
Port #48978 forward to the revised FAR code (#49267)
757a3ac 
* Port #48978 forward to the revised FAR code

The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.

* Drop spurious non-null assertion
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@amcasey Andrew Casey (amcasey)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find all references crash on literal with base constraint contextual type

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@amcasey @DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.