GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue #5444 by jeffreymorlan · Pull Request #5566 · microsoft/TypeScript

Conversation

@jeffreymorlan

@jeffreymorlan jeffreymorlan commented Nov 8, 2015

Copy link
Copy Markdown
Contributor

reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.

class C { foo(), foo(); }

Edit by Daniel Rosenwasser (@DanielRosenwasser): Fixes #5444

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jeffreymorlan
Fix issue microsoft#5444
470d1d2 
reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.

    class C { foo(), foo(); }
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Nov 8, 2015

Copy link
Copy Markdown

Hi jeffreymorlan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 8, 2015
@jeffreymorlan jeffreymorlan mentioned this pull request Nov 8, 2015
Assertion error with if-else-if inside class #5444
Closed
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

Can you please add unit tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 9, 2015

Copy link
Copy Markdown
Member

To be clear, Mohamed Hegazy (@mhegazy) does't mean a unit test, he means an end-to-end test. Check out Adding a Test in our CONTRIBUTING.md.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jeffreymorlan
Add test case
c72861e
DanielRosenwasser
DanielRosenwasser reviewed Nov 24, 2015
View reviewed changes
Comment thread src/compiler/checker.ts Outdated

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Nov 24, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that you need this test because garbage declarations may be introduced between overloads and cause issues according to our expectations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jeffreymorlan jeffreymorlan Nov 28, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 24, 2015

Copy link
Copy Markdown
Member

👍 Vladimir Matveev (@vladima) could you take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vladima

Vladimir Matveev (vladima) commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

👍 after Daniel Rosenwasser (@DanielRosenwasser) note about the comment is addressed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jeffreymorlan
Add comment
ed453dd
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Nov 28, 2015
@DanielRosenwasser
Merge pull request #5566 from jeffreymorlan/fix5444
2f282a7 
Fix issue #5444
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 2f282a7 into microsoft:master Nov 28, 2015
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jeffreymorlan @msftclas @mhegazy @DanielRosenwasser @vladima
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.