GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — do not report 'noImplicitReturns' error if inferred return type of th… by vladima · Pull Request #5824 · microsoft/TypeScript

Conversation

@vladima

@vladima Vladimir Matveev (vladima) commented Nov 29, 2015

Copy link
Copy Markdown
Contributor

…e function is void/any. fixes #5814

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vladima
do not report 'noImplicitReturns' error if inferred return type of th…
d0e4a4c 
…e function is void/any
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 29, 2015
@vladima
fix lint errors
7f8bf73
DanielRosenwasser
DanielRosenwasser reviewed Nov 30, 2015
View reviewed changes
Comment thread src/compiler/checker.ts

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Nov 30, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "explicitly specified"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vladima Vladimir Matveev (vladima) Nov 30, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'explicitly specified' reflects what is checked in the if below - if function has explicit type annotation and it is void / any

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@yuit Yui (yuit) Nov 30, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the second "with"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vladima

Vladimir Matveev (vladima) commented Nov 30, 2015

Copy link
Copy Markdown
Contributor Author

Daniel Rosenwasser (@DanielRosenwasser) any other comments?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sandersn
sandersn reviewed Nov 30, 2015
View reviewed changes
Comment thread src/compiler/checker.ts Outdated

@sandersn Nathan Shively-Sanders (sandersn) Nov 30, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return or throw

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 30, 2015

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vladima
fix typo in comment
6ff5679
@yuit

Yui (yuit) commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 30, 2015

Copy link
Copy Markdown
Member

Apart from Yui (@yuit)'s feedback 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Vladimir Matveev (vladima) added a commit that referenced this pull request Dec 1, 2015
@vladima
Merge pull request #5824 from Microsoft/implicitReturnInferredVoid
b40079e 
do not report 'noImplicitReturns' error if inferred return type of th…
@vladima
Vladimir Matveev (vladima) merged commit b40079e into master Dec 1, 2015
@vladima
Vladimir Matveev (vladima) deleted the implicitReturnInferredVoid branch December 1, 2015 04:36
@tetsuharuohzeki Tetsuharu Ohzeki (tetsuharuohzeki) mentioned this pull request Dec 2, 2015
Re-enable 'noImplicitReturns' of TypeScript compiler's option karen-irc/karen#503
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

noImplicitReturns compile error for void functions as of 1.8.0-dev.20151126

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vladima @sandersn @yuit @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.