GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix slowdown in type inference involving union types by ahejlsberg · Pull Request #5920 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Dec 4, 2015

Copy link
Copy Markdown
Member

Fixes #5849.

When inferring types, if the source and target are both non-generic object types we don't descend into the types because it we know it won't produce inferences. However, in 1.7 all classes are generic because of the implied this type parameter, so we ended up doing a lot more work. With this PR, we check that the type references actually have explicitly specified type arguments and only descend into the types then.

I have manually verified that performance is back to where it was before.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ahejlsberg
Only infer *to* type references that have explicit type arguments
c839dd3
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Dec 4, 2015
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Dec 4, 2015
Massive slowdown in compiling complicated union types #5849
Closed
@vladima Vladimir Matveev (vladima) mentioned this pull request Dec 4, 2015
Revert "Port union reduction to 1.7" #5921
Merged
@mhegazy

Mohamed Hegazy (mhegazy) commented Dec 4, 2015

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@vladima

Vladimir Matveev (vladima) commented Dec 4, 2015

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Anders Hejlsberg (ahejlsberg) added a commit that referenced this pull request Dec 4, 2015
@ahejlsberg
Merge pull request #5920 from Microsoft/fixUnionTypeInference
ee9c4dc 
Fix slowdown in type inference involving union types
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit ee9c4dc into master Dec 4, 2015
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the fixUnionTypeInference branch December 4, 2015 01:11
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ahejlsberg @mhegazy @vladima @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.