GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lanugage Service support for union types by mhegazy · Pull Request #861 · microsoft/TypeScript

Conversation

@mhegazy

@mhegazy Mohamed Hegazy (mhegazy) commented Oct 9, 2014

Copy link
Copy Markdown
Contributor

Completions kind, Quick Info, go to def, and find all refss

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mohamed Hegazy (mhegazy) added 6 commits October 7, 2014 22:48
@mhegazy
Support symbol kind for union properties
b8923b3
@mhegazy
add test for quick info
5669f63
@mhegazy
Add support for union properties in goto def
c439ae4
@mhegazy
Support find all refs on union properties
779db6e
@mhegazy
Use getRootSymbols for all union property needs
2eb51ab
@mhegazy
Merge branch 'unionTypes' into unionTypesLS
dc43e83 
Conflicts:
	src/compiler/checker.ts
	src/services/services.ts
@danquirk

Dan Quirk (danquirk) commented Oct 9, 2014

Copy link
Copy Markdown
Member

Probably could use some fourslash tests for generic type inference and type guards
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy
Fix contextually typed object literal proeprties that are not propert…
927f04f 
…ies of the union type but are properties on of one of its constituant types
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Oct 10, 2014

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CyrusNajmabadi
CyrusNajmabadi reviewed Oct 10, 2014
View reviewed changes
Comment thread src/services/services.ts Outdated

@CyrusNajmabadi Cyrus Najmabadi (CyrusNajmabadi) Oct 10, 2014

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhegazy Mohamed Hegazy (mhegazy) Oct 10, 2014

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mohamed Hegazy (mhegazy) added 5 commits October 10, 2014 10:59
@mhegazy
respond to code review remarks
9f43ac0
@mhegazy
ensure unionProperty symbols have declarations set at creation time
f5a9fee
@mhegazy
Handle union properties completions on apparant types
2ce627c
@mhegazy
Add a temporary fix to quick info
4442b45
@mhegazy
Merge branch 'unionTypes' into unionTypesLS
04e5309 
Conflicts:
	src/compiler/checker.ts
Mohamed Hegazy (mhegazy) added a commit that referenced this pull request Oct 11, 2014
@mhegazy
Merge pull request #861 from Microsoft/unionTypesLS
eee1602 
Lanugage Service support for union types
@mhegazy
Mohamed Hegazy (mhegazy) merged commit eee1602 into unionTypes Oct 11, 2014
@mhegazy
Mohamed Hegazy (mhegazy) deleted the unionTypesLS branch October 14, 2014 00:15
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhegazy @danquirk @DanielRosenwasser @CyrusNajmabadi @JsonFreeman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.