GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [Transforms] Merge master 07/11 into transform by yuit · Pull Request #9697 · microsoft/TypeScript

Conversation

@yuit

@yuit Yui (yuit) commented Jul 13, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Merge master into transforms 🎉 There are tests related to classExpressionWithStaticProperties that fail. This require this PR Ron Buckton (@rbuckton) should I just accept baselines for now as we already has issue to track this problem?

Interesting commit starts from dd0cd58

TODO:

  • Port JSDOC unittests into the transforms

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Zhengbo Li and others added 30 commits June 20, 2016 14:07
Zhengbo Li
Merge pull request #9213 from zhengbli/fixRealPath
7b3abc6
ignore casing when converting a source file path to relative path
@riknoll
Merge branch 'master' into glob2_merged
b49acd5
@riknoll
Merge pull request #8841 from Microsoft/glob2_merged
6d99b2f
Add glob-style file include pattern support for tsconfig.json
@weswigham
Use merge2, gulp-if, gulp-newer, and more projects
0e5b741
@weswigham
Add watch task
8ca1910
@weswigham
Working non-inline sourcemaps for runtests
9619e3a
@weswigham
browser tests now also loads sourcemaps from disk
9d10f7c
@weswigham
Merge branch 'master' into remove-jake
b103857
@weswigham
Lazypipes and better services stream management
d7970a5
@basarat
export interface used by other exported functions
8e489cb
@DanielRosenwasser
Merge pull request #9286 from basarat/patch-2
cb9246f
export interface used by other exported functions
Andy Hanson
Make goto-definition work for this parameter
07437a6
@billti
Merge branch 'master' into loadJsFromModules
4d4f679
@OrangeShark
Add new error for rest parameters
392fe47
@OrangeShark
Add error message for rest parameter properties
1a66f54
@jramsay
Fix case when a document contains multiple script blocks with differe…
369253b
…nt base indentations.

Use the base indent size if it is greater that the indentation of the inherited predecessor
@yuit
Fix rwc-runner from breaking change in compiler (#9284)
9a85b93
@sandersn
Signatures use JSDoc to determine optionality
553d727
@billti
Changed implementation to use closure
07bfbab
@billti
Updated tests
d01d5b1
@billti
Fixed linting error
8ff2c1a
@mhegazy
Adding Code of Conduct notice
851a75e
@RyanCavanaugh
Don't crash when JS class property is self-referential.
0e3ffb5
Fixes #9293
@RyanCavanaugh
Remove stale baselines
c4f8fb2
@sandersn
For optionality, check question token before JSDoc
3a7396e
@OrangeShark
Accept rest parameter properties error baselines
65bd8e5
@OrangeShark
Change binding pattern parameter property error
20f8c33
@OrangeShark
Accept binding pattern properties error baselines
6a4400a
@RyanCavanaugh
Lint
66c3093
zhengbli
Port the sync version diagnostics API from tsserverVS-WIP branch to 2.0
35c50bf
Nathan Shively-Sanders (sandersn) and others added 14 commits July 11, 2016 11:41
@sandersn
Merge pull request #9578 from Microsoft/fix-salsa-out-of-memory-on-me…
cc83c79
…thods-returning-this

Provide a symbol for salsa-inferred class types
@sandersn
Update conflicting baseline.
6ad4482
PR #9574 added a baseline that #9578 caused to be changed. The two PRs
went in so close to each other that the CI build didn't catch the change
to the new test's baseline.
@billti
Merge pull request #9607 from Microsoft/issue9542
2f768f6
Fix #9542 (allow files under node_modules to be included in the compilation).
@sandersn
Merge pull request #9622 from Microsoft/update-conflicting-baseline
1d202f6
Update conflicting baseline.
Kanchalai Tanglertsampan
Merge branch 'master' into mergemaster_0711
a1b6260
# Conflicts:
#	src/compiler/checker.ts
#	src/compiler/commandLineParser.ts
#	src/compiler/core.ts
#	src/compiler/diagnosticMessages.json
#	src/compiler/emitter.ts
#	src/compiler/parser.ts
#	src/compiler/program.ts
#	src/compiler/scanner.ts
#	src/compiler/sys.ts
#	src/compiler/tsconfig.json
#	src/compiler/types.ts
#	src/compiler/utilities.ts
#	src/harness/fourslash.ts
#	src/harness/harness.ts
#	src/harness/harnessLanguageService.ts
#	src/harness/loggedIO.ts
#	src/harness/projectsRunner.ts
#	src/lib/dom.generated.d.ts
#	src/lib/webworker.generated.d.ts
#	src/services/navigationBar.ts
#	src/services/tsconfig.json
#	tests/baselines/reference/decoratorMetadataWithImportDeclarationNameCollision4.js
#	tests/baselines/reference/transpile/Rename dependencies - System.js
#	tests/baselines/reference/transpile/Rename dependencies - UMD.js
#	tests/baselines/reference/transpile/Sets module name.js
#	tests/baselines/reference/transpile/Transpile with emit decorators and emit metadata.js
#	tests/baselines/reference/tsxUnionTypeComponent2.js
#	tests/cases/fourslash/fourslash.ts
#	tests/cases/fourslash/referencesInComment.ts
#	tests/cases/unittests/cachingInServerLSHost.ts
#	tests/cases/unittests/jsDocParsing.ts
#	tests/cases/unittests/matchFiles.ts
#	tests/cases/unittests/transpile.ts
Kanchalai Tanglertsampan
Fix type of JSXTagName
dd0cd58
Kanchalai Tanglertsampan
Update baselines to use double-quote
78b89ee
Kanchalai Tanglertsampan
Update baselines when emitting metadata decorator
b36e6a4
Kanchalai Tanglertsampan
Update baselines for async-await function
30614fa
Kanchalai Tanglertsampan
Update baselines for comment in capturing down-level for...of and for…
59b783d
…...in
Kanchalai Tanglertsampan
Add missing Transpile tests
345bdea
Kanchalai Tanglertsampan
Remove old JS transpile baselines
1d604a8
Kanchalai Tanglertsampan
Passing program as argument in emitWorker
954213a
Kanchalai Tanglertsampan
Port PR#9607 transforms
b0b736a
@yuit Yui (yuit) added the Domain: API: Transforms Relates to the public transform API label Jul 13, 2016
@yuit Yui (yuit) assigned Ron Buckton (rbuckton) Jul 13, 2016
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 13, 2016
@yuit Yui (yuit) changed the title Mergemaster 0711 [Transforms] Merge master 07/11 into transform Jul 13, 2016
Kanchalai Tanglertsampan
Port new JSDOC tests to use baseline
4415f0d
@yuit

Yui (yuit) commented Jul 15, 2016

Copy link
Copy Markdown
Contributor Author

All tests failure related to classExpression which contains capturing static property

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ron Buckton (rbuckton) added 2 commits July 18, 2016 15:14
@rbuckton
substitute alias for class expression in statics
356a75b
@rbuckton
Address new lint warnings
328cf96
@rbuckton

Ron Buckton (rbuckton) commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

yuit
yuit reviewed Jul 18, 2016
View reviewed changes
Comment thread src/compiler/transformers/ts.ts Outdated
@@ -3239,14 +3214,14 @@ namespace ts {
}

function trySubstituteDecoratedClassName(node: Identifier): Expression {

@yuit Yui (yuit) Jul 18, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to rename this function since it is not just decorated class name anynmore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yuit

Yui (yuit) commented Jul 18, 2016

Copy link
Copy Markdown
Contributor Author

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rbuckton
Change name for substitution function.
3dca7e8
@yuit
Yui (yuit) merged commit 1c9df84 into transforms Jul 18, 2016
@yuit
Yui (yuit) deleted the mergemaster_0711 branch July 18, 2016 22:38
@bbenezech Benoit Bénézech (bbenezech) mentioned this pull request May 1, 2017
Fix canvas getContext signature in lib/lib.dom.d.ts #15498
Closed
3 of 5 tasks
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rbuckton Ron Buckton (rbuckton)

Labels

Domain: API: Transforms Relates to the public transform API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@yuit @rbuckton @msftclas @riknoll @weswigham @basarat @DanielRosenwasser @billti @OrangeShark @jramsay @sandersn @mhegazy @RyanCavanaugh @paulvanbrenk @sarangan12 @saschanaz @zspitz @dilijev @HerringtonDarkholme @vladima
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.