GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move color tokens out of common by mischreiber · Pull Request #2170 · microsoft/fluentui-apple

Conversation

@mischreiber

@mischreiber Mike Schreiber (mischreiber) commented May 30, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Follow-up to #2165 and #2168 -- moving our system to treat iOS tokens as the same level of importance as macOS. Both now need to be provided by PlatformThemeProviding.

visionOS continues to be special, and lives on as an add-on to iOS.

Verification

Validated alias tokens load as expected in light and dark modes, and appear in components as expected.

Visual Verification
Dark Light
macOS_light macOS_dark
visionOS n/a
iOS_dark iOS_light

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mike Schreiber (mischreiber) added 2 commits May 30, 2025 13:58
@mischreiber
Move color tokens out of FluentUI_common and into iOS
9c3032a
@mischreiber
Restore missing initializer
425e18a
@mischreiber
Mike Schreiber (mischreiber) requested a review from a team as a code owner May 30, 2025 21:20
@mischreiber Mike Schreiber (mischreiber) mentioned this pull request May 30, 2025
[macOS] Adding theme tokens #2168
Merged
1 of 3 tasks
DanielMorM
Daniel Morales (DanielMorM) reviewed May 30, 2025
View reviewed changes
Comment thread Sources/FluentUI_common/Core/Theme/PlatformThemeProviding.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielMorM
Daniel Morales (DanielMorM) reviewed May 30, 2025
View reviewed changes
Comment thread Sources/FluentUI_macOS/Theme/FluentTheme+macOS.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
Mike Schreiber (mischreiber) added 3 commits May 31, 2025 21:26
@mischreiber
Fix comment, remove visionOS code from macOS
2356b1c
@mischreiber
Make tokens non-CaseIterable
203dcad
@mischreiber
Fix macOS test app
55e1499
DanielMorM
Daniel Morales (DanielMorM) reviewed Jun 2, 2025
View reviewed changes
Comment thread Demos/FluentUIDemo_iOS/FluentUI.Demo/Demos/TypographyTokensDemoController.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielMorM
Daniel Morales (DanielMorM) approved these changes Jun 2, 2025
View reviewed changes
@mischreiber
Mike Schreiber (mischreiber) merged commit 998b5bc into microsoft:main Jun 2, 2025
@mischreiber
Mike Schreiber (mischreiber) deleted the moveColorTokensOutOfCommon branch June 2, 2025 22:57
@DanielMorM Daniel Morales (DanielMorM) mentioned this pull request Jun 3, 2025
[macOS] Moving Typography tokens out of common #2171
Merged
1 task done
@mischreiber Mike Schreiber (mischreiber) mentioned this pull request Jun 13, 2025
Bump version to 0.34 #2180
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielMorM Daniel Morales (DanielMorM) DanielMorM approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mischreiber @DanielMorM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.