GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [macOS] Moving Typography tokens out of common by DanielMorM · Pull Request #2171 · microsoft/fluentui-apple

Conversation

@DanielMorM

@DanielMorM Daniel Morales (DanielMorM) commented Jun 3, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • [] iOS
  • [] visionOS
  • macOS

Description of changes

Similar to #2170, this change moves Typography related stuff out of common so each platform define their own values.

Verification

Locally built and test app.

###Visual Verification

Before After
Screenshot 2025-06-03 at 11 13 35 AM Screenshot 2025-06-03 at 11 12 42 AM
Screenshot 2025-06-03 at 11 14 17 AM Screenshot 2025-06-03 at 11 11 48 AM
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Daniel Morales (DanielMorM) added 3 commits June 3, 2025 10:57
@DanielMorM
Creating PlatformFontInfoProviding
39eef8b
@DanielMorM
Creating PlatformGlobalTokenProviding
6cd119e
@DanielMorM
Adding platformTypographyValue in PlatformThemeProviding
1052067
@DanielMorM
Daniel Morales (DanielMorM) requested a review from a team as a code owner June 3, 2025 18:17
@DanielMorM
Removing unnecessary sizeTuples
a8bad34
mischreiber
Mike Schreiber (mischreiber) approved these changes Jun 4, 2025
View reviewed changes
@DanielMorM
Daniel Morales (DanielMorM) merged commit 42fee3b into microsoft:main Jun 4, 2025
@DanielMorM
Daniel Morales (DanielMorM) deleted the user/damoral/macos-font-tokens branch June 4, 2025 23:19
@mischreiber Mike Schreiber (mischreiber) mentioned this pull request Jun 13, 2025
Bump version to 0.34 #2180
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber Mike Schreiber (mischreiber) mischreiber approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DanielMorM @mischreiber
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.