GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Mac Catalyst build by thomasjross · Pull Request #2184 · microsoft/fluentui-apple

Conversation

@thomasjross

@thomasjross T.J. Ross (thomasjross) commented Jun 18, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

After some of the changes in the 0.34.0 release to move FluentTheme into the common layer, it's no longer possible to build FluentUI for Mac Catalyst. The changes are relatively simple to get things building again.

Add a target environment check to NSColor+Extensions

  • Simply checking if we can import AppKit is not sufficient since the framework can be imported, but NSColor is unavailable on Catalyst.

Use FluentFontInfo type alias

  • Since Catalyst has access to ApplicationServices.FontInfo, the reference to FontInfo in the iOS target is ambiguous. Using the type alias resolves this ambiguity.

Binary change

N/A, should have no impact on iOS binary size.

Verification

Swift package for FluentUI was built for iOS, visionOS, macOS, and macOS (Catalyst). I confirmed that the package builds properly for all supported platforms listed in the package definition.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@thomasjross
Fix Mac Catalyst build
dd9520d
@thomasjross
T.J. Ross (thomasjross) requested a review from a team as a code owner June 18, 2025 17:58
mischreiber
Mike Schreiber (mischreiber) approved these changes Jun 18, 2025
View reviewed changes
@mischreiber
Mike Schreiber (mischreiber) merged commit 6126989 into microsoft:main Jun 18, 2025
Mike Schreiber (mischreiber) pushed a commit to mischreiber/fluentui-apple that referenced this pull request Jun 18, 2025
@thomasjross @mischreiber
Fix Mac Catalyst build (microsoft#2184)
a70f3c7
Mike Schreiber (mischreiber) added a commit that referenced this pull request Jun 18, 2025
@mischreiber @thomasjross
Fix Mac Catalyst build (#2184) (#2185)
4ab89fa
Co-authored-by: T.J. Ross <[email protected]>
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Oct 23, 2025
Bump version to 0.35 #2225
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber Mike Schreiber (mischreiber) mischreiber approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thomasjross @mischreiber
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.