GeezerVison is showing github.com — Fix Mac Catalyst build by thomasjross · Pull Request #2184 · microsoft/fluentui-apple
Conversation
Platforms Impacted
Description of changes
After some of the changes in the 0.34.0 release to move FluentTheme into the common layer, it's no longer possible to build FluentUI for Mac Catalyst. The changes are relatively simple to get things building again.
Add a target environment check to NSColor+Extensions
- Simply checking if we can import AppKit is not sufficient since the framework can be imported, but
NSColor is unavailable on Catalyst.
Use FluentFontInfo type alias
- Since Catalyst has access to
ApplicationServices.FontInfo, the reference to FontInfo in the iOS target is ambiguous. Using the type alias resolves this ambiguity.
Binary change
N/A, should have no impact on iOS binary size.
Verification
Swift package for FluentUI was built for iOS, visionOS, macOS, and macOS (Catalyst). I confirmed that the package builds properly for all supported platforms listed in the package definition.
Pull request checklist
This PR has considered:
- Light and Dark appearances
- iOS supported versions (all major versions greater than or equal current target deployment version)
- VoiceOver and Keyboard Accessibility
- Internationalization and Right to Left layouts
- Different resolutions (1x, 2x, 3x)
- Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
- iPad Pointer interaction
- SwiftUI consumption (validation or new demo scenarios needed)
- Objective-C exposure (provide it only if needed)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.