GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: throw FileNotFoundError for nonexistant files by Skn0tt · Pull Request #3014 · microsoft/playwright-python

Conversation

@Skn0tt

@Skn0tt Simon Knott (Skn0tt) commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Closes microsoft/playwright#38450. We were only checking file existence on the server (https://github.com/microsoft/playwright/blob/f9e039408b70ab27b5107de3863343236d8835ae/packages/playwright-core/src/server/dom.ts#L655-L657), but didn't surface the error, so it showed up as a timeout. In Node.js, we check file existence on the client (https://github.com/microsoft/playwright/blob/f9e039408b70ab27b5107de3863343236d8835ae/packages/playwright-core/src/client/elementHandle.ts#L263), mirroring this behaviour to Python.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Skn0tt
chore: throw FileNotFoundError for nonexistant files
decd0b8
@Skn0tt
Simon Knott (Skn0tt) requested a review from Dmitry Gozman (dgozman) December 8, 2025 08:31
@Skn0tt Simon Knott (Skn0tt) self-assigned this Dec 8, 2025
dgozman
Dmitry Gozman (dgozman) approved these changes Dec 8, 2025
View reviewed changes
@dgozman

Dmitry Gozman (dgozman) commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

I don't quite understand why server-side code would lead to a timeout, but client-side check sounds good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Skn0tt

Simon Knott (Skn0tt) commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

The server-side check is in a retry condition, and we don't abort the retry when it occurs. Client-side is better anyways because it throws the platform-standard exceptions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Skn0tt
Simon Knott (Skn0tt) merged commit d3f5438 into microsoft:main Dec 8, 2025
38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Simon Knott (Skn0tt) added a commit that referenced this pull request Dec 9, 2025
@Skn0tt
cherry-pick(3014): chore: throw FileNotFoundError for nonexistant fil…
732639b 
…es (#3014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman Dmitry Gozman (dgozman) dgozman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Skn0tt Simon Knott (Skn0tt)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Descriptive error message for a file not found error using set_input_files()

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Skn0tt @dgozman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.