GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — chore: roll to 1.59.1 by pavelfeldman · Pull Request #3050 · microsoft/playwright-python Conversation
Member
Bumps the driver to 1.59.1 and ports the public-API changes that landed upstream during the 1.58 → 1.59 cycle. New public APIs:
Renames matching upstream:
Generator/codegen:
Tests added (async + sync mirrors where applicable) for every PORT. expected_api_mismatch.txt is now down to legitimate divergences only. Tooling:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Pavel Feldman (pavelfeldman)
force-pushed
the
roll/1.59.1
branch
from
d5d17b5 to
d63e8c3
Compare
Yury Semikhatsky (yury-s)
approved these changes
Pavel Feldman (pavelfeldman)
force-pushed
the
roll/1.59.1
branch
5 times, most recently
from
9789e39 to
8202660
Compare
Bumps the driver to 1.59.1 and ports the public-API changes that landed upstream during the 1.58 → 1.59 cycle. New public APIs: - Request.existing_response (property) - Response.http_version() - ConsoleMessage.timestamp (property) - BrowserContext.is_closed() - BrowserContext.set_storage_state(state | path) - BrowserContext.debugger (property) + new Debugger class (request_pause, resume, next, run_to, paused_details + pausedstatechanged event) - Page.aria_snapshot(timeout=, depth=, mode=) - Page.console_messages(filter=) / Page.page_errors(filter=) - Page.clear_console_messages() / Page.clear_page_errors() - Page.pick_locator() / Page.cancel_pick_locator() - Page.screencast (property) + new Screencast class (start/stop with onFrame callback, show_actions/hide_actions, show_overlay, show_chapter, show_overlays/hide_overlays) - Locator.normalize() - Locator.aria_snapshot(depth=, mode=) - Browser.bind(title, ...) / Browser.unbind() - BrowserType.launch(artifacts_dir=) / launch_persistent_context(artifacts_dir=) - Tracing.start(live=) - CDPSession emits 'close' and forwards 'event' for raw CDP events - Dialog.dismiss() swallows TargetClosedError Renames matching upstream: - BrowserType.connect(ws_endpoint=) -> connect(endpoint=) (positional; the wire field also renamed to "endpoint") Generator/codegen: - documentation_provider: emit Promise-without-templates as Any, void as None - documentation_provider: emit @typing.overload + generic fallback for single-event classes (CDPSession needed this once it gained 'close') - New TypedDicts in _api_structures.py: DebuggerLocation, DebuggerPausedDetails, ScreencastFrame, BrowserBindResult - Register Debugger in _object_factory; register Debugger and Screencast in scripts/generate_api.py Tests added (async + sync mirrors where applicable) for every PORT. expected_api_mismatch.txt is now down to legitimate divergences only. Tooling: - New CLAUDE.md with project orientation - Expanded .claude/skills/playwright-roll/SKILL.md with the operational playbook learned over this roll (langs-verification, audit loop, common doclint quirks, channel-owner wiring checklist). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Pavel Feldman (pavelfeldman)
force-pushed
the
roll/1.59.1
branch
from
8202660 to
fac6679
Compare
Yury Semikhatsky (yury-s)
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
This was referenced
Closed
Simon Knott (Skn0tt)
added a commit
to Skn0tt/playwright-pytest
that referenced
this pull request
BrowserType.connect() renamed its first parameter from ws_endpoint to endpoint (positional) in microsoft/playwright-python#3050. The test also needs to look at stderr from the subprocess pytester run, since the WebSocket error log lands there. Co-authored-by: Copilot <[email protected]>
Simon Knott (Skn0tt)
added a commit
to microsoft/playwright-pytest
that referenced
this pull request
* chore: require playwright>=1.60 in CI and unskip 1.60 tests Playwright Python 1.60 has been released, so the tests gated on it can now run. Pin the dev dependency in local-requirements.txt so CI installs a compatible version; the package's runtime requirement is unchanged. Co-authored-by: Copilot <[email protected]> * test(connect_options): adapt to Playwright 1.59.1+ connect() API BrowserType.connect() renamed its first parameter from ws_endpoint to endpoint (positional) in microsoft/playwright-python#3050. The test also needs to look at stderr from the subprocess pytester run, since the WebSocket error log lands there. Co-authored-by: Copilot <[email protected]> * test: set PYTHONIOENCODING=utf-8 for pytester subprocesses Pytester decodes subprocess stdout as utf-8, but on Windows the default stdout encoding is cp1252. When Playwright's assertion failure messages contain non-ASCII characters (e.g. unicode arrows / multiplication signs), pytester raises UnicodeDecodeError. Force utf-8 in child Python processes. Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |