GeezerVison is showing github.com — devops: publish to PyPI from GitHub Actions with trusted publishing by pavelfeldman · Pull Request #3252 · microsoft/playwright-python
Conversation
Summary
- New
.github/workflows/publish.yml builds the wheels of a release tag and uploads them to PyPI with trusted publishing, as microsoft/autogen does. It runs when a release is published, or by hand with a tag.
- Only the upload job, in the
pypi environment, gets id-token: write.
- Remove the Azure publish pipeline. For
v1.64.0 it failed in npm pack of the beta driver from the DevDiv feed; the same build works from public npm.
Needs, before the first run:
- PyPI trusted publisher: owner
microsoft, repository playwright-python, workflow publish.yml, environment pypi.
- A
pypi environment in this repo, with required reviewers.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't delete it yet, we don't know if gha will work out. You can disable the trigger for now.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same effort as restoring.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.