GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(video): fix the new recordVideo API by pavelfeldman · Pull Request #336 · microsoft/playwright-python

Conversation

@pavelfeldman

@pavelfeldman Pavel Feldman (pavelfeldman) commented Dec 1, 2020

Copy link
Copy Markdown
Member

Fixes #334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lironzizva reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@pavelfeldman
fix(video): fix the new recordVideo API
453ed29
@pavelfeldman
Pavel Feldman (pavelfeldman) force-pushed the recordVideos branch from d3326a5 to 453ed29 Compare December 1, 2020 21:16
dgozman
Dmitry Gozman (dgozman) approved these changes Dec 1, 2020
View reviewed changes
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 4674d1b into microsoft:master Dec 2, 2020
Pavel Feldman (pavelfeldman) added a commit that referenced this pull request Dec 2, 2020
@pavelfeldman
fix(video): fix the new recordVideo API (#336)
d400411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman Dmitry Gozman (dgozman) dgozman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when saving video recording files using recordVideo context param

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pavelfeldman @dgozman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.