GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: restrict installation to Ubuntu 18.04 by kumaraditya303 · Pull Request #665 · microsoft/playwright-python

Conversation

@kumaraditya303

@kumaraditya303 Kumar Aditya (kumaraditya303) commented May 6, 2021

Copy link
Copy Markdown
Contributor

With PEP 600 this PR restricts installation to Ubuntu 18.04 or higher.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303
fix: restrict installation to Ubuntu 18.04
8a9f1a6
mxschmitt
Max Schmitt (mxschmitt) reviewed May 6, 2021
View reviewed changes
Comment thread setup.py
wheel = "macosx_10_13_x86_64.whl"
if platform == "linux":
wheel = "manylinux1_x86_64.whl"
wheel = "manylinux_2_27_x86_64.whl"

@mxschmitt Max Schmitt (mxschmitt) May 6, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for other reviewers. This means that at least glibc version 2.27 is required which is used in Ubuntu 18.04 (verified).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mxschmitt
Max Schmitt (mxschmitt) approved these changes May 6, 2021
View reviewed changes
@mxschmitt Max Schmitt (mxschmitt) added the v1.11 label May 7, 2021
pavelfeldman
Pavel Feldman (pavelfeldman) approved these changes May 7, 2021
View reviewed changes
@mxschmitt
Max Schmitt (mxschmitt) merged commit 53cf799 into microsoft:master May 7, 2021
Max Schmitt (mxschmitt) added a commit that referenced this pull request May 12, 2021
@mxschmitt
Revert "fix: restrict installation to Ubuntu 18.04 (#665)"
78f4247
This reverts commit 53cf799.

On apt based PIP installations only PIP 20.0.2 is shippd, so we can't
assume that they have a PIP which is >= 20.3 currently. Maybe in 1-2 years.
Max Schmitt (mxschmitt) added a commit that referenced this pull request May 12, 2021
@mxschmitt
Revert "fix: restrict installation to Ubuntu 18.04 (#665)"
8ff6b3b
This reverts commit 53cf799.

On apt based PIP installations only PIP 20.0.2 is shippd, so we can't
assume that they have a PIP which is >= 20.3 currently. Maybe in 1-2 years.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman Pavel Feldman (pavelfeldman) pavelfeldman approved these changes
+1 more reviewer
@mxschmitt Max Schmitt (mxschmitt) mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kumaraditya303 @pavelfeldman @mxschmitt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.