GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Require gitpython>=2.1.0 by aarondav · Pull Request #98 · mlflow/mlflow

Conversation

aarondav commented Jun 28, 2018

Copy link

Copy Markdown

Contributor

In #90, we started importing GitCommandNotFound, which is a class added in gitpython 2.1.0. Tested locally by downgrading my gitpython to this version, and the error does not show up.

Thanks @tomasatdatabricks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Require gitpython>=2.1.0

00538a2

codecov-io commented Jun 28, 2018

Copy link

Copy Markdown

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   50.54%   50.54%           
=======================================
  Files          87       87           
  Lines        4184     4184           
=======================================
  Hits         2115     2115           
  Misses       2069     2069

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dfaea...00538a2. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tomasatdatabricks approved these changes

Jun 29, 2018

View reviewed changes

tomasatdatabricks left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

aarondav merged commit 076ec92 into mlflow:master

Jun 29, 2018

dbczumar pushed a commit to dbczumar/mlflow that referenced this pull request

Jun 1, 2022


          Updating the step class to remove pipeline_config dependency (mlflow#98)

c45b34b

Signed-off-by: Sunish Sheth <[email protected]>

Reviewers

1 more reviewer

tomasatdatabricks

tomasatdatabricks approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.