GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Return a handler from `find` in modern server repositories by chemicL · Pull Request #1282 · modelcontextprotocol/java-sdk Conversation
Member
Closes #1268 Tool and prompt repositories had separate
The features validate against the definition they found, then call its handler. Breaking: this changes the modern server's repository SPI, which shipped in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe tool and prompt repositories had separate find and call/get methods, so every tools/call and prompts/get looked the primitive up twice. That means two round trips for repositories backed by a database or remote definitions. find now returns McpAsyncTool/McpSyncTool or McpAsyncPrompt/McpSyncPrompt, which carry the definition and its handler. The call/get methods are removed from the repositories. ToolsFeature and PromptsFeature validate against the definition and invoke the handler they found. Closes #1268 Signed-off-by: Dariusz Jędrzejczyk <[email protected]> Align the resource repositories with the tool and prompt ones: find(ctx,
uri) returns McpAsyncResource/McpSyncResource, carrying the read handler,
in place of read(ctx, request). ResourcesFeature now answers an unknown
URI with the -32602 error carrying {"uri": ...} itself, so repositories
no longer build it.
See #1268
Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
Kehrlann
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
prathamgoyal787
added a commit
to prathamgoyal787/java-sdk
that referenced
this pull request
Adapt to find returning the tool with its handler (modelcontextprotocol#1282): validate the Mcp-Param headers against the found tool's definition, after the required-capabilities check and before inputSchema validation, and port the tests to McpAsyncTool.
6 of 9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsDevelopmentSuccessfully merging this pull request may close these issues. Combinefind and call/get methods in modern server repositories
Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |