GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix MessageUnpacker#unpackString in case that string length is more than... by komamitsu · Pull Request #215 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Apr 4, 2015

Copy link
Copy Markdown
Member

I modified MessageUnpacker#unpackString to fix #209.

@xerial Can you review this change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@komamitsu
Fix MessageUnpacker#unpackString in case that string length is more t…
25fc565 
…han 8192
@xerial

xerial commented Apr 4, 2015

Copy link
Copy Markdown
Member

I found another bug; This part should use ensure(strLen-cursor):

    while(cursor < strLen) {
                     if (!ensure(strLen))
                         throw new EOFException();
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xerial
xerial reviewed Apr 4, 2015
View reviewed changes
Comment thread msgpack-core/src/main/java/org/msgpack/core/MessageUnpacker.java

@xerial xerial Apr 4, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no guarantee that the read length from the input always matches Math.min(buffer.size() - position, strLen-cursor) when OVERFLOW (output buffer has insufficient space) happens. When OVERFLOW occurs, the input data might be partially read. That is why I compute readLen as bb.limit() - bb.remaining().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@xerial xerial Apr 4, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I was wrong. readLen can be retrieved by bb.position() since we created a new ByteBuffer at

ByteBuffer bb = buffer.toByteBuffer(position, readLen);

whose initial position is 0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xerial

xerial commented Apr 4, 2015

Copy link
Copy Markdown
Member

Now I got it. I don't need to set readLen in while(bb.hasRamaining()) loop. Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xerial added a commit that referenced this pull request Apr 4, 2015
@xerial
Merge pull request #215 from msgpack/issue_209
7cd8f41 
Fix MessageUnpacker#unpackString in case that string length is more than...
@xerial
xerial merged commit 7cd8f41 into v07-develop Apr 4, 2015
@xerial
xerial deleted the issue_209 branch May 28, 2015 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@komamitsu @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.