GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix buffer size to ensure by xerial · Pull Request #216 · msgpack/msgpack-java

Conversation

@xerial

@xerial xerial commented Apr 8, 2015

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xerial
Fix buffer size to ensure
b15e18f
@xerial xerial assigned muga and komamitsu and unassigned muga Apr 8, 2015
komamitsu
komamitsu reviewed Apr 9, 2015
View reviewed changes
Comment thread msgpack-core/src/main/java/org/msgpack/core/MessageUnpacker.java Outdated

@komamitsu komamitsu Apr 9, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure(int byteSizeToRead) looks to guarantee to prepare a buffer requested as byteSizeToRead. So readLen should be simply strLen - cursor? If so, maybe we can remove the outer loop.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@xerial xerial Apr 9, 2015

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like so. i'll remove it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xerial
Avoid allocating too large bufffer when unpacking string
a4c9593
@xerial

xerial commented Apr 9, 2015

Copy link
Copy Markdown
Member Author

@komamitsu
Fixed to utilize existing buffer rather than ensuring the buffer size for the whole string size.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu

komamitsu commented Apr 9, 2015

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
komamitsu added a commit that referenced this pull request Apr 9, 2015
@komamitsu
Merge pull request #216 from xerial/v07-fix-packstring
e15e30f 
Fix buffer size to ensure
@komamitsu
komamitsu merged commit e15e30f into msgpack:v07-develop Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@komamitsu komamitsu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xerial @komamitsu @muga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.