GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — asShort in ImmutableLongValueImpl should check isInShortRange by mecp · Pull Request #287 · msgpack/msgpack-java

Conversation

@mecp

@mecp mecp commented Nov 4, 2015

Copy link
Copy Markdown
Contributor

asShort() in ImmutableLongvalueImpl should check isInShortRange() instead of isInByteRange()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mecp
Fixed: asShort in LongValueImpl should check isInShortRange instead o…
382845b 
…f isInByteRange
@mecp

mecp commented Nov 4, 2015

Copy link
Copy Markdown
Contributor Author

Is it possible to do a hotfix/patch release for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu

komamitsu commented Nov 4, 2015

Copy link
Copy Markdown
Member

@mecp Could you add a test for it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mecp
added tests for integer value range checks and casts
919ab70
@mecp

mecp commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

@komamitsu I have added tests for range checks and casts. Please don't judge the code, as these are first ever scala lines produced by me. please share If something is inappropriate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mecp
fixed integer literal related issue in integer range check test
6b9d5d3
komamitsu added a commit that referenced this pull request Nov 11, 2015
@komamitsu
Merge pull request #287 from mecp/v07-develop
610553e 
asShort in ImmutableLongValueImpl should check isInShortRange
@komamitsu
komamitsu merged commit 610553e into msgpack:v07-develop Nov 11, 2015
@komamitsu

komamitsu commented Nov 11, 2015

Copy link
Copy Markdown
Member

Great. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu

komamitsu commented Nov 13, 2015

Copy link
Copy Markdown
Member

@mecp Released 0.7.1 that includes this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mecp

mecp commented Nov 14, 2015

Copy link
Copy Markdown
Contributor Author

@komamitsu Arigato.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Jayseeall222

Jayseeall222 commented Sep 1, 2021

Copy link
Copy Markdown

asShort() in ImmutableLongvalueImpl should check isInShortRange() instead of isInByteRange()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mecp @komamitsu @Jayseeall222
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.