GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add `MessagePackMapper#handleBigDecimalAsString` by komamitsu · Pull Request #745 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Jul 10, 2023

Copy link
Copy Markdown
Member

Context

We've received some issues that jackson-dataformat-msgpack fails to serialize large BigDecimal values. It's because the default internal type double can't store large BigDecimal values. We've found a workaround, but the same issue has been reported.

Changes

This PR introduces MessagePackMapper#handleBigDecimalAsString with which users can easily use the workaround, and recommends to use the new method in README

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@komamitsu
Add MessagePackMapper#handleBigDecimalAsString
1968a87
@github-actions github-actions Bot added doc feature labels Jul 10, 2023
@komamitsu
Fix EOF
2911ff5
@komamitsu
komamitsu merged commit 9586366 into develop Jul 10, 2023
@komamitsu
komamitsu deleted the handle-bigdecimal-as-string branch July 10, 2023 13:25
@komamitsu komamitsu self-assigned this Jul 10, 2023
@xerial

xerial commented Sep 27, 2023

Copy link
Copy Markdown
Member

@komamitsu It seems a similar type escalation mechanism is necessary for BigInteger as well
komamitsu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@komamitsu komamitsu mentioned this pull request Sep 30, 2023
Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString #768
Merged
@komamitsu

komamitsu commented Oct 1, 2023

Copy link
Copy Markdown
Member Author

Handled BigInteger in #768
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@komamitsu komamitsu

Labels

doc feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@komamitsu @xerial
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.