GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString by komamitsu · Pull Request #768 · msgpack/msgpack-java

Conversation

@komamitsu

@komamitsu komamitsu commented Sep 30, 2023

Copy link
Copy Markdown
Member

Context

We've already added MessagePackMapper#handleBigDecimalAsString in #745 to easily handle BigDecimal as String internally. BigInteger has a similar issue and should be handled as well.

Changes

This PR adds MessagePackMapper#handleBigIntegerAndBigDecimalAsString to handle both BigInteger and BigDecimal as String.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
komamitsu added 2 commits September 30, 2023 17:00
@komamitsu
Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString
b9ccdf9
@komamitsu
Rename unit test method names
eb65c7f
@github-actions github-actions Bot added the doc label Sep 30, 2023
@komamitsu
komamitsu merged commit 8d514ba into main Oct 1, 2023
@komamitsu
komamitsu deleted the handle-bigint-as-string branch October 1, 2023 01:45
@komamitsu komamitsu mentioned this pull request Oct 1, 2023
Add MessagePackMapper#handleBigDecimalAsString #745
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@komamitsu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.