GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add type stubs. by hoefling · Pull Request #404 · msgpack/msgpack-python

Conversation

@hoefling

@hoefling hoefling commented Feb 7, 2020

Copy link
Copy Markdown

This PR adds PEP 561 compatibility to msgpack.

I keep the type stubs from this PR for development with msgpack. The idea is to make them available to everyone by adding them to the distribution. There are no changes to the msgpack code itself, the stub is completely separated from the real code.

If you are against adding type stubs, I'd still be grateful for a review that would improve the stub quality - maybe you have a good advice on how to deal with the remaining Any types.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoefling
hoefling requested a review from methane February 7, 2020 23:17
@codecov-io

codecov-io commented Feb 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #404 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   88.06%   87.94%   -0.12%     
==========================================
  Files           5        5              
  Lines         846      846              
==========================================
- Hits          745      744       -1     
- Misses        101      102       +1
Impacted Files Coverage Δ
msgpack/fallback.py 88.81% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2849f55...c7f6c8b. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoefling added 5 commits February 21, 2020 13:18
@hoefling
add type stub for the msgpack package
24d01f8 
Signed-off-by: Oleg Höfling <[email protected]>
@hoefling
add py.typed marker for PEP 561 compatibility
8b9e871 
Signed-off-by: Oleg Höfling <[email protected]>
@hoefling
include type stubs in the distribution
2bba914 
Signed-off-by: Oleg Höfling <[email protected]>
@hoefling
move the unpacker type var inside the unpacker class to ensure clean …
547beb6 
…a mypy run

Signed-off-by: Oleg Höfling <[email protected]>
@hoefling
updated according to signature changes in 1.0
c7f6c8b 
Signed-off-by: Oleg Höfling <[email protected]>
@hoefling
hoefling force-pushed the type-stubs branch from c36cc1e to c7f6c8b Compare February 21, 2020 12:29
@methane methane mentioned this pull request Jan 27, 2021
Adding type stubs #448
Open
@methane methane changed the title Add PEP 561 compatibility Add type stubs. Jan 27, 2021
@methane

methane commented Jan 27, 2021

Copy link
Copy Markdown
Member

I'm sorry, but I am not an expert of typing and I can not maintain it.
I don't want to merge I can not maintain. So I don't merge this pull request anytime soon.

I will drop Python 2 support completely in next major version (in 2021 or 2022). I will reconsider this after it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoefling

hoefling commented Jan 27, 2021

Copy link
Copy Markdown
Author

@methane no worries, I see that someone has created a stubs-only package recently: https://github.com/sbdchd/msgpack-types. So this is not an issue anymore, thus closing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoefling hoefling closed this Jan 27, 2021
@peasoft peasoft mentioned this pull request Jan 2, 2026
Add typing in Python code #660
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoefling @codecov-io @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.