GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add typing in Python code by peasoft · Pull Request #660 · msgpack/msgpack-python

Conversation

@peasoft

@peasoft peasoft commented Jan 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Add Python 3.10-style typing for msgpack-python.

Compared to sbdchd/msgpack-types and #404, this PR added typing for all Python codes.

Closes #448

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
peasoft added 4 commits January 2, 2026 22:44
@peasoft
add type stub
acdcdbc
@peasoft
fix lint
1c33b7e
@peasoft
fix lint
b9d495d
@peasoft
fix typing
95d1b4d
@peasoft peasoft changed the title Add type stub Add typing in Python code Jan 4, 2026
KowalskiThomas
KowalskiThomas reviewed Apr 29, 2026
View reviewed changes
Comment thread msgpack/ext.py
__slots__ = ["seconds", "nanoseconds"]

def __init__(self, seconds, nanoseconds=0):
def __init__(self, seconds: int, nanoseconds=0):

@KowalskiThomas KowalskiThomas Apr 18, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also have typing for nanoseconds? Or are you deliberately not adding type annotations where the type can be deduced maybe?

I'm asking because I believe e.g. mypy wouldn't like this (partial type hinting in function definitions)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@peasoft peasoft May 1, 2026

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My typing is intended for VS Code's (and maybe other editors') auto complete, so I didn't add type annotations where the type can be deduced.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@KowalskiThomas KowalskiThomas May 10, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW if you're planning to get this merged, I'd highly recommend to go ahead and fully type it, even for things that pyright (which VSCode uses) can infer -- it'll probably be helpful to more people and is only marginally more work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane

methane commented Sep 5, 2026

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@KowalskiThomas KowalskiThomas KowalskiThomas left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding type stubs

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@peasoft @methane @KowalskiThomas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.