GeezerVison

Summary

Service discovery interpolated target strings directly into YAML, allowing values to change a generated job's structure or type. An IPv6 address could prevent parsing, while a name such as on could become a boolean.

Add a job template helper that accepts key/value pairs or a prepared map and captures a detached, correctly encoded collector job. Authors no longer need a toYaml pipe or whitespace trimming. Multiple calls preserve order; template errors or mixing submitted jobs with rendered text discard that rule's entire output. Existing raw-YAML templates and toYaml remain supported.

Migrate all owned stock rules, Dynamic Configuration forms, and discovery examples to job. Complete SNMP single-line metadata normalization for control characters and Unicode line separators while preserving existing character removals.

Test Plan

• Helper tests cover exact values and types, immediate snapshots, nested maps/lists, invalid arguments, safe helper diagnostics, atomic failures, state isolation, named templates, legacy compatibility, and absence from match expressions.
• Actual-source regressions and before/after comparisons cover stock rules, forms, examples, conditional branches, ordered jobs, IPv6, controls, invalid UTF-8, and SNMP versions.
• Pipeline tests verify authority stamping and both secret consumers for legacy and job output without mutating target maps.
• Passed discovery, SNMP helper/collector, vnode, stock registry, and form-schema checks; pipeline vet and focused race checks; job-manager race suite. One existing listener-helper test timed out during the parallel run and passed when its package was rerun alone.
• Passed 99 integration tests, isolated catalog/page generation, and adversarial execution of 26 templates extracted from generated pages.

Additional Information

Generated documentation follows the normal post-merge regeneration workflow; this PR updates its authoritative sources.

Summary by cubic

Service discovery now builds complete typed jobs and serializes them as YAML via a new job template helper, so discovered values can no longer alter a job's structure or YAML type.

The job helper takes key/value pairs or a prepared map, defaults module to the rule ID when omitted, supports emitting multiple jobs per rule, and rejects mixing submitted jobs with rendered text. Stock rules, Dynamic Configuration defaults, and documentation now use it. SNMP metadata normalization also handles control characters and Unicode line separators. Adds regression tests covering injection, scalar coercion, IPv6, multiline values, and conditional fields. Registry checks recognize the structured job form.

• Migration: Existing custom rules and saved Dynamic Configuration jobs are not rewritten; the updated guide shows how to migrate templates to whole-job serialization.

^{Written for commit 1888292. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Service discovery templates can create one or multiple collector jobs, with support for maps and key/value arguments. Existing YAML-based templates remain supported.
• Improvements
  • Generated jobs preserve value types and service-specific settings. SNMP metadata now replaces control characters with spaces while preserving ordinary Unicode text.
• Bug Fixes
  • Improved handling of special characters and multiline values in generated service discovery configurations.
• Documentation
  • Updated service discovery examples and guidance to cover job creation, module defaults, legacy YAML support, and troubleshooting.