GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Last-Modified header for GET and HEAD by SarthakDudhe · Pull Request #1856 · nodeSolidServer/node-solid-server

Conversation

@SarthakDudhe

@SarthakDudhe SarthakDudhe commented May 6, 2026

Copy link
Copy Markdown

Summary

  • add Last-Modified headers to successful GET and HEAD responses
  • use the file or container mtime as the header value
  • add integration coverage for both resources and containers

Fixes #1793.
Tests

  • npm run mocha-integration
  • npm run lint

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SarthakDudhe
Add Last-Modified header for GET and HEAD
a8894b9
csarven
csarven requested changes May 6, 2026
View reviewed changes

@csarven csarven left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Tested and seems to work as intended. I haven't run the tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csarven
csarven self-requested a review May 6, 2026 14:53
csarven
csarven approved these changes May 6, 2026
View reviewed changes
@bourgeoa

bourgeoa commented May 7, 2026

Copy link
Copy Markdown
Member

@SarthakDudhe Thanks for working on NSS. This is really needed. We may have discussion on what you could work on : implementing the Solid notifications spec !!!! or replacing inrupt OIDC client browser with UVDSL one.

@csarven
I think none of the solid servers does this.
The information is available in the Container not at Resource level
CSS does load the information in .meta (it was added for non filesystem to be able to render in Container).
This has made .meta only Patchable which is not Solid compliant.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csarven

csarven commented May 7, 2026

Copy link
Copy Markdown
Member

@bourgeoa , it is required in Solid Protocol. It is also a server-controlled header, as opposed to a resource description, which may or may not be modifiable. The other advantage is being able to get this information using HEAD instead of fetching the whole resource payload with GET.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlyNotMe AlyNotMe mentioned this pull request Sep 23, 2026
fix: add Last-Modified header to GET and HEAD responses #1875
Open
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csarven csarven csarven approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Server should include the Last-Modified header

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SarthakDudhe @bourgeoa @csarven
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.