GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add Last-Modified header to GET and HEAD responses by AlyNotMe · Pull Request #1875 · nodeSolidServer/node-solid-server

Conversation

@AlyNotMe

@AlyNotMe AlyNotMe commented Sep 23, 2026

Copy link
Copy Markdown

Summary

  • Adds a Last-Modified header to GET and HEAD responses, using the resource's mtime from fs.stat
  • The header is only set when access has been granted (the request already passed the Read permission check before reaching this handler), in line with the protocol's requirement to avoid exposing information beyond what's necessary
  • mtime is now propagated through LDP.get() for all three return paths (HEAD-only, container, and file streaming)

Fixes #1793

Test plan

  • Added integration tests in test/integration/header-test.mjs covering both GET and HEAD requests
  • npm run lint passes
  • Full test suite passes (867 passing, 0 failing)

Note: I noticed #1856 already addresses this and has been approved — opening this anyway in case it's useful, happy to close if redundant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlyNotMe
fix: add Last-Modified header to GET and HEAD responses
60402ad 
Only sent when access is granted (200 path), using the resource's
mtime from fs.stat, as required by the Solid protocol.

Fixes nodeSolidServer#1793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Server should include the Last-Modified header

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@AlyNotMe
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.