GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use curl-config to find curl by saper · Pull Request #1237 · nodegit/nodegit

Conversation

@saper

@saper saper commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

On BSDs headers will be in /usr/local/include which
is not added to the include path automatically.

Follow-up-to: #1195

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
valpackett, mfechner, Croydon, and antoinell reacted with thumbs up emoji
All reactions
  • 👍 4 reactions
@saper

saper commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator Author

Maybe this would even work for Windows?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@implausible

implausible commented Feb 28, 2017

Copy link
Copy Markdown
Member

The only reason to bring libcurl into NodeGit is to enable proxy and authenticated proxy transports in OSX and Linux. Windows already has full support for proxies.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@implausible

implausible commented Feb 28, 2017

Copy link
Copy Markdown
Member

@saper should rebase this on master so the 32 bit linux tests passes. This is definitely a good idea.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnhaley81

johnhaley81 commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

@saper could you rebase this please? I'd like to get this in for the next release. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saper
Use curl-config to find curl
785f184 
On BSDs headers will be in /usr/local/include which
is not added to the include path automatically.
@saper
saper force-pushed the curl-config branch from 8b09b9c to 785f184 Compare February 28, 2017 22:00
@saper

saper commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator Author

Rebased... well it was master and the time I wrote this :) and there were no conflicts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rsmarples

rsmarples commented Aug 5, 2017

Copy link
Copy Markdown
Contributor

What needs to be done here to progress this?
I need these changes for building nodegit on NetBSD.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rsmarples rsmarples mentioned this pull request Sep 29, 2017
Add more platforms to the setup #1362
Closed
@rsmarples rsmarples mentioned this pull request Nov 2, 2017
build: use pkg-config to find curl header #1328
Closed
@valpackett

valpackett commented Nov 2, 2017

Copy link
Copy Markdown

Please merge this, npm i nodegit fails on FreeBSD without this, having to locally fix this and npm link is getting annoying.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rcjsuen rcjsuen mentioned this pull request Jan 22, 2018
NodeGit does not compile on FreeBSD, with curl/curl.h not found #1429
Closed
@mfechner

mfechner commented Jan 23, 2018

Copy link
Copy Markdown

Are there plans to include this patch, I can confirm that it fixed the problem.
mojavelinux, Croydon, and antoinell reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sgilroy pushed a commit to TwineHealth/nodegit that referenced this pull request Feb 25, 2018
@saper @sgilroy
Use curl-config to find curl
74fd582 
On BSDs headers will be in /usr/local/include which
is not added to the include path automatically.

(cherry picked from commit 785f184)
[nodegit#1237]
@antoinell

antoinell commented Jul 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The code in this pull request helps with the build on FreeBSD and Ubuntu 16.04. Hopefully it can get merged soon. I see that there is an error in a build on windows done by appveyor, this seems unrelated to the code changes here which do not affect windows as far as I understand.
antoinell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antoinell antoinell mentioned this pull request Jul 6, 2018
errors installing and running git meta on FreeBSD : Error: Cannot find module '../build/Debug/nodegit.node' twosigma/git-meta#622
Closed
This was referenced Sep 20, 2018
Node 10 support #1545
Merged
Update dependencies #1519
Merged
@Croydon

Croydon commented Sep 25, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@implausible Can we merge this now? Both #1545 and #1519 is containing it too, but getting this done step by step seems reasonable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@implausible

implausible commented Sep 25, 2018

Copy link
Copy Markdown
Member

@Croydon The tests are failing. @saper Any chance you can rebase this to get the tests running again on CI? It looks like Travis doesn't even know about this PR.

Otherwise if @saper is unavailable, I would support it if you, @Croydon, took control of this PR by opening a new branch + PR with it. We would close this PR, reference this PR in your PR, and merge your PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Croydon Croydon mentioned this pull request Sep 25, 2018
Use curl-config to find curl #1555
Merged
@implausible implausible closed this in #1555 Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@saper @implausible @johnhaley81 @rsmarples @valpackett @mfechner @antoinell @Croydon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.